Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     "Christopherson,, Sean" <seanjc@google.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: RE: [PATCH v5 05/34] x86/traps: export external_interrupt() for VMX
 IRQ reinjection
Thread-Topic: [PATCH v5 05/34] x86/traps: export external_interrupt() for VMX
 IRQ reinjection
Thread-Index: AQHZUKG3Kdahp7VGA0+nukurnTn7Fq8HLL6AgABOnsA=
Date:   Wed, 22 Mar 2023 22:38:15 +0000
Message-ID: <SA1PR11MB6734A61E1F8F442BF1D6FB4FA8869@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20230307023946.14516-1-xin3.li@intel.com>
 <20230307023946.14516-6-xin3.li@intel.com> <ZBtAQc8Jz5GWGrJr@google.com>
In-Reply-To: <ZBtAQc8Jz5GWGrJr@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s620nc5hTHA89bEY/3aXSRV94sAGuI7ibdKg1nCP3wB/3cU7EUOjOgSiyAWA?=
 =?us-ascii?Q?wQbcHyUGnp4dsBrInELGkwV0bg1sunIBJngBUmPztV6g3FjYRMqnlqVLauCT?=
 =?us-ascii?Q?E2UgYGTPRVc6QQQT3VV8cFEce9Tfivcin6214mgvoGA81z6xo3ttYyVHyxmy?=
 =?us-ascii?Q?R80rS+P/qGgjnyEZAyHgB+LMf2qpY8vMpRlZvH9u9ZaYZAnMdtLBhwPKVR8b?=
 =?us-ascii?Q?cagaMccB3gSKcTdlB2wz/UuSljzSlKpfhn7eu5V7oWXm+AHHk0ufGrn5qj4W?=
 =?us-ascii?Q?ttnyJ5cbvbcKzdyKoktmSWoPpa8Lbt4v8kpskkrqpuwkUt2INxrsGZg+qHR3?=
 =?us-ascii?Q?RgiJTzM2aV9jepNHJmQw1z6/dd5GM+29XuF22jiHrfPjWjWmTa2Gw8FF3KGy?=
 =?us-ascii?Q?mzzmuGoPuDWWXgR4tRiXnBW3Vk0PD2GuBG9O3C84MsEE2AfKdCtt3Au2WBG6?=
 =?us-ascii?Q?2XMjyG/jIk1uE3cEFr3zoDpoNSpFpD5k0TTPv9XsKmlmCoGND2MMHvzxiivY?=
 =?us-ascii?Q?VgQLVnp8bSu47sHD00LfnW/+OumFvjCaCNOiRbZOLVjl+PSkkbOPjFopk7un?=
 =?us-ascii?Q?MwEWruZBt77bTsbZFqs1DC9xbERw9lsr96QEcSgBjvgPI6G/E2NfahALg7zd?=
 =?us-ascii?Q?ynFOqUM+XjZS640hk3pyoltYJOv7+ceBe9rhEOfehfKOFF/hT6rR5+ZF0P0/?=
 =?us-ascii?Q?lb+/JeItHX9pNtRzGAgbuKaNM3+JlTT6szYy6zltU4iWOnMbbu2eAcxcUn85?=
 =?us-ascii?Q?K6b6G8CE0LMMp6emSTirlIA3Bo99eVT+wEYY0ms0q8cZGwS/kO58CCfZidE0?=
 =?us-ascii?Q?tERgozN0r5mOeAeeguHPO2oFGOTw4pZk9IVktJF55rkEMj4tI+DX4XYJhSPH?=
 =?us-ascii?Q?o1ddlRROWPneHay3khYVLOJYCRWSfA30HcHiyz7su49KP8AXmpiaOjFGXm4Z?=
 =?us-ascii?Q?VAX2b324JW1rEICWDLmKx3WhElF0xzlKo5ThIc8FsRhKgc/qWFVE0jiPHeYu?=
 =?us-ascii?Q?rGJTPkTX/w/aaIz9xm6+oWmKZvM+Q/ID1IhmjdxbhDt4uRYVDxfaD4sFo+U0?=
 =?us-ascii?Q?tNrdSQ5160mifXAI3MB13TvUCzMtn6/qvJMoQwEYBoJzFv5MErt0OQbXgxsO?=
 =?us-ascii?Q?y2HGxAneYWrfVMwzzVxg8/jPpdrSBkGaj6PY7dTh+TeGDzGi7j8pf1QXy9wS?=
 =?us-ascii?Q?dqdbV5SKCQPYEYLK3LHSzdHDV8YGt2WuIBQmpBZPARozxKqUY2KXKmmNlt9I?=
 =?us-ascii?Q?k4PXmdyFeD9uKJCPRn91qAYqaQqqlnu17NQrq3J4/d661IpVgJebu32NHjpK?=
 =?us-ascii?Q?8s86XzWiXEtT6SYVPH3w1NSiIJ9K8psk2NogMp/Cy9d9j9v/eIdCCcLNf4Sj?=
 =?us-ascii?Q?T7iFzn8V1GpG7XFI1AIZhJBkPoT4r7x6VpTAVmEasEeClORUi3RbCr0H8Gq/?=
 =?us-ascii?Q?v33aTuiT75ztM5bqYA/uGoOC9fJJAnIQvp0qBGZiADn0aAOS9l1Gc4kL9jEa?=
 =?us-ascii?Q?z3qU7nh1PWkD4rxiOYKZuUx8wMnD18tPUEGG9Dz/cEG5Tr0GmGcICqhBoy9B?=
 =?us-ascii?Q?vhPAc1eiNxMhdDmOl4E=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3a6b9b5-acaf-480b-1152-08db2b26202e
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2023 22:38:15.1230
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: frSyZ/37Hjw+UiLtMfA649Y9Q4+ucRKLSMO7CZc9K9nyQNPjR+Ddq5g9DmWlyzjuSERG0BsPEUIw+8nvaCUL7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5904
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +#if IS_ENABLED(CONFIG_KVM_INTEL)
> > +/*
> > + * KVM VMX reinjects IRQ on its current stack, it's a sync call
> > + * thus the values in the pt_regs structure are not used in
> > + * executing IRQ handlers, except cs.RPL and flags.IF, which
> > + * are both always 0 in the VMX IRQ reinjection context.
> > + *
> > + * However, the pt_regs structure is sometimes used in stack
> > + * dump, e.g., show_regs(). So let the caller, i.e., KVM VMX
> > + * decide how to initialize the input pt_regs structure.
> > + */
> > +EXPORT_SYMBOL_GPL(external_interrupt);
> > +#endif
>=20
> If the x86 maintainers don't object, I would prefer this to be squashed w=
ith the
> actual KVM usage, that way discussions on exactly what the exported API s=
hould be
> can be contained in a single thread.

The KVM usage is the only one now, thus it does make sense to squash into o=
ne.

I'm working on v6 and will merge this patch into the corresponding KVM patc=
h.
BTW, I will stop using "reinject" as asked.