Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 22 Mar 2023 18:26:56 -0700
In-Reply-To: <BYAPR21MB16884B3D0E15E501A7BB8E78D7869@BYAPR21MB1688.namprd21.prod.outlook.com>
Mime-Version: 1.0
References: <1677523568-50263-1-git-send-email-mikelley@microsoft.com>
 <dce372bd-e63c-f24c-5b79-1ef65fd1e59a@intel.com> <BYAPR21MB16884B3D0E15E501A7BB8E78D7869@BYAPR21MB1688.namprd21.prod.outlook.com>
Message-ID: <ZBuq4KjU2ekKk+iS@google.com>
Subject: Re: [PATCH 1/1] x86/irq: Add hardcoded hypervisor interrupts to /proc/stat
From:   Sean Christopherson <seanjc@google.com>
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     Dave Hansen <dave.hansen@intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Wed, Mar 22, 2023, Michael Kelley (LINUX) wrote:
> From: Dave Hansen <dave.hansen@intel.com> Sent: Wednesday, March 22, 2023 11:07 AM
> > 
> > On 2/27/23 10:46, Michael Kelley wrote:
> > > diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> > > index 766ffe3..9f668d2 100644
> > > --- a/arch/x86/kernel/irq.c
> > > +++ b/arch/x86/kernel/irq.c
> > > @@ -211,6 +211,13 @@ u64 arch_irq_stat_cpu(unsigned int cpu)
> > >  #ifdef CONFIG_X86_MCE_THRESHOLD
> > >  	sum += irq_stats(cpu)->irq_threshold_count;
> > >  #endif
> > > +#ifdef CONFIG_X86_HV_CALLBACK_VECTOR
> > > +	sum += irq_stats(cpu)->irq_hv_callback_count;
> > > +#endif
> > > +#if IS_ENABLED(CONFIG_HYPERV)
> > > +	sum += irq_stats(cpu)->irq_hv_reenlightenment_count;
> > > +	sum += irq_stats(cpu)->hyperv_stimer0_count;
> > > +#endif
> > >  #ifdef CONFIG_X86_MCE
> > >  	sum += per_cpu(mce_exception_count, cpu);
> > >  	sum += per_cpu(mce_poll_count, cpu);
> > 
> > This seems fine, especially since arch_show_interrupts() has them.  But,
> > what's with the "#if IS_ENABLED" versus the plain #ifdef?  Is there some
> > difference I'm missing?  Why not just be consistent with the other code
> > and use a plain #ifdef for both?
> 
> I'm following the coding pattern in arch_show_interrupts(), in irq_cpustat_t,
> and most other places that test CONFIG_HYPERV.   Maybe all those existing
> cases are a mis-application of Documentation/process/coding-style.rst
> Section 21, which prefers "if (IS_ENABLED(CONFIG_HYPERV))" over
> "#ifdef CONFIG_HYPERV".  "#if IS_ENABLED()" is not the same as
> "if (IS_ENABLED())".  :-)
> 
>  Net, I don't have a strong preference either way.

Using IS_ENABLED() is mandatory because CONFIG_HYPERV is a tri-state, i.e. can
be a module and thus #define CONFIG_HYPER_MODULE instead of CONFIG_HYPERV.