Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7065197rwl; Wed, 22 Mar 2023 21:27:17 -0700 (PDT) X-Google-Smtp-Source: AK7set/46yIF6UQSy70X5oqkYmwRFvKNhIdTsPTI+DGNmTShX4I4k0fe03x2LIp9UQypA4zsC0qi X-Received: by 2002:a17:907:2cf2:b0:932:c1e2:998b with SMTP id hz18-20020a1709072cf200b00932c1e2998bmr8709060ejc.15.1679545637010; Wed, 22 Mar 2023 21:27:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679545636; cv=none; d=google.com; s=arc-20160816; b=U+CAI1Rw5SyO26rBHw4pQuXh+ob4jD1VQ94NL1FPaeXDmJjoQaUR9TWJrA126BQdUH 1iID5fYnfoJosHos7I6IkKat7rqPqy+y4Re7/6bSamL/XMe4Vq6YY/pLGhBHBfoKckzF okyZfnwJP1Q9+dofjwpueDEMTQJk1h+whE7tMuFR5Rt1FH8E4GwiuAREpbwdpGUpR689 Pmo3m9diXX7l/P/KfCY2bkIzAobUgvS5k5N50/souwZIqNMDOVDIfHEQdLfdVERDv3aK oWbjGlqN/fTf59I3sDE87tQsNZPdH8b/JKYvV3Z7etjB1h7XoL9en727au/Q44iq1Tm9 nqjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mlXvTHXYJ+WBZtix9dhye10LhVMBFV2zL0D9fjyzeAs=; b=E+T6VP0VKxUKofkkLIkdFutkhRMdA2oO6Qi99OTsetfLDONLexjGnZh80DmJLnosis 8dA43KIteRzEO75AHXaJ4mh9XB5rvj/qAMl6AYc9XoogS/pobF9FCgbaXlWTPXqb9ET4 oNyuceUShGDDA6+0/N+IRh2xwTrQBOzenSozvAK5bOv/k8E0WTs7ATMMJoXH4pn6FCVP wvqUMPRXi70jZHneiyvlix0O9PpUqKgKZEk80PuzyxLSXU1et1KNnbSPrhb3Nt1WSO6L ch/dm57ihnflzpkhThFGoFySh3QyFElt0TVz51O5+mc5nJtNSum6dN63LorjyHtC/ACX VbkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=I23woQEI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4-20020a17090682c400b00922528b3dcesi16979541ejy.983.2023.03.22.21.26.52; Wed, 22 Mar 2023 21:27:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=I23woQEI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbjCWEQE (ORCPT + 99 others); Thu, 23 Mar 2023 00:16:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbjCWEQB (ORCPT ); Thu, 23 Mar 2023 00:16:01 -0400 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0323035BE for ; Wed, 22 Mar 2023 21:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1679544921; bh=amePZAswCZxnH0HeDHnJFI+gYZgT7zu0jXMkYntGVqE=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=I23woQEI4sc/sCfZ4ELvool5T+tNHo0ty69z/W+kUdjfs/7NROrQIAC4fMANAAlv+ 2X6eXvju2xkd2PtUC/ZLwYJkqNw5TgyDJXXZLfbZJRH40vu+pvjQOb1gOpis/Rvh/i BdOtEOuPlzxq1wY8WO772T0Wx+Lq5FUAuu4QYHjU= Received: by b221-3.in.mailobj.net [192.168.90.23] with ESMTP via ip-20.mailobj.net [213.182.54.20] Thu, 23 Mar 2023 05:15:21 +0100 (CET) X-EA-Auth: MqpSBc+VIot+UUjG5z9STlJgrWHjIBGzlEqbIKY79KgmtCwouDOtNFJrNhCxglWEJd+gf/ccKY2TkkvhxmO0sXsACRkL8WTt Date: Thu, 23 Mar 2023 09:44:59 +0530 From: Deepak R Varma To: Randy Dunlap Cc: Khadija Kamran , outreachy@lists.linux.dev, Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn Subject: Re: [PATCH v2] staging: most: fix line ending with '(' Message-ID: References: <061a2fea-b3da-551d-f6d2-0da30b0ac879@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <061a2fea-b3da-551d-f6d2-0da30b0ac879@infradead.org> X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2023 at 08:12:23AM -0700, Randy Dunlap wrote: > Hi-- > > And FTR, I still haven't found anything in coding-style.rst that says that > lines should not end with an open parenthesis. Did I overlook it? Hi Randy, You are correct. I did not find anything clear or obvious that calls out not ending the lines with a '(' symbol. I think the other guideline from the coding style is to align the overrunning argument list in the next lines such that they match the arg1 after '('. So, I think that may be the reason why checkpatch is coded to catch such lines. Regards, Deepak. > > Thanks.