Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7085888rwl; Wed, 22 Mar 2023 21:57:22 -0700 (PDT) X-Google-Smtp-Source: AK7set+VNPAkEn7J7h+cFqBOm4T8c7EwYc/anS1kJHHqRILhAyLcY6VI1++xeKuwxrWS2gg6htAK X-Received: by 2002:a17:907:e8d:b0:907:183f:328a with SMTP id ho13-20020a1709070e8d00b00907183f328amr11852423ejc.65.1679547441982; Wed, 22 Mar 2023 21:57:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679547441; cv=none; d=google.com; s=arc-20160816; b=g0JEht5tXcxtwu8qRuqafJ9xrQaZ8wj0zmgXTv21mYrxSTQ0SCzvCqahXuMsYcvW+a CYDyF/psQ0K++gVIF1cHQjLd+nIuih1PWTTfwJ1W5wxQT6H/d+D5JUzn1uRYyiaWfBwq P5oNENGbS3t7E+jWvSAQMBmmj+J4RZGu6GA/Fff1jQBY+1Z+rNXQuQi4UijEWwouko1Z d+q0bw92/z6wq186MK2J4cw2X/P93nwviAUTILuBMwvKx65C14qm3Tn+NLD4s4clLZvL PePy4Nsb+ofLxIuQ0Rcm6+5b6vODMgQXYDa74vHhxNhcUWXAy++ArzjoFUkvjLxa2Cp1 tQbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=O6sfmTJEryrrzqob52gt2aWkcnjbQQTqAbD0GHbGGnE=; b=GOZxGoBQLd5Nzza5H12I4Ai9bzYVUk7LzHNFzlNL7m5/t+P5gUqLr7P4nt5zDJfpkL y/3tAChfFfvTGHoCrUaP1mzJVRt6qXsipXRTZpjYOrjKFGRgA1lXPbDb60CTMvzEnLQs IW11MTKGFxDVKNnRBMSVjr7ws2r1NouIBLZXeKwyst/m5clGDJaastXOyHn603m9TmvB whHPcszDpYtyzWn5mpxZY5aXvQcB2SrFhMg5G9QNTdFrL/wCnYu6Z+tbTfqizpTf4nwn 5xTC94wFfLkrGJsMiKAFiNAti3TdH7ixbLLOi3V9V3L0KXX2H73wXuNpPmVB6MLEblB7 YwCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Y276/HWl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020aa7c983000000b004fb223a76f0si17763931edt.320.2023.03.22.21.56.58; Wed, 22 Mar 2023 21:57:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Y276/HWl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbjCWEze (ORCPT + 99 others); Thu, 23 Mar 2023 00:55:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbjCWEza (ORCPT ); Thu, 23 Mar 2023 00:55:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5A5A2914F for ; Wed, 22 Mar 2023 21:55:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 649B9623C2 for ; Thu, 23 Mar 2023 04:55:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7090AC433EF; Thu, 23 Mar 2023 04:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679547324; bh=L8V8tdH9v0Pzz/Q+0e1Gx1r0FWztww1FBu2Dj3c0Zd8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y276/HWlE/usJ9mOqeGEygGMOaJ873CjPrJP0yUashiHXnS55OsV9kHzk5LpwNmc6 HxyurKiolWUokkf3wvgF+W8GixkYYq7DsxycdlRWe+5kgRZZFTyNFQFs/IRmhJJHYs G1OLwZWgRcb+I1ihBrL6TkvNbspht8ZJSLHrPuQ4= Date: Thu, 23 Mar 2023 05:55:21 +0100 From: Greg Kroah-Hartman To: Rohit Chavan Cc: Martyn Welch , Manohar Vanga , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: vme_user: Fixing coding style issues reported by checkpatch Message-ID: References: <20230322142923.723-1-roheetchavan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230322142923.723-1-roheetchavan@gmail.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2023 at 07:59:23PM +0530, Rohit Chavan wrote: > Fixing alignment should match open parenthesis issue on multiple lines, > reported by checkpatch script. You might want to mention on the subject line that this is a parenthesis issue, right? > Signed-off-by: Rohit Chavan > --- > drivers/staging/vme_user/vme_tsi148.c | 102 +++++++++++++------------- > 1 file changed, 51 insertions(+), 51 deletions(-) > > diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c > index 2f5eafd50934..716de1d7fe21 100644 > --- a/drivers/staging/vme_user/vme_tsi148.c > +++ b/drivers/staging/vme_user/vme_tsi148.c > @@ -55,14 +55,14 @@ static struct pci_driver tsi148_driver = { > }; > > static void reg_join(unsigned int high, unsigned int low, > - unsigned long long *variable) > + unsigned long long *variable) For many of these, you can just move the line to the previous one, making it a single line, right? That would make the code much more readable. thanks, greg k-h