Received: by 2002:ac8:156:0:b0:3e0:cd10:60c8 with SMTP id f22csp2345899qtg; Wed, 22 Mar 2023 22:10:09 -0700 (PDT) X-Google-Smtp-Source: AK7set/nrj6pUWT7F5RVzTPmxuxpE+rVwwT/UfctE+f8dMi0vDbjDxc0JDk5lAc0kqOyqw6mQJbX X-Received: by 2002:aa7:dbcc:0:b0:4fd:5a28:2eff with SMTP id v12-20020aa7dbcc000000b004fd5a282effmr7894590edt.26.1679548209651; Wed, 22 Mar 2023 22:10:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679548209; cv=none; d=google.com; s=arc-20160816; b=RTejqAZSgw1bia0yT3vzLBeY6G2LRnC+SAAmdC0e2NCyGkdRX0sImfvFiqhay7izlk dHfYqyXNS6TIwoPmiQfH0SFGMpsltAem1BsdafmeWAKKm52/N/OdvL/tIe8VZIuOt25q VCJMN4RfKG46LfJkcDUiIK2dH4/g8kTo0XDWY5Y4MN0gAJ4rpoxTp15foEL+omsjsHKm oSqXGD+AoVQHPB9eQcY6EDCBdh6HeqoxR891JggLFi/VKU4uSVbpAvru3YRSMTc/ii3s +IFbxvCopdsipwXnTOMZ/+lyTZ/upOFIUAxefHjcAMBYU6py6gZ/puTqLdvbOJ9oDHE7 yFTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jnqFxoe8Oo5ZwYhvLityqKKiZQGL/6qmGXfCQVBihDU=; b=tMVdmWHAQbH9ZSQ5wpUmOjcL0QFn0S1Ua2PHPKcn/AkxiStvMKXlk+6iaLz1FDYegv UpCA3RJwnZgyhqPApNDU8VW7crhW3GaZsKN1SdQciuzAJLiknSODb5CjvqlEfkHnPh1z wg7w5uj38q4fscq2WqiAzxW/1vER1h3LoHURfizw4GZ6W8StMA6umij7xBJuIXRLJh0h 0JJprYPRP4R6ErDLFOesxpNHBnJ40PERCU2y0QJ1UQxLimnxzQn20Frhhs6leWNJ9TJj Lf1LoV5KNwK3O5Jfb60bM/HINWuPKSW8Mzxzh5oBkAWNQwC1kdLkEdFVB13xJPS1cBzx 7WKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=ba1lIJSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020aa7dad1000000b004a18f2ffb81si18713504eds.321.2023.03.22.22.09.44; Wed, 22 Mar 2023 22:10:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=ba1lIJSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229941AbjCWFGp (ORCPT + 99 others); Thu, 23 Mar 2023 01:06:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjCWFGn (ORCPT ); Thu, 23 Mar 2023 01:06:43 -0400 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9E5318B14 for ; Wed, 22 Mar 2023 22:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1679547980; bh=S+uqErVyJkzz4n1QVzjO1/HkYrFW3SD+hKC0FjAnjpQ=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=ba1lIJSY/bHFjwDpebtoqt9ECrtbQk2RTlB76H82Be6JT9wmTWJaiG3D6XU4N8HZZ uO5NOGuhWzHlb20bQf3qYlCHbX9n5d2j7r0KyPWqvVoA2En/MqnFVdAh3FuYzWV3P+ vseZtjAH1S5HZfLMgOYyRZlmr18FMS9OW8WTEyq4= Received: by b221-4.in.mailobj.net [192.168.90.24] with ESMTP via ip-20.mailobj.net [213.182.54.20] Thu, 23 Mar 2023 06:06:20 +0100 (CET) X-EA-Auth: x0hDPzU8TaWpIUg/LIBGQaCa74TJKUC8rvzPKoljQwtzLawHT5P7+rMyNcGYbGDsaUlz0C+kC9tkB9Oa3L284UXtdOJavh1a Date: Thu, 23 Mar 2023 10:35:59 +0530 From: Deepak R Varma To: Greg KH Cc: Julia Lawall , Alex Elder , Menna Mahmoud , outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: greybus: use inline function for macros Message-ID: References: <20230321183456.10385-1-eng.mennamahmoud.mm@gmail.com> <2e869677-2693-6419-ea25-f0cc2efcf3dd@ieee.org> <5efa6e6d-8573-31de-639a-d15b2e9deca0@ieee.org> <48674d8f-9753-780c-f37c-f83ea2855ae6@ieee.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2023 at 05:58:02AM +0100, Greg KH wrote: > Nice, that shows that it is the same both ways as the compiler version > you are using is smart enough > > Which compiler and version is this? Does it work the same for all of > the supported versions we have to support (i.e. really old gcc?) > > For the most part, sysfs files are not on any sort of "fast path" so a Hello, Is there a guideline/documentation on how to identify if a code is part of fast/slow path? > function call is fine, but as I mentioned before, sometimes we are > forced to move calls to container_of() to container_of_const() and that > can not be an inline function, but must remain a macro :( > > thanks, > > greg k-h >