Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <acfe667f-f598-ba6f-7723-ad5c55bc746d@amd.com>
Date:   Thu, 23 Mar 2023 11:36:49 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [RFC PATCH kernel 0/2] PreventHostIBS feature for SEV-ES and SNP
 guests
From:   Manali Shukla <manali.shukla@amd.com>
To:     linux-kernel@vger.kernel.org
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        jolsa@kernel.org, namhyung@kernel.org, tglx@linutronix.de,
        bp@alien8.de, dave.hansen@linux.intel.com, seanjc@google.com,
        pbonzini@redhat.com, jpoimboe@kernel.org,
        pawan.kumar.gupta@linux.intel.com, babu.moger@amd.com,
        sandipan.das@amd.com, jmattson@google.com, thomas.lendacky@amd.com,
        nikunj@amd.com, ravi.bangoria@amd.com, eranian@google.com,
        irogers@google.com, kvm@vger.kernel.org, x86@kernel.org,
        linux-perf-users@vger.kernel.org,
        Manali Shukla <manali.shukla@amd.com>
References: <20230206060545.628502-1-manali.shukla@amd.com>
 <786f4d69-85c6-a581-1187-2fe8a49cf7e6@amd.com>
In-Reply-To: <786f4d69-85c6-a581-1187-2fe8a49cf7e6@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEZKQmtOUDJtbEVHKzBTQ2M3dmp1VjN3bUg5OFJZNHVzZjRCYXJTSk1YYjJC?=
 =?utf-8?B?RmJmV1czcll6MFV4MUxOQXd4cVdNR2hORFZGWCt0TE10UzVQeW9lTFJZN3M5?=
 =?utf-8?B?MlM4MDNuSE05Tmx0d043eUFvYlB6Vml5RlV1Y0VOUEJyTUhkd2VNaWFwY1lT?=
 =?utf-8?B?NlJJaCt4WmE0OXdESnJkaVNBMTlyMmg5WEFuYXBaNURkN2gzOHVWT05oQUo1?=
 =?utf-8?B?Mm4zYnRkdTFrVzUrYkVkakFBb0dVdEZqdHpYVjdOWkgydVpuTHdYaTNTYU04?=
 =?utf-8?B?WENpTGcrVlByek5IUjUrL2JZc3dtd081RDVDQUduK0xoKzRKc3ZpUWVVYXJu?=
 =?utf-8?B?MkpoVGhEN0hKVW05dDM0NWh2K3Mvei9wOEZyN05lbFpMa1o1dnFTcWZ4WlJL?=
 =?utf-8?B?bzFJMjZwR3I2c09JbjhVVnBSVXpGaU4ybzlNcVdrVE9RMjdoOUFQMW1BVUdC?=
 =?utf-8?B?eUF0UVUxOUZZYWpuVDhsTjRyMlU0QU1RSk9XRGN0M3FjSVNPYVpDMWpyWjdq?=
 =?utf-8?B?Z0JQSnZ1S2ZPYkV1VHRsZWUvU1B1TUxrRTMweDE5czBBRE1DdlFReHJoaksv?=
 =?utf-8?B?ek5VWGVQRTR0dWpkNVdVUVVvazczSE4rcVo5TXpHbExYUVJvNU02cUJKYUYy?=
 =?utf-8?B?VXpCNG1IZ09iV2x2UVBaejYwVHhCNjNZWFpKcTQyd05nNEtndXFmZ1FuMFRI?=
 =?utf-8?B?WTM0NHRORkFWMXpvY3BUZk1FRVhQcHowUk5MUW92SzcrK1YwN1c0N2hENDJi?=
 =?utf-8?B?Y2ZQQlhtMGNuK1djem5DQmFEd01UVThKZTkvdjJ2QStCci9rdzYyK0FBRjg5?=
 =?utf-8?B?TnJxekxRbU0wMlUvRTlDNVRkL29DUU5wbGNjN2NlbjRkYkQrd1lRM0djejRO?=
 =?utf-8?B?MHRzQTBPOS9xS1FwZ1RBd0lLdmVReDBjWHJjTUMxWHB6eGVwbHFDc2h3YjFW?=
 =?utf-8?B?YlBjaWFKN0VpUVRsWUFzM3ZiNEhWWmcrbDdjaFBvUmdyQmJnb3B2Ny9jR0Zt?=
 =?utf-8?B?djhMaXdaQXV0SmFNTnJCSGNhRVZ1L2hNc3RSelVpeUgzelpqd2Y1OEJSSXNq?=
 =?utf-8?B?d1UreDBMRmh5MUpWSlIrem9BZm1TRnV4ck5LTXMyQmFUaTFWMXkxbWJhakJN?=
 =?utf-8?B?VFg2UE0zNTJTWGE0VXViaDZUZHlJUkc3b2ZNS1I2ckFIV1BKNGsyd2d6U0l6?=
 =?utf-8?B?QmRoYU9UcWlPQmhsYjU4TWJtMG5MUHdvNklyN3poNUV2UWtyUTZKc2lCdFI5?=
 =?utf-8?B?eTMrV2FVUXNraTk1Vlo5ZWVVdVhCYlk2MHVRcTlGNkJqaGNjSVdBNnBUbU16?=
 =?utf-8?B?Z1M4U2YwdVJCZEt4UEhmTFZRQmp2RDIxTFllcmxEQU1JOFc2RDZzd1hXSUxI?=
 =?utf-8?B?UzhSdXRTeTVRcjBCTVFGWldJd3dRTmlIQkFiY1JyaEh2ZzlNc0VwQnhSZlZi?=
 =?utf-8?B?aS9kaS90cW1nSDgwaDB1dk42SEVoRnlMQUtVMWdRbkZzSGRTY3FnTS9oV1J2?=
 =?utf-8?B?R2JZUnRZVXVrQ21uTmdVTnBMRDBoUGkyZnUvbHVSTlBycTN3d0lVU1NVNGxi?=
 =?utf-8?B?U2szSDVNZDhjL0RyRUVHN2tZTE1KQkIxOXpsVnJkVWdXSXNYQVJ2K1hvZExz?=
 =?utf-8?B?MWNLeUp5VkhvRWpXbkFmOW1uVSthTG5RNXdMYWN4MUZQZVJzU3BJZGg4c2VP?=
 =?utf-8?B?TnJrVGhTbm1vZ1ZFVTRyWjEvMVRGTStQQm5pd05iNnRoQTg0ZVhxV1FkdkNy?=
 =?utf-8?B?bG1EVkpyVE15b2xyVFp0OGpOU0d4QkowS2RMd0NzYmlRVEhTWlFHRUxFaVN4?=
 =?utf-8?B?NHpGMlZZUWN0N1F6Y3JCR0VjcXhSbFF6TEJobm9ESktRbWhiSFkwenBzT3hq?=
 =?utf-8?B?c0NpMTFIWmM0TkdSaHBNeCtqbFFzaS9BaythSWtyTExzU2tLNkdiZTlNakJB?=
 =?utf-8?B?emtBZ1hVeGloZlZvaEhCRDBWanU2ZDBGcHFydGFDVEFPZWNic0dJTXcvNG1M?=
 =?utf-8?B?VE9nYzdOQ3ljcFpzWVhUZmdoNW1mL0lRS1lPNFJsbzRtbCt2QjJuMHBVVmlG?=
 =?utf-8?B?UHVtZU9EY3BSK3VjZTFjazZnYjEvMERIY1hZNmxPeVk2R2xnamtVNy81dDhN?=
 =?utf-8?Q?YQJawZkt1ewk9G+wOuCtCAuY/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 657e5f24-84c2-4b3d-54f4-08db2b64d459
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6214.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 06:07:06.7573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a450DiOEe6zhBuooRAprvxbtepjte65/U3ng+xWdh6Y3GivCv8prLenD44MSBnd+qKzggiJG3iBiiNSF2201AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7571
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/15/2023 10:33 AM, Manali Shukla wrote:
> On 2/6/2023 11:35 AM, Manali Shukla wrote:
>> Adds support for PreventHostIBS feature for SEV-ES and SNP guests.
>> Currently, the hypervisor is able to inspect instruction based samples
>> from the guest and gather execution information.  With enablement of
>> PreventHostIBS feature, SEV-ES and SNP guests may choose to disallow
>> use of instruction based sampling by the hypervisor in order to limit
>> the information gathered about their execution.  (More information in
>> Section 15.36.17 APM Volume 2)
>>
>> While implementing this feature, unknown NMIs were being seen. On
>> further investigation, a race was found effecting the IBS FETCH/OP
>> MSR.
>>
>> ENABLE bit and VALID bit for IBS_FETCH_CTL are contained in the same
>> MSR and same is the case with IBS_OP_CTL.
>>
>> Consider the following scenario:
>> - The IBS MSR which has ENABLE bit set and VALID bit clear is read.
>> - During the process of clearing the ENABLE bit and writing the IBS
>>   MSR to disable IBS, an IBS event can occur that sets the VALID bit.
>> - The write operation on IBS MSR can clear the newly set VALID bit.
>> - Since this situation is occurring in the CLGI/STGI window
>>   (PreventHostIBS window), the actual NMI is not taken.
>> - Once VMRUN is issued, it will exit with VMEXIT_NMI and as soon as
>>   STGI is executed, the pending NMI will trigger.
>> - The IBS NMI handler checks for the VALID bit to determine if the NMI
>>   is generated because of IBS.
>> - Since VALID bit is now clear, it doesn't recognize that an IBS event
>>   is occurred which in turn generates the dazed and confused unknown
>>   NMI messages.
>>
>> Per-cpu ibs_flags which indicates whether PreventHostIBS window is
>> active/inactive are added to avoid the above mentioned race.
>>
>> An active PreventHostIBS window is set before calling VMRUN and
>> cleared after STGI. PreventHostIBS window check is added to
>> perf_ibs_handle_irq(), to avoid unknown NMIs and treat them as handled
>> when window is active.
>>
>> There are 2 patches in this series.
>> 1) Add amd_prevent_hostibs_window() function to set per-cpu ibs_flags
>> based on an active/inactive PreventHostIBS window.
>> 2) Enable PreventHostIBS for SEV-ES and SNP guests.
>>
>> Testing done:
>> - Executed program symbols in guest are not captured in host when
>>   PreventHostIBS feature is enabled.
>> - Generated 1000+ NMIs using cpuid command, no unknown NMIs are seen
>>   after enablement of PreventHostIBS feature.
>>
>> Qemu commandline to enable PreventHostIBS on guest.
>>
>> qemu-system-x86_64 -enable-kvm -cpu EPYC-v4,+nohostibs \ ..
>>
>> Manali Shukla (2):
>>   perf/x86/amd: Add amd_prevent_hostibs_window() to set per-cpu
>>     ibs_flags
>>   KVM: SEV: PreventHostIBS enablement for SEV-ES and SNP guest
>>
>>  arch/x86/events/amd/ibs.c          | 64 ++++++++++++++++++++++++++++++
>>  arch/x86/include/asm/cpufeatures.h |  1 +
>>  arch/x86/include/asm/perf_event.h  | 20 ++++++++++
>>  arch/x86/kvm/svm/sev.c             | 10 +++++
>>  arch/x86/kvm/svm/svm.c             | 39 +++++++++++++++++-
>>  arch/x86/kvm/svm/svm.h             |  1 +
>>  6 files changed, 133 insertions(+), 2 deletions(-)
>>
> 
> A gentle reminder for the review.
> 
> -Manali

A gentle reminder for the review.

-Manali