Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230322085106.16629-1-mirsad.todorovac@alu.unizg.hr>
 <c93723aa-f01c-9f1e-c9c7-aa79f38390c1@infradead.org> <cb386732-7509-497d-8641-473ad853c9ed@alu.unizg.hr>
In-Reply-To: <cb386732-7509-497d-8641-473ad853c9ed@alu.unizg.hr>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 23 Mar 2023 15:24:21 +0900
Message-ID: <CAK7LNARAS7DEtpS2HMK=a7egwRdj-uD9JhxsOcKpfpstiiFLhQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
To:     Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Mark Brown <broonie@kernel.org>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 23, 2023 at 3:15=E2=80=AFAM Mirsad Goran Todorovac
<mirsad.todorovac@alu.unizg.hr> wrote:
>
> On 22. 03. 2023. 16:20, Randy Dunlap wrote:
> >
> >
> > On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
> >> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shel=
l
> >> syntax error in certain paths of the script execution.
> >>
> >
> > Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress wa=
rning on overrides")
> >
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> >
> > Thanks.
>
> Hi, Randy,
>
> I think this time thanks go to the Heavens, for preserving my physical in=
tegrity.
>
> Though I don't know of a bike with ABS.


Applied to linux-kbuild/fixes,
fixing another typo "Signed-of-by".


You do not need to spell it out by yourself.

"git commit -s" will insert the Signed-off-by tag.


> >> Cc: Mark Brown <broonie@kernel.org>
> >> Cc: Masahiro Yamada <masahiroy@kernel.org>
> >> Cc: linux-kbuild@vger.kernel.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> >> ---
> >>  scripts/kconfig/merge_config.sh | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_c=
onfig.sh
> >> index 32620de473ad..902eb429b9db 100755
> >> --- a/scripts/kconfig/merge_config.sh
> >> +++ b/scripts/kconfig/merge_config.sh
> >> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
> >>              NEW_VAL=3D$(grep -w $CFG $MERGE_FILE)
> >>              BUILTIN_FLAG=3Dfalse
> >>              if [ "$BUILTIN" =3D "true" ] && [ "${NEW_VAL#CONFIG_*=3D}=
" =3D "m" ] && [ "${PREV_VAL#CONFIG_*=3D}" =3D "y" ]; then
> >> -                    ${WARNOVVERIDE} Previous  value: $PREV_VAL
> >> +                    ${WARNOVERRIDE} Previous  value: $PREV_VAL
> >>                      ${WARNOVERRIDE} New value:       $NEW_VAL
> >>                      ${WARNOVERRIDE} -y passed, will not demote y to m
> >>                      ${WARNOVERRIDE}
>
> Best regards,
> Mirsad
>
> --
> Mirsad Goran Todorovac
> Sistem in=C5=BEenjer
> Grafi=C4=8Dki fakultet | Akademija likovnih umjetnosti
> Sveu=C4=8Dili=C5=A1te u Zagrebu
>
> System engineer
> Faculty of Graphic Arts | Academy of Fine Arts
> University of Zagreb, Republic of Croatia
> The European Union
>


--=20
Best Regards
Masahiro Yamada