Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Katakam, Harini" <harini.katakam@amd.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "claudiu.beznea@microchip.com" <claudiu.beznea@microchip.com>,
        "andrei.pistirica@microchip.com" <andrei.pistirica@microchip.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Simek, Michal" <michal.simek@amd.com>,
        "harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>
Subject: RE: [PATCH net-next v2 1/2] net: macb: Enable PTP unicast
Thread-Topic: [PATCH net-next v2 1/2] net: macb: Enable PTP unicast
Thread-Index: AQHZW/JLtp5le6APU0K50iEquT1KP68H13eAgAAWqtA=
Date:   Thu, 23 Mar 2023 07:01:37 +0000
Message-ID: <BYAPR12MB4773239308DD06E4B80E14BC9E879@BYAPR12MB4773.namprd12.prod.outlook.com>
References: <20230321124005.7014-1-harini.katakam@amd.com>
        <20230321124005.7014-2-harini.katakam@amd.com>
 <20230322222403.39191060@kernel.org>
In-Reply-To: <20230322222403.39191060@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bqqBN4lXhhhrk6jQDt/7GLMCbAG77CozjwrU5Mwv2CYk25kBBvgkefrsW329?=
 =?us-ascii?Q?7RlVTItVWHacQ4fo8FsuuwRFyUPLAUY7fBynJsRcwTw5nYLOUlCNJcxqEpRd?=
 =?us-ascii?Q?bOY13YQ2yjxYClWTIrp87jnGhO96DWAyq4kdZsHK4m2+xR1xztUO9uif5wID?=
 =?us-ascii?Q?o9/KaoMv+ZvLQKVkvZsEIyh4QaZ1TdV25uwAXzrm5ViFRnwPTuAhPXlVzA8u?=
 =?us-ascii?Q?F0hmgDu3sr6nggWyTcbh/yjpydic3J8M6+Pr9rSQV1hkOqaZltxyiMks98pj?=
 =?us-ascii?Q?7+j/z0+d3VTjr2txf2djLOmrfsHStEr050an8zz0rDNEoNqpnrBAJZu8+9zC?=
 =?us-ascii?Q?JdyuwdpYceFJIUFu2ZexTz3zrB+sYOfHQTVBF3EmTpe0fLBnZs/1R6CtcL6c?=
 =?us-ascii?Q?vHqO2hocFQpMSH9IWHU0vD5Gdo7FTttaVAGFtrmQird5x4KMloox9Lm4370v?=
 =?us-ascii?Q?XucF8KSm7ozzmy4C3pCvF9vXkoGG+qIBsw7daQ/O+g7s3Alf+8SUV6v5C/qY?=
 =?us-ascii?Q?+hluaoRRAiP86ydcvaiphZWzbucmmTPNVIlRyDqEXed20FQ7ojcJ1SPrjR8H?=
 =?us-ascii?Q?gx5rpnFolk96qbsqVwoCrXvJsux6SWiDjwDjSRrtsnpZ/0O6dfwFeoBzN6vs?=
 =?us-ascii?Q?uvjT7GfgH3BzXq0NUbmYQuii334DavDuVfUxT96W31zUOJ1QHeOF9V4vIdd+?=
 =?us-ascii?Q?aWxH2xnpHuVdXIB+yVL7+gEH1Q7F+wKr5IMWLlDWNUAUzmqBjz4vGS/AjHMO?=
 =?us-ascii?Q?hkgsS0jYa2ecUYIBD3vK1QDDFMDSdXqh0qkOKqxNV5E1RdPDl4POVrsPI2lG?=
 =?us-ascii?Q?1cl9oqQVXGCq/L4BYmGgXDXvDRUUyu22RtBdj/NZCs1Mg2IBRL+ajPG2gNbu?=
 =?us-ascii?Q?RnE5MokrD4bh0wrot/bkt0VViof3SR5vrPu+uNixmLlLI/B7UTj+4X8bcZNY?=
 =?us-ascii?Q?qDbhd88e2Aum9CaopG6PFFppUTwXVwnkyPupHMc5mb0rBcvQgtmKlSNsWQv5?=
 =?us-ascii?Q?FXyR2qMvlx0mHVJPSTAUBV7FArRJ39TYVNRZj+9AljoYNWFahRfkVdQmp4H/?=
 =?us-ascii?Q?ed2kzmyL3G1i1g0lhV8rQQyJDke8/ImuaOdUm5rp4evBsJ9zb4g+vRbBFZ0G?=
 =?us-ascii?Q?9dR4KE84uRtRtrMo8b8zILLOrccqiTHGiMVd001GcafhjsyWCxED3rtH5z31?=
 =?us-ascii?Q?9ko87UMfZOHsfYlsrF8DOy3l3uEyVJ1rf0z2gkXpCaafWSwCyy3UukboZhEU?=
 =?us-ascii?Q?MIUggyrwQjxYDjb15RetsalAROfXv4nmBO2255mKwt/udO0GovwjbDsLhhXe?=
 =?us-ascii?Q?lIo7S1epuwCiiPQRx9uTDvKJtrEEnaKUqxdTDM5kVPC22T23Cwfq/+qtnRl0?=
 =?us-ascii?Q?Gye9nt+QWqGCmJ54oAabirWOmcIrHsO/IgotUfvaybPYLvreIQAp4oL2snLc?=
 =?us-ascii?Q?hJ00rGCZ7CwBP9xEhUc5ZJmmsUIElNoAuZaY8lPVekmR3vzcXcQGmcQcgorf?=
 =?us-ascii?Q?NHuRv/2gfEXi1SEdEnyfMNrCuD/a8Zeo+8MD4YmMcriYGK12Q1jLtYpOlK8J?=
 =?us-ascii?Q?rHB6R+E8T74Hg04hkhQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4773.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89a27b34-5ad5-4693-0487-08db2b6c7213
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2023 07:01:37.3212
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yxAD6+LUlL2zRO+zuDkaRy7tMJZBWr8B/WQ6kbXktwteJbSlo28agx1dQI46/b5u
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6970
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, March 23, 2023 10:54 AM
> To: Katakam, Harini <harini.katakam@amd.com>
> Cc: nicolas.ferre@microchip.com; davem@davemloft.net;
> richardcochran@gmail.com; claudiu.beznea@microchip.com;
> andrei.pistirica@microchip.com; edumazet@google.com;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> Simek, Michal <michal.simek@amd.com>; harinikatakamlinux@gmail.com
> Subject: Re: [PATCH net-next v2 1/2] net: macb: Enable PTP unicast
>=20
> On Tue, 21 Mar 2023 18:10:04 +0530 Harini Katakam wrote:
> > +#ifdef CONFIG_MACB_USE_HWSTAMP
> > +	if (gem_has_ptp(bp)) {
> > +		gem_writel(bp, RXPTPUNI, bottom);
> > +		gem_writel(bp, TXPTPUNI, bottom);
> > +	}
> > +#endif
>=20
> You can use the same IS_ENABLED() trick here as you used in the if ()
> below, to avoid the direct preprocessor use. In fact why not just
> add the IS_ENABLED(CONFIG_MACB_USE_HWSTAMP) to the condition inside
> gem_has_ptp() ? It looks like all callers want that extra check.

Thanks for the suggestion.
I believe gem_has_ptp was originally defined for checking device
capability (Atmel/SiFive/AMD) and CONFIG_MACB_USE_HWSTAMP for the
kernel selection but I agree that there is currently no usecase for a=20
scenario where gem_has_ptp is TRUE and MACB_USE_HWSTAMP is false. If
hear are no objections, I'll include this check inside gem_has_ptp and send=
 v3.

Regards,
Harini