Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e9967b4f-ec36-f1b0-859b-7f3c7350f7ac@alu.unizg.hr>
Date:   Thu, 23 Mar 2023 08:17:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Mark Brown <broonie@kernel.org>, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230322085106.16629-1-mirsad.todorovac@alu.unizg.hr>
 <c93723aa-f01c-9f1e-c9c7-aa79f38390c1@infradead.org>
 <cb386732-7509-497d-8641-473ad853c9ed@alu.unizg.hr>
 <CAK7LNARAS7DEtpS2HMK=a7egwRdj-uD9JhxsOcKpfpstiiFLhQ@mail.gmail.com>
Content-Language: en-US
From:   Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
In-Reply-To: <CAK7LNARAS7DEtpS2HMK=a7egwRdj-uD9JhxsOcKpfpstiiFLhQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 23.3.2023. 7:24, Masahiro Yamada wrote:
> On Thu, Mar 23, 2023 at 3:15 AM Mirsad Goran Todorovac
> <mirsad.todorovac@alu.unizg.hr> wrote:
>>
>> On 22. 03. 2023. 16:20, Randy Dunlap wrote:
>>>
>>> On 3/22/23 01:51, Mirsad Goran Todorovac wrote:
>>>> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
>>>> syntax error in certain paths of the script execution.
>>>>
>>>
>>> Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides")
>>>
>>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> Thanks.
>>
>> Hi, Randy,
>>
>> I think this time thanks go to the Heavens, for preserving my physical integrity.
>>
>> Though I don't know of a bike with ABS.

> Applied to linux-kbuild/fixes,
> fixing another typo "Signed-of-by".
> 
> You do not need to spell it out by yourself.
> 
> "git commit -s" will insert the Signed-off-by tag.

Sorry to have wasted your time and effort. A typo fixing typo.

It is visually hard to detect once it's done. :(

I'm grateful for your quality control.

Best regards,
Mirsad

>>>> Cc: Mark Brown <broonie@kernel.org>
>>>> Cc: Masahiro Yamada <masahiroy@kernel.org>
>>>> Cc: linux-kbuild@vger.kernel.org
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
>>>> ---
>>>>   scripts/kconfig/merge_config.sh | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
>>>> index 32620de473ad..902eb429b9db 100755
>>>> --- a/scripts/kconfig/merge_config.sh
>>>> +++ b/scripts/kconfig/merge_config.sh
>>>> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do
>>>>               NEW_VAL=$(grep -w $CFG $MERGE_FILE)
>>>>               BUILTIN_FLAG=false
>>>>               if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then
>>>> -                    ${WARNOVVERIDE} Previous  value: $PREV_VAL
>>>> +                    ${WARNOVERRIDE} Previous  value: $PREV_VAL
>>>>                       ${WARNOVERRIDE} New value:       $NEW_VAL
>>>>                       ${WARNOVERRIDE} -y passed, will not demote y to m
>>>>                       ${WARNOVERRIDE}

-- 
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union

Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu