Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7217980rwl; Thu, 23 Mar 2023 00:42:43 -0700 (PDT) X-Google-Smtp-Source: AK7set+8o7ZXbVW4IwCe05hfNA7OVKUTizcrZIiUqwaHbZE8NJ75buwczceIWkRzO33EYL9Dpl1u X-Received: by 2002:a17:906:4f82:b0:931:8ad4:a586 with SMTP id o2-20020a1709064f8200b009318ad4a586mr10023595eju.30.1679557363779; Thu, 23 Mar 2023 00:42:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679557363; cv=none; d=google.com; s=arc-20160816; b=K6fJnWXUbp+d3WiOdgvejT9pbdOE0rEiOqsvwCV7HU/V332UhoQ4+nft3fns7pTaRi Xr7MKZdQoep3HyU/TR8PT5cvRZ9LfkxXsWvKmMolYiaS/Ggx3XIVPpuen1hDCSd7sqX4 y+bBlABzKg9gZvF/tY/Yt/BlDcTCL3wSD7OWVT/Rgv5j6ivtHbWrzQm1w74dOSH1VD9Q XFTUGsAOVebka19+IytdAx37ESCzcXc46PFuFCJmRUCbtA1zDxghLF3TYz1ok8Ku/hIN lJeyXgn4Ul+R8/xo7VoathCsOwtlfbglO0vWzMSf45tmn1hxtPzg6NNVWopbI4oI0t7m bYsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=RZCDzRnLqysWpssOJFzBPP+Ah8SGkrKkmxkaX60oGac=; b=Hw008u1ZmKUCLfkwXURFrQfDRKI78aDPfcljfrNt193eHhqJm+Kq2U5ctSD2/WhlSq 2ZxYT+8Q0QVl23ThuoLvY1Zec0UW9DNEcky1hQPsfZZ7fKTNQIDvRoyt7e5egaq4h1+M TPgrDb45DWeylOMVQqYweJAikdxmi625C4roMcx4iGj1Zt76+mLFC6j6+TlMEJDHlceg X7zs287P+5z0oYiaL3FhQPN+ooYGk9nrrfTWkbpHJn/L5Lk8OsHroJNmVLSLPTxklPw/ KQE7QDumb4CYgkImDqaOi2LlR2oS/X+4+P4HI+LCPsW2UKdwaS7qAfHH8QhDWQcb8cWp vo9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=oNU9PrUn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a170906314400b00926b5b99483si16840986eje.111.2023.03.23.00.42.19; Thu, 23 Mar 2023 00:42:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=oNU9PrUn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231344AbjCWH2t (ORCPT + 99 others); Thu, 23 Mar 2023 03:28:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231229AbjCWH2b (ORCPT ); Thu, 23 Mar 2023 03:28:31 -0400 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06B9E35BC; Thu, 23 Mar 2023 00:28:04 -0700 (PDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 973C0240003; Thu, 23 Mar 2023 07:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1679556482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RZCDzRnLqysWpssOJFzBPP+Ah8SGkrKkmxkaX60oGac=; b=oNU9PrUnB5kWjgXEat4iAei6Hhs7l5YApzPKFrCVHYbMsCgknox/p5alDoKe8GpDSCPeY9 QmXMkQbTx6T/wl2Y/618U/WhtERx3X25qKs0hpsHNnJL9Ij/lhylM3AGrPbZyVSzpjikZS uq/50PrtdkwzA7Np5OwztD7s6wQrkbASkn2PlWmSwixrkQPQqr9uC2JzkgEacLMWgI8Ks5 Lg9lV9RYqFXSswWYgg/oaR40vNqfMFwAVSZdt+q8att55/qeiuLfsLJMYTFfsLVo/FkNnR 48rLE+1X06BTBhdAcupsrdrrYyiQs1vv5aHDY01rX8eAfuNhd/G7nkGmntFJeQ== Date: Thu, 23 Mar 2023 08:27:58 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v3 4/6] dt-bindings: sound: Add support for the Lantiq PEF2256 codec Message-ID: <20230323082758.5e4385ff@bootlin.com> In-Reply-To: References: <20230322134654.219957-1-herve.codina@bootlin.com> <20230322134654.219957-5-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof On Wed, 22 Mar 2023 22:59:37 +0100 Krzysztof Kozlowski wrote: > On 22/03/2023 14:46, Herve Codina wrote: > > The Lantiq PEF2256 is a framer and line interface component designed to > > fulfill all required interfacing between an analog E1/T1/J1 line and the > > digital PCM system highway/H.100 bus. > > > > The codec support allows to use some of the PCM system highway > > time-slots as audio channels to transport audio data over the E1/T1/J1 > > lines. > > > > Signed-off-by: Herve Codina > > --- > > .../bindings/sound/lantiq,pef2256-codec.yaml | 54 +++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml b/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > > new file mode 100644 > > index 000000000000..da35b70cda99 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/lantiq,pef2256-codec.yaml > > @@ -0,0 +1,54 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/lantiq,pef2256-codec.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Lantiq PEF2256 codec > > + > > +maintainers: > > + - Herve Codina > > + > > +description: | > > + Codec support for PEF2256. > > + > > + The Lantiq PEF2256, also known as Infineon PEF2256 or FALC56, is a framer and > > + line interface component designed to fulfill all required interfacing between > > + an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. > > + > > + The codec support allows to use some of the PCM system highway time-slots as > > + audio channels to transport audio data over the E1/T1/J1 lines. > > + > > + The time-slots used by the codec must be set and so, the properties > > + 'dai-tdm-slot-num', 'dai-tdm-slot-width', 'dai-tdm-slot-tx-mask' and > > + 'dai-tdm-slot-rx-mask' must be present in the ALSA sound card node for > > + sub-nodes that involve the codec. The codec uses 8bit time-slots. > > + 'dai-tdm-tdm-slot-with' must be set to 8. > > + The tx and rx masks define the PEF2256 time-slots assigned to the codec. > > + > > + The PEF2256 codec node should be a child of a PEF2256 node. > > + Refer to the bindings described in > > + Documentation/devicetree/bindings/mfd/lantiq,pef2256.yaml > > + > > +allOf: > > + - $ref: dai-common.yaml# > > + > > +properties: > > + compatible: > > + const: lantiq,pef2256-codec > > + > > + '#sound-dai-cells': > > + const: 0 > > You do not have here any resources, so the entire binding can be dropped > and merged into the parent. > > Best regards, > Krzysztof > Ok, Do you expect all these properties (except compatible) merged at the parent level or may I keep a child node with these properties including the compatible property (ie. yaml file merge). Regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com