Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Schspa Shi <schspa@gmail.com>, longman@redhat.com,
        swboyd@chromium.org, linux@roeck-us.net, wuchi.zero@gmail.com
Cc:     linux-kernel@vger.kernel.org, Schspa Shi <schspa@gmail.com>
Subject: Re: [PATCH 2/2] debugobject: add unit test for static debug object
In-Reply-To: <m2sfdwnoi8.fsf@gmail.com>
References: <20230303161906.831686-1-schspa@gmail.com>
 <20230303161906.831686-2-schspa@gmail.com> <m2sfdwnoi8.fsf@gmail.com>
Date:   Thu, 23 Mar 2023 08:53:19 +0100
Message-ID: <87h6ub9a4w.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Thu, Mar 23 2023 at 11:16, Schspa Shi wrote:
> Schspa Shi <schspa@gmail.com> writes:
>>  MAINTAINERS                    |   5 ++
>>  lib/Kconfig.debug              |  14 ++++
>>  lib/Makefile                   |   2 +
>>  lib/test_static_debug_object.c | 125 +++++++++++++++++++++++++++++++++
>>  4 files changed, 146 insertions(+)
>>  create mode 100644 lib/test_static_debug_object.c
>
> What do you think about this test case? Should we need it ? There are
> some platform compatibility issues here that need a little optimization.

What does it buy over the existing self test. Nothing AFACIT aside of
extra code.

Thanks,

        tglx