Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 09:31:54 +0100
From:   Herve Codina <herve.codina@bootlin.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 2/6] mfd: Add support for the Lantiq PEF2256 framer
Message-ID: <20230323093154.5852f81b@bootlin.com>
In-Reply-To: <551fe9b4-4c99-74b8-af44-9f431c488af8@linaro.org>
References: <20230322134654.219957-1-herve.codina@bootlin.com>
        <20230322134654.219957-3-herve.codina@bootlin.com>
        <551fe9b4-4c99-74b8-af44-9f431c488af8@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 23 Mar 2023 08:30:39 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 22/03/2023 14:46, Herve Codina wrote:
> > The Lantiq PEF2256 is a framer and line interface component designed to
> > fulfill all required interfacing between an analog E1/T1/J1 line and the
> > digital PCM system highway/H.100 bus.
> > 
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>  
> 
> 
> > +static const struct of_device_id pef2256_id_table[] = {
> > +	{ .compatible = "lantiq,pef2256" },
> > +	{} /* sentinel */
> > +};
> > +MODULE_DEVICE_TABLE(of, pef2256_id_table);
> > +
> > +static struct platform_driver pef2256_driver = {
> > +	.driver = {
> > +		.name = "lantiq-pef2256",
> > +		.of_match_table = of_match_ptr(pef2256_id_table),  
> 
> Drop of_match_ptr. This will case warnings with W=1 and !OF.
> 
> Best regards,
> Krzysztof
> 

Acked. Will be dropped in v4.

Thanks.
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com