Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 09:34:51 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Dhruva Gole <d-gole@ti.com>
Cc:     Vibhore Vardhan <vibhore@ti.com>, linux-rtc@vger.kernel.org,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH] rtc: k3: handle errors while enabling wake irq
Message-ID: <20230323083451a4171c6b@mail.local>
References: <20230323081942.951542-1-d-gole@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230323081942.951542-1-d-gole@ti.com>
Precedence: bulk

On 23/03/2023 13:49:42+0530, Dhruva Gole wrote:
> Due to the potential failure of enable_irq_wake(), it would be better to
> check it and return error if it fails.
> 
> Fixes: b09d633575e5 ("rtc: Introduce ti-k3-rtc")
> Cc: Nishanth Menon <nm@ti.com>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
>  drivers/rtc/rtc-ti-k3.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-ti-k3.c b/drivers/rtc/rtc-ti-k3.c
> index ba23163cc042..ef9d7e1cf92e 100644
> --- a/drivers/rtc/rtc-ti-k3.c
> +++ b/drivers/rtc/rtc-ti-k3.c
> @@ -630,9 +630,18 @@ MODULE_DEVICE_TABLE(of, ti_k3_rtc_of_match_table);
>  static int __maybe_unused ti_k3_rtc_suspend(struct device *dev)
>  {
>  	struct ti_k3_rtc *priv = dev_get_drvdata(dev);
> +	int error;

This variable is not necessary.

>  
>  	if (device_may_wakeup(dev))
> -		enable_irq_wake(priv->irq);
> +		error = enable_irq_wake(priv->irq);
> +
> +	if (error) {
> +		dev_err(dev,
> +			"failed to enable irq wake on IRQ %d: %d\n",
> +			priv->irq, error);

Please remove this message, this is too verbose and there is no action
for the user apart from trying to go to suspend again.

> +		return error;
> +	}
> +
>  	return 0;
>  }
>  
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com