Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230303161906.831686-1-schspa@gmail.com>
 <20230303161906.831686-2-schspa@gmail.com> <m2sfdwnoi8.fsf@gmail.com>
 <87h6ub9a4w.ffs@tglx>
User-agent: mu4e 1.8.10; emacs 29.0.60
From:   Schspa Shi <schspa@gmail.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     longman@redhat.com, swboyd@chromium.org, linux@roeck-us.net,
        wuchi.zero@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] debugobject: add unit test for static debug object
Date:   Thu, 23 Mar 2023 16:44:21 +0800
In-reply-to: <87h6ub9a4w.ffs@tglx>
Message-ID: <m2a603onvq.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Thomas Gleixner <tglx@linutronix.de> writes:

> On Thu, Mar 23 2023 at 11:16, Schspa Shi wrote:
>> Schspa Shi <schspa@gmail.com> writes:
>>>  MAINTAINERS                    |   5 ++
>>>  lib/Kconfig.debug              |  14 ++++
>>>  lib/Makefile                   |   2 +
>>>  lib/test_static_debug_object.c | 125 +++++++++++++++++++++++++++++++++
>>>  4 files changed, 146 insertions(+)
>>>  create mode 100644 lib/test_static_debug_object.c
>>
>> What do you think about this test case? Should we need it ? There are
>> some platform compatibility issues here that need a little optimization.
>
> What does it buy over the existing self test. Nothing AFACIT aside of
> extra code.
>

It checks the race of the is_static_object() call in the previous
BUG. This test can used to make sure the new fix patch works. The
existing self test have no ability to check this.

> Thanks,
>
>         tglx


-- 
BRs
Schspa Shi