Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7279513rwl; Thu, 23 Mar 2023 01:54:32 -0700 (PDT) X-Google-Smtp-Source: AK7set/TVt+noQCsbzXCAoGObsquvi1HxViWW+ut3TKcdMJRlBBKvLirzLxbVs2p7Tcm3oj9vM4L X-Received: by 2002:aa7:c6c3:0:b0:4fe:1b62:4741 with SMTP id b3-20020aa7c6c3000000b004fe1b624741mr9389012eds.28.1679561672355; Thu, 23 Mar 2023 01:54:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679561672; cv=none; d=google.com; s=arc-20160816; b=BnT31BoCvGhIEXY3513/vMxmHHc6J9rNc3bP70y1vfvNnCwgNMJTJOSohLDUgf2pfY N3mfxVhOuz026KZdNElGZvZlw0jTZB71Hx+I+QQrF4bcustSDx19GNbf5aK3TVOkDQO+ jcad9czfS7YrF8nSKDWySK5oLYHAxiyBhH1TYOBDZfOZ4h6kVcW/zK/KHu5JiynJJbLr VQ1/gpYYr61Ruc11HF9WMVqDH8doy24UREwVqLGGS9DjDvS4pHpurZkkianOc2DZFmHv Xhu2vVjQE/tkkgxJ3Up+E3Njpa46MnHHLbyx1jcQQPIScrn2KRgCbtnkxUHNumaIpF3x GKoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from; bh=RFEwHnQBQ6ku4YI96EErhR9wnqc6u+FLSGtrkbCEh8E=; b=q+lVzuzgE1xsEBsuoUQKU+08R2Q95I29s9R+aF2HAMRY6h6J7JV0V9lyMKyMbeNVlb xJB5ItUxo4x2538G//DfC6CLqKPTO1frYQm+aPIWFz0/ViZS249p3kzA3SpIA3aClERM bOKthKcVPJ/dQcGATp2EKCXYMKbNWzeJOe0wB0xLSSl1hw20J9+hMIc90L/CTgcKkkek +BDpDurj/GR3dhkUwNo4OR0TjXexIwQNrcoBH5MVhO48qoY1RxElvWbc1fY7lbMcirpL YGfC0+ZqEJFJMmkbP1MuiHCBIk9TsRFAtzwYFK2JUz539wzVwKL6CFEA8qJUNP86JLO2 v7dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n16-20020aa7c690000000b00501bf4b10a4si10716106edq.539.2023.03.23.01.54.07; Thu, 23 Mar 2023 01:54:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229526AbjCWIsK (ORCPT + 99 others); Thu, 23 Mar 2023 04:48:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbjCWIsI (ORCPT ); Thu, 23 Mar 2023 04:48:08 -0400 X-Greylist: delayed 513 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 23 Mar 2023 01:48:07 PDT Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A5741043D for ; Thu, 23 Mar 2023 01:48:06 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4PhzKc5pn4z1sB77; Thu, 23 Mar 2023 09:39:32 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4PhzKc4GBcz1qqlY; Thu, 23 Mar 2023 09:39:32 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ClzVfOsz3AGx; Thu, 23 Mar 2023 09:39:31 +0100 (CET) X-Auth-Info: Y+UMJ9JyeLs0U36Yyz5qoPqGiW5wfKK6b6F/ooNgPcoQtneAtR0Pa/OZWp7xmyaq Received: from hawking (unknown [81.95.8.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 23 Mar 2023 09:39:31 +0100 (CET) From: Andreas Schwab To: Finn Thain Cc: Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nubus: Don't list card resources by default References: <5b7c473247d66776343d82a55b9815195b1b11fb.1679551394.git.fthain@linux-m68k.org> X-Yow: I am a jelly donut. I am a jelly donut. Date: Thu, 23 Mar 2023 09:39:31 +0100 In-Reply-To: <5b7c473247d66776343d82a55b9815195b1b11fb.1679551394.git.fthain@linux-m68k.org> (Finn Thain's message of "Thu, 23 Mar 2023 17:03:14 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mär 23 2023, Finn Thain wrote: > Checkpatch says "externs should be avoided in .c files" and if this one > appeared twice I would agree. But as it only appears once, I can't see > any advantage to putting it in a new .h file instead of the .c file... Anything wrong with declaring it in ? -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."