Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 10:50:17 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        "christian.koenig@amd.com" <christian.koenig@amd.com>,
        "digetx@gmail.com" <digetx@gmail.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "sumit.semwal@linaro.org" <sumit.semwal@linaro.org>,
        "wsa@kernel.org" <wsa@kernel.org>
Subject: Re: [PATCH v3] i2c: tegra: Share same DMA channel for RX and TX
Message-ID: <ZBwg2Rnc6d5EQ3pu@orome>
References: <20230322102413.52886-1-akhilrajeev@nvidia.com>
 <db870e74-9d97-740a-9829-5fafc0bb0559@nvidia.com>
 <SJ1PR12MB6339FC0B9BB57D1D2300D46CC0869@SJ1PR12MB6339.namprd12.prod.outlook.com>
 <b9235dfc-10dc-1ed0-1510-fd98902491e3@nvidia.com>
 <SJ1PR12MB63395F16F399E67733EED69BC0879@SJ1PR12MB6339.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="/U2W7SI2pG14y3lP"
Content-Disposition: inline
In-Reply-To: <SJ1PR12MB63395F16F399E67733EED69BC0879@SJ1PR12MB6339.namprd12.prod.outlook.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk


--/U2W7SI2pG14y3lP
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 23, 2023 at 09:26:00AM +0000, Akhil R wrote:
> > On 22/03/2023 12:00, Akhil R wrote:
> > >> On 22/03/2023 10:24, Akhil R wrote:
> > >>> Allocate only one DMA channel for I2C and share it for both TX and =
RX
> > >>> instead of using two different DMA hardware channels with the same
> > >>> slave ID. Since I2C supports only half duplex, there is no impact on
> > >>> perf with this.
> > >>>
> > >>> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> > >>
> > >> Just to confirm. This impacts all Tegra devices from Tegra20 to the
> > >> latest. Does this work for all Tegra and the different DMA controlle=
rs
> > >> that they have?
> > >>
> > > Yes, It should. I could see in the APB DMA driver that the same chann=
el
> > > could be used for TX and RX and the direction is configured only duri=
ng
> > > dma_prep_*() calls.
> > > I did not test it on a Tegra with APB DMA, but since it works very si=
milar
> > > to GPC DMA there should not be any impact.
> >=20
> >=20
> > OK. BTW, this does not apply cleanly on top of -next. It appears that
> > this is based on top "i2c: tegra: Fix PEC support for SMBUS block read"
> > and that one needs to be applied first. This can be avoided if you send
> > as a series.
> >=20
> Oh. Okay. I used 'git am --3way' when I tried, and the conflict went unno=
ticed.
> Shall I send a new version on top of -next?
> The two patches were added in different contexts and that=E2=80=99s why I=
 did not
> combine them as a series.

It's usually best to combine them in a series even if they are in
slightly different contexts. This is especially true if they cause
conflicts between one another. If you send them as a series, you can
resolve the conflicts yourself (you may not even have conflicts locally
if you create the patches in the same branch), but if you send them
separately the maintainer will end up having to resolve the conflicts
(or apply in the right order).

It's best if you resolve the conflicts because you know better than the
maintainer (usually) or specify any dependencies to make it easier for
the maintainer to do the right thing.

But again, in the vast majority of cases, it's best to combine all the
work on one driver in a single series before sending out.

Thierry

--/U2W7SI2pG14y3lP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQcINYACgkQ3SOs138+
s6Hb7A//RY4yqQJDFVPWvq6X0vDHSAkMuIKB7cNKAOOdg9CnwUHXTj/CTqFFYAt2
Ifv+bhqJq0f+/jUTGpicyLO+Sb/OBIBpfIeg3opqG7gA/xt2BXkqSPuALZk1bkua
lv0IQ8GEgmynhsSUeVYbdorzpmbBND4emJE/v/IBd//9EWZdqb1myM+zuNz2ixLW
ifEkDDR9WkrSBWCHCXByC8pFcLtnLV4XUVEFCBUmFQsJfTcIcQrlzTJ1kzJZv9NU
T8skz0Pm3Oai4cBWuDtFsgZVnsmn687RppTnB4vDPzG4ttQe0dxnhbwUZfuHANVY
zgasJjYNoh1xT/FMiWHCXRIjyAt129F+T2cnC+Cews5kCuIM04gn20aYqNa/6BSX
1kEwbgWEebIUxJAI/4/MmbMdDtjiFjYeN0diBCRwNILciK9mHqyr96Rzn7y+7Z/C
wTRNEs1WBkCDGDy1Sv9IYx9VArdfz8YP0woru8JTZNdR66/hQO926e3nkHWuNwqX
WD4UMi/9OvTEapsiP891ZL/E8I0NUFAhI1RigyuhCgWHGSIYBOPpKHVxVvzDaoAA
AVaqs0jEqDFOm8ZbRM3VcbgBdCyoFLJhGqavhxdvA0i6fcvPYZ7CUfINYYJW0e5D
J0oIxWt/AceiOnTqmKI5GjjN5Kee4ys/F4SLfq4/5+g8qMrIO/k=
=vz4Y
-----END PGP SIGNATURE-----

--/U2W7SI2pG14y3lP--