Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e251e5c3-152e-3ebe-aa9f-c5cfa36cfc3f@oracle.com>
Date:   Thu, 23 Mar 2023 10:07:23 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [RFC PATCH v3 1/5] ufs: mcq: Add supporting functions for mcq
 abort
To:     "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
        quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
        bvanassche@acm.org, mani@kernel.org, stanley.chu@mediatek.com,
        adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        Eric Biggers <ebiggers@google.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
References: <cover.1679564391.git.quic_nguyenb@quicinc.com>
 <90b7b370269674fd7c0f505b59e0993c5b95a316.1679564391.git.quic_nguyenb@quicinc.com>
Content-Language: en-US
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <90b7b370269674fd7c0f505b59e0993c5b95a316.1679564391.git.quic_nguyenb@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVlYbDZyZklxK0s0ZmNCZVRYV0xkcDQ0KzVqNnFSUTBnemcvWXdqbC9Db1Fu?=
 =?utf-8?B?YngwdzREM0J5eXlyU3ozQ0p5WXZwbmhLdmpyb0hsOUZkRFpzWm9XWDdTK2Z4?=
 =?utf-8?B?eXJtS0lWcjk3cFpESEUrS01US2FLZC9UbWp3MDkyUWdWNEJyMlVWOXRONW5H?=
 =?utf-8?B?dkpZWnhLVjBET3FTL0kyM2grc3d2Q2dnR2dUQVZSNTVaQjR5ZWZ0QU1QNVpJ?=
 =?utf-8?B?WHh6L3paOXlJeXkwcGpScTY4U2t3Z1F1Mm5CSk9sUnRuanZXcHNBSVlUSVVx?=
 =?utf-8?B?K3lYNHJJcXc5Y0IrazhjS0RMRnJNS3FjaXAwc1dOa0ZiZjRIc0QvSmZOd1Y1?=
 =?utf-8?B?bldZclg0L3JjbTZXNWREM041MTJGZmFtTGoxTVpwYWVTWit6WXE0d0cvYm00?=
 =?utf-8?B?dUptQXl6UHRWQnFIdTRzK25lVEpwWlpqUlpsUFV3S3hIMWtiYW9kdU93bmM0?=
 =?utf-8?B?a21HeERWYWxzclgwbExHMmtFMnloZkZKcjFYYnhhek9GWkdFd2E3akxGUHRt?=
 =?utf-8?B?LzdLZTNDQnlaSnBTenpza0VwckZvOXUxdDlDdDA2UGlMSExUem4rRDB2a21J?=
 =?utf-8?B?dGs0T3R1SnIwUjhZanZBU3hOMU5EK29XWEtnb3dSeVZiYWFETVZoaUd2T1Nk?=
 =?utf-8?B?S25NYWVTeUtkSGJYQm1GT3h2cVdZeklZZDFNTFpJSTl3R2VFZkFiTHNHSHhV?=
 =?utf-8?B?UlhmZzlMNSs3ZFBDOGp2SkNWQzQ1dHlqVUtHb3JneUViWG9DZnZkSVJsbmhT?=
 =?utf-8?B?SlNFRGg0Q0gvMVgrQ3M2RWNOV3lGakN5WkRFTVBqNGtmMnhobTVpV0lTQkdG?=
 =?utf-8?B?VHFSTnJWenFsN2VFSDNyLy9DQnA0U3AwM1JVbUVaUFFtMEI3ejBTempDSlAr?=
 =?utf-8?B?TzlZKzRJV0xBdXc5RzFBSUhGNVZnYU9iUTdOM2tITllwUHN3eldac2lNNnM0?=
 =?utf-8?B?NHVtSTBYbHd5UFhDVy8wVnIvdU1FL2xsdSs1cjE2YWdEZVVsN3l4TW9vZFY3?=
 =?utf-8?B?ZUgxQVVoK0ZPZDZBN0pjQ2FoZlNYMU5tRThHUUljQk5XZW80c2puRmFId3dQ?=
 =?utf-8?B?V0wrcjNFNytQNzFsOUV3QUVDRkRSdTg0NVNoY3N0VzZlcHVYbE1jV3Vadnll?=
 =?utf-8?B?LzJqNCtxQndNQlM1d0FzQ2lDZWFiMkVNVDBFbTNUM1ZOT05FY0szaFJqU0xF?=
 =?utf-8?B?YkNmSkwxaXVNdkxEMDZXQnNMZG9aSFVrVHgrQzAzMWl1dWp0RnVGRXRJdldj?=
 =?utf-8?B?dk1ZOTJpd1k0RGxzck1mempoWXJSdTlyY3pRRzZtZG9ERy9IU0tSUlM5TkZj?=
 =?utf-8?B?QmFCeG5EZ0dYYzZuVmluaVNrRVd0QS9JRHBybzlMZVV4YmwrMm5zeEQwRGFl?=
 =?utf-8?B?di9yVUZSR0hQVXJ1MU1lcEJDMGx6d1J5M2ZPZExvU1VFZy9BeW9lQ1FxeW14?=
 =?utf-8?B?NkxwUS9lSW9Md05WaHcySzdQT3pHWkVvUVFvR3RMYkQwOXlvUWNvS3c0NG9v?=
 =?utf-8?B?TVJ6R1lzaThhMU13MWV2alFaYTdwZjhGUDBtNmpoMzhlS3NvQmdpaVpuQk9z?=
 =?utf-8?B?MDVnYStLWUNZL2VFK0MrYVdWM004RHRJY1hveGZoSHhmZ0h4TThZOVU4Tmly?=
 =?utf-8?B?TnFqS2RCMFVmNWFFdU9kQit6YzgyMUNiN1AxaHVPTGxUOGtYdm1BQjN2aUxD?=
 =?utf-8?B?L3Y0UjVmb0NHd0NrNDI2a2lQMkorQTVmS3RZUFJHMFBCNjJETTBpTUVudmVP?=
 =?utf-8?B?bHJ1TVNJQVl0SEIvMlZRWFMvZUN2eG93bVZ3VFNNcGlSRHNvRUlnRkI3TWVI?=
 =?utf-8?B?SElKSUhoQmtLUCsrUmZMZDJyY2dFdzhvSExSajFKRFRVL3MzMzBrWGt6Nnh2?=
 =?utf-8?B?dFhZR3RRK2pBeWx1eHJPVC9VakJUT0hVSFZnbnFZRThpdjVqTEhNVTRkNTJX?=
 =?utf-8?B?TkxhUitodDFhZ2kvc3h5Z3VuTTVFNllRZThmV2hCS2NYZjlnUndiVExmNDZv?=
 =?utf-8?B?NUpoQWp6Q2NleUtZQTMyRXAzNHhtanlIVXNxZXF6ODVkWDBXOWVQR1lxeFdU?=
 =?utf-8?B?dnd1Y3RRdEpTdUkxdXdiSGNYT0hocFlENzR3aVpwcUJTaVdxWU9MWHpvVmdF?=
 =?utf-8?B?TXBGNkxrMUJUb2hEYlgzc2wxT0J6Mnh5d2hWdm93ckthaWJvR29weWkwNHlW?=
 =?utf-8?B?cEE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?RE96M25tTUVPS2x4aXJMN0NEMnBuM0hGUFkwWTlLeUhhNTk0V2lFdFpWSXI3?=
 =?utf-8?B?MVU5MlNHN0d4VnNqa3UxS281clNsUTJsUFEwWnl3RHpaUnYvUERINDdqQk5Y?=
 =?utf-8?B?TlV4T1hQSjhadW5JSmtpdlJBMElHN0N2cFQxVzlXa0htaDlrRG9Eek44V01V?=
 =?utf-8?B?UC9wMENpdDRETlZmZE5peG9lMlFjcWFvNVhDYXU4U2YwV00xVEZrNHIyeXY0?=
 =?utf-8?B?VHFDWnNhR21YNmgvRU9UVzh1YS9ORDNYODhkY2NBZnhPOTVOMkhMNWFmaFFn?=
 =?utf-8?B?YmZsWEV0aXNhUUlNQisvN3FrbW43bjBIUEZZeUxsRlBVNDgxTTBiT1d2aXNJ?=
 =?utf-8?B?SWtMN3dEOFdraU1JSDI2WWd1S1hVREtBRllaR3lpTW5iek1yZUZwUWduaW5K?=
 =?utf-8?B?NnFqUFQ0cGhaRUVuSVlobU41UkJaY1Vsd2lsYWo5c1ZaNE9sdFZ6M1RkVGFW?=
 =?utf-8?B?U01qWVR3SFkxbWZ6WmV5dUMxcStJQ0NBUzV6WUJpR3dNVXhDTnY1NFBDRnQw?=
 =?utf-8?B?RVhrRzFkK3BkMU9QVkRTM3llQUh6c0dXaWxNZlk0UFM3Qnc1UGVoQ0ltMjdi?=
 =?utf-8?B?M3p4TDhwQzlQMUNNNkRPR05heFhRam9kWmh0azAvUWVFRE1yZ1gvVW5FUkpw?=
 =?utf-8?B?OWFRcTMveDR6eG5QcW1LYWkyQzJFTjB4bVBhTkJqeHRjUWUwYTVKeWsrZ2Ix?=
 =?utf-8?B?bUpFRGZuUzdUVWN0MFVNTm9iY3FmbFZIdXQ4L1lHTkI5RzJzMjJ2ZkdjelhS?=
 =?utf-8?B?UHQxVC9HTzRzV3NQWWMzL0dkN0syMXVPYU9VY1hJSVEvR0tlNEhxbUl6QkQy?=
 =?utf-8?B?MjBoYVNTV1RrQjV1UVBXN09Ca3doOVQzWi9FcGNJVUVGbnVhRkdOaHBOMjR4?=
 =?utf-8?B?NDdaSkFoZ0gwUGIyb2kwQk90blhXbzc2SDY0TGhYaFFDandNdUNBTGkxUHJu?=
 =?utf-8?B?WFJrbHdreC93K0VFTWt1NklDMFJoVW8yaUZXZGYvMmtVNC82SlcvNXlGR0Ni?=
 =?utf-8?B?QjlTQStzME5KKzNNcllXM2VibGpkSU51QTRiekxPaXl2K1FWTzEwOVE0WSs4?=
 =?utf-8?B?bjNiS2Y0SGxoRGh0SlYzL0pxeWtqd1JrbWlMRGV0b2pITlJjQktmRXorOHFV?=
 =?utf-8?B?U3VFclRrOFYybzYrd1F5Z0c5c2Y2ZjJ4cjJuS3R4RVU4U2QwTVg1OFNTZk80?=
 =?utf-8?B?WDF5S05FTU9XMUNIdkc3WHVpTVg0N2JzSExZSUl4djNIUEhuMk5OWG9nc1VM?=
 =?utf-8?B?NVVGenFYdDlacm9YbXJhMkVpcnA2MmRLVkhId3h3T251MnQ1dWhEQkwzL2ZF?=
 =?utf-8?B?VHN0OHdMQjRHWGxYV0xKc0VrVGx5aFpLV29ocDIwdWJ3a05wckVqcDY5VGc1?=
 =?utf-8?B?d0tmWnNEZE9KbGNjb0NmSGJ3YXZLejZvUHBIRE41SXZHaVVkRnlzRllLWEZH?=
 =?utf-8?Q?x0wNqYIP?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8624b42e-5ec6-44df-addf-08db2b8668bd
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 10:07:28.7925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8IMdJtKjfC7wEuIunoYUEjXlZSJi4J6zf0ATKIIxP2jl7ZOVwbFNZSFhBp2ESCuc6IuLTX8qbPul/VdMqLKjwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7049
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-22_21,2023-03-22_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 spamscore=0
 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303230076
X-Proofpoint-ORIG-GUID: 7_J8XFMRTeqgLJCA3J8XN1EbUBveT--y
X-Proofpoint-GUID: 7_J8XFMRTeqgLJCA3J8XN1EbUBveT--y
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23/03/2023 09:53, Bao D. Nguyen wrote:
> +static int ufshcd_mcq_poll_register(void __iomem *reg, u32 mask,
> +			u32 val, unsigned long timeout_ms)
> +{
> +	unsigned long timeout = jiffies + msecs_to_jiffies(timeout_ms);
> +	int err = 0;
> +
> +	/* ignore bits that we don't intend to wait on */
> +	val = val & mask;
> +
> +	while ((readl(reg) & mask) != val) {
> +		usleep_range(10, 50);
> +		if (time_after(jiffies, timeout)) {
> +			err = -ETIMEDOUT;
> +			break;
> +		}

This looks just like readl_poll_timeout()

> +	}
> +
> +	return err;
> +}