Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230323100624.337354-1-b-kapoor@ti.com>
In-Reply-To: <20230323100624.337354-1-b-kapoor@ti.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 23 Mar 2023 11:14:08 +0100
Message-ID: <CAMuHMdWF0yGwM5hk=o+te2fPw-G8XhGZ6TGfF-KvnVnasPjKNQ@mail.gmail.com>
Subject: Re: [PATCH] arm64: defconfig: Enable CAN PHY transceiver driver
To:     Bhavya Kapoor <b-kapoor@ti.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        catalin.marinas@arm.com, will@kernel.org,
        quic_bjorande@quicinc.com, dmitry.baryshkov@linaro.org,
        arnd@arndb.de, krzysztof.kozlowski@linaro.org,
        nfraprado@collabora.com, broonie@kernel.org, rafal@milecki.pl
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Bhavya,

On Thu, Mar 23, 2023 at 11:06 AM Bhavya Kapoor <b-kapoor@ti.com> wrote:
> Enable CAN PHY transceiver driver to be built as a module.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>

Thanks for your patch!
(I wanted to send a similar patch soon ;-)

> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -368,6 +368,7 @@ CONFIG_REALTEK_PHY=y
>  CONFIG_ROCKCHIP_PHY=y
>  CONFIG_DP83867_PHY=y
>  CONFIG_VITESSE_PHY=y
> +CONFIG_PHY_CAN_TRANSCEIVER=m

This doesn't look like the right spot to insert this?

Based on "make savedefconfig", I'd say:

     CONFIG_PHY_XGENE=y
   +CONFIG_PHY_CAN_TRANSCEIVER=m
     CONFIG_PHY_SUN4I_USB=y

>  CONFIG_CAN_FLEXCAN=m
>  CONFIG_CAN_RCAR=m
>  CONFIG_CAN_RCAR_CANFD=m
> --
> 2.34.1

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds