Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 11:29:52 +0100
From:   Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Oded Gabbay <ogabbay@kernel.org>, Tomer Tayar <ttayar@habana.ai>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] accel/habanalabs: Remove redundant pci_clear_master
Message-ID: <20230323102952.GD2130371@linux.intel.com>
References: <20230323083553.16864-1-cai.huoqing@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230323083553.16864-1-cai.huoqing@linux.dev>
Precedence: bulk

On Thu, Mar 23, 2023 at 04:35:49PM +0800, Cai Huoqing wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> 	u16 pci_command;
> 
> 	pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> 	if (pci_command & PCI_COMMAND_MASTER) {
> 		pci_command &= ~PCI_COMMAND_MASTER;
> 		pci_write_config_word(dev, PCI_COMMAND, pci_command);
> 	}
> 
> 	pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
LGTM

Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>