Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3d34a25b-5311-e660-a724-b1c11bbaf5fc@quicinc.com>
Date:   Thu, 23 Mar 2023 03:38:31 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC PATCH v3 1/5] ufs: mcq: Add supporting functions for mcq
 abort
Content-Language: en-US
To:     John Garry <john.g.garry@oracle.com>, <quic_asutoshd@quicinc.com>,
        <quic_cang@quicinc.com>, <bvanassche@acm.org>, <mani@kernel.org>,
        <stanley.chu@mediatek.com>, <adrian.hunter@intel.com>,
        <beanhuo@micron.com>, <avri.altman@wdc.com>,
        <martin.petersen@oracle.com>
CC:     <linux-scsi@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        Eric Biggers <ebiggers@google.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
References: <cover.1679564391.git.quic_nguyenb@quicinc.com>
 <90b7b370269674fd7c0f505b59e0993c5b95a316.1679564391.git.quic_nguyenb@quicinc.com>
 <e251e5c3-152e-3ebe-aa9f-c5cfa36cfc3f@oracle.com>
From:   "Bao D. Nguyen" <quic_nguyenb@quicinc.com>
In-Reply-To: <e251e5c3-152e-3ebe-aa9f-c5cfa36cfc3f@oracle.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/23/2023 3:07 AM, John Garry wrote:
> On 23/03/2023 09:53, Bao D. Nguyen wrote:
>> +static int ufshcd_mcq_poll_register(void __iomem *reg, u32 mask,
>> +            u32 val, unsigned long timeout_ms)
>> +{
>> +    unsigned long timeout = jiffies + msecs_to_jiffies(timeout_ms);
>> +    int err = 0;
>> +
>> +    /* ignore bits that we don't intend to wait on */
>> +    val = val & mask;
>> +
>> +    while ((readl(reg) & mask) != val) {
>> +        usleep_range(10, 50);
>> +        if (time_after(jiffies, timeout)) {
>> +            err = -ETIMEDOUT;
>> +            break;
>> +        }
>
> This looks just like readl_poll_timeout()
I will make the change in the next revision. Thanks John.
>
>> +    }
>> +
>> +    return err;
>> +}
>