Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9879d72c-18af-5687-7ad6-56146009274b@ti.com>
Date:   Thu, 23 Mar 2023 16:12:09 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [EXTERNAL] Re: [PATCH] arm64: defconfig: Enable CAN PHY
 transceiver driver
Content-Language: en-US
To:     Geert Uytterhoeven <geert@linux-m68k.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <quic_bjorande@quicinc.com>,
        <dmitry.baryshkov@linaro.org>, <arnd@arndb.de>,
        <krzysztof.kozlowski@linaro.org>, <nfraprado@collabora.com>,
        <broonie@kernel.org>, <rafal@milecki.pl>
References: <20230323100624.337354-1-b-kapoor@ti.com>
 <CAMuHMdWF0yGwM5hk=o+te2fPw-G8XhGZ6TGfF-KvnVnasPjKNQ@mail.gmail.com>
From:   Bhavya Kapoor <b-kapoor@ti.com>
In-Reply-To: <CAMuHMdWF0yGwM5hk=o+te2fPw-G8XhGZ6TGfF-KvnVnasPjKNQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 23/03/23 15:44, Geert Uytterhoeven wrote:
> Hi Bhavya,
>
> On Thu, Mar 23, 2023 at 11:06 AM Bhavya Kapoor <b-kapoor@ti.com> wrote:
>> Enable CAN PHY transceiver driver to be built as a module.
>>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> Thanks for your patch!
> (I wanted to send a similar patch soon ;-)
>
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -368,6 +368,7 @@ CONFIG_REALTEK_PHY=y
>>   CONFIG_ROCKCHIP_PHY=y
>>   CONFIG_DP83867_PHY=y
>>   CONFIG_VITESSE_PHY=y
>> +CONFIG_PHY_CAN_TRANSCEIVER=m
> This doesn't look like the right spot to insert this?
>
> Based on "make savedefconfig", I'd say:
>
>       CONFIG_PHY_XGENE=y
>     +CONFIG_PHY_CAN_TRANSCEIVER=m
>       CONFIG_PHY_SUN4I_USB=y

Yeah . Thanks Geert. I will send a v2 ensuring its in correct spot,

>>   CONFIG_CAN_FLEXCAN=m
>>   CONFIG_CAN_RCAR=m
>>   CONFIG_CAN_RCAR_CANFD=m
>> --
>> 2.34.1
> Gr{oetje,eeting}s,
>
>                          Geert
>