Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7392905rwl; Thu, 23 Mar 2023 03:51:12 -0700 (PDT) X-Google-Smtp-Source: AK7set8apZIt883rO0IAHdiMeVpSj9ROo+Yw+tZAF5RG/QfV8nna7oUcxXriYZqjCt14n703IQXd X-Received: by 2002:a62:2581:0:b0:627:e69c:8488 with SMTP id l123-20020a622581000000b00627e69c8488mr5336888pfl.14.1679568672080; Thu, 23 Mar 2023 03:51:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679568672; cv=none; d=google.com; s=arc-20160816; b=DBUuenCEW23t9A8bPOegYODAetabZWjlPyMsPwQkSU7Us+sAn0JEhWmia4+awsISWJ HA5gLQb/GJuCwnWgP6r4dKodaYMtMRuq1rSvIaDJv1bDQGGXqthgt0OA7/vdoKuVhuMR m2tEj8ldxlvAlFhApW/0oK/tMZpVS2bIWACTWVY0YUhX/HNfFn45nrHoccpUIvMk0Jh2 9ACQXcDrdoU7/SxZucLHS/2kNxHWeEL2IfBG8Dibz4gdrScWepMUfkOXzB6jGNpNn7NA n3Rrwm6Iwi8Et+MPSJGdkQfCsv5KjjuukN1z8J0dqcIM7zV62KB2fH1uiy3Ib94U99Ef /Z0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cRF+6eWpis8s1Yhcc9VJXaQ5bD/FcNGGz+CiXpCWcgU=; b=cyX251cN/JTB7yH1sq4S+RR9gzh2kAVd/qU335wJWkvgbSgqBseOnMNoIczA580h95 BnK0WqpYQtt4MY6GQR5VQ+YSlS0zhL3xVFIXYt4chrzX/XfF7VUpE6LnolEQiTw6BFUY Mfm9beE8ygEKCE2Zn2XrHE2EVtz4vWUCmuMnobY1GADVI49kc7l409MAOtW3jCpg8C7S WgpI3nPCyFyuoIrQGYYLlv7DgrjyFzZ+QQWBOgOuxzOi9PezE4zMBgaxNILVVgsukxjq vcYKLqKOjdqlOH/1QVbDJUsZoXWz/iLnqZ/n4dQtB3C+9B+h9CqwH1ZWQZQiXBzttl9U D99A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Ix0fu/BI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 135-20020a63058d000000b00509e19a67c3si18678076pgf.87.2023.03.23.03.51.00; Thu, 23 Mar 2023 03:51:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Ix0fu/BI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbjCWKrj (ORCPT + 99 others); Thu, 23 Mar 2023 06:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231201AbjCWKrW (ORCPT ); Thu, 23 Mar 2023 06:47:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08B631F5F7 for ; Thu, 23 Mar 2023 03:44:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 891E6625B4 for ; Thu, 23 Mar 2023 10:44:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBE3AC433D2; Thu, 23 Mar 2023 10:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679568291; bh=3vX3C03J8BhEoEqAwZ/7TgV5jTjsf+HuXjGcKHODEGE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ix0fu/BI4RDZ8boPc/8IHjq9Q0Lo7fhzfQzUCQp2itYBwv33gsrWOm20m0QyIEj36 Kj6XLYqil3ykTTKoNypeOOr1pSu2s0fqrkuTKdfkQtvxhhh5kcg53vtoDGnzZyqm5p hTabvcpYg8JSOov39Q1sAk4n/m9BLW+JiQDbK5xAfWMsaVrSWe6y+8zpyCBTfliFHt pl+CvYcxP2GukwFYxFwl2h/M6J4bJKetQt8IVgOCl2eA8PA4Q7tO1Vz73jmk+Dfmw+ jGp2t7INtFOPUUmscWZPeE4SOjSsLQU1YrClYE882M8ICHvHysOh0VFdrwzaLpGaFt WWRVB3U+dNYfw== Date: Thu, 23 Mar 2023 11:44:45 +0100 From: Christian Brauner To: "Michael S. Tsirkin" Cc: Mike Christie , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, sgarzare@redhat.com, jasowang@redhat.com, stefanha@redhat.com, syzbot+6b27b2d2aba1c80cc13b@syzkaller.appspotmail.com Subject: Re: [PATCH 1/1] vhost_task: Fix vhost_task_create return value Message-ID: <20230323104445.qidusxeruimeawy6@wittgenstein> References: <20230322185605.1307-1-michael.christie@oracle.com> <20230323033557-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230323033557-mutt-send-email-mst@kernel.org> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2023 at 03:37:19AM -0400, Michael S. Tsirkin wrote: > On Wed, Mar 22, 2023 at 01:56:05PM -0500, Mike Christie wrote: > > vhost_task_create is supposed to return the vhost_task or NULL on > > failure. This fixes it to return the correct value when the allocation > > of the struct fails. > > > > Fixes: 77feab3c4156 ("vhost_task: Allow vhost layer to use copy_process") # mainline only > > Reported-by: syzbot+6b27b2d2aba1c80cc13b@syzkaller.appspotmail.com > > Signed-off-by: Mike Christie > > Acked-by: Michael S. Tsirkin > > The affected patch is not upstream yet, right? > I don't know if the tree in question allows rebases - linux-next > does. So ideally it would be squashed to avoid issues during bisect. > Still it's error path so I guess not a tragedy even without squashing. I tend to not rebase once stuff has been in linux-next but I make exceptions as long as it's before -rc4. For now I've put the patch on top (see the other mail I sent) but if it's really important I can squash it after the weekend (I'll be mostly afk until then.).