Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 14:00:35 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Mingxuan Xiang <mx_xiang@hust.edu.cn>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()
Message-ID: <e2067012-af9a-4cc7-ba12-3c055d54d915@kili.mountain>
References: <20230323095311.1266655-1-mx_xiang@hust.edu.cn>
 <eedbfdca-0eb1-4b01-976b-4ddba516cfad@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eedbfdca-0eb1-4b01-976b-4ddba516cfad@kili.mountain>
Precedence: bulk

Here is how I would write that function, but I can't justify sending it
because it's just a matter of personal taste.

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f6f13e7f1ba1..fcc831ac3236 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -36,32 +36,28 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
 	irq = platform_get_irq_byname_optional(dwc3_pdev, "host");
 	if (irq > 0) {
 		dwc3_host_fill_xhci_irq_res(dwc, irq, "host");
-		goto out;
+		return irq;
 	}
 
 	if (irq == -EPROBE_DEFER)
-		goto out;
+		return -EPROBE_DEFER;
 
 	irq = platform_get_irq_byname_optional(dwc3_pdev, "dwc_usb3");
 	if (irq > 0) {
 		dwc3_host_fill_xhci_irq_res(dwc, irq, "dwc_usb3");
-		goto out;
+		return irq;
 	}
 
 	if (irq == -EPROBE_DEFER)
-		goto out;
+		return -EPROBE_DEFER;
 
 	irq = platform_get_irq(dwc3_pdev, 0);
 	if (irq > 0) {
 		dwc3_host_fill_xhci_irq_res(dwc, irq, NULL);
-		goto out;
+		return irq;
 	}
 
-	if (!irq)
-		irq = -EINVAL;
-
-out:
-	return irq;
+	return -ENODEV;
 }
 
 int dwc3_host_init(struct dwc3 *dwc)