Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 12:06:27 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Alice Chen <alice_chen@richtek.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: rgb: mt6370: correct config name to select in
 LEDS_MT6370_RGB
Message-ID: <ZBwys8kLg7NLOk+K@duo.ucw.cz>
References: <20230323105410.10396-1-lukas.bulwahn@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="KU4ZDhGjr3zhG3Ut"
Content-Disposition: inline
In-Reply-To: <20230323105410.10396-1-lukas.bulwahn@gmail.com>
Precedence: bulk


--KU4ZDhGjr3zhG3Ut
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Commit 55a8a5c16eb3 ("leds: rgb: mt6370: Add MediaTek MT6370 current sink
> type LED Indicator support") introduces the config LEDS_MT6370_RGB, which
> selects the non-existing config LINEAR_RANGE. As the driver includes
> linux/linear_range.h, it is a safe guess that the config actually intends
> to select LINEAR_RANGES, which provides the library implementation for the
> function prototypes defined in the linear_range header file.
>=20
> Correct this naming confusion in the LEDS_MT6370_RGB config
> definition.

Looks good.

Acked-by: Pavel Machek <pavel@ucw.cz>

Best regards,
								Pavel

> +++ b/drivers/leds/rgb/Kconfig
> @@ -29,7 +29,7 @@ config LEDS_QCOM_LPG
>  config LEDS_MT6370_RGB
>  	tristate "LED Support for MediaTek MT6370 PMIC"
>  	depends on MFD_MT6370
> -	select LINEAR_RANGE
> +	select LINEAR_RANGES
>  	help
>  	  Say Y here to enable support for MT6370_RGB LED device.
>  	  In MT6370, there are four channel current-sink LED drivers that

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--KU4ZDhGjr3zhG3Ut
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZBwyswAKCRAw5/Bqldv6
8p70AJ4wG0X7vNDkIlEkRZpej3qqEwtKRwCfeojFwxU3iZ9i2lM6bi5RIKSSfrc=
=+rk9
-----END PGP SIGNATURE-----

--KU4ZDhGjr3zhG3Ut--