Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH] tty: serial: fsl_lpuart: fix crash in lpuart_uport_is_active
Date:   Thu, 23 Mar 2023 19:09:23 +0800
Message-Id: <20230323110923.24581-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KYqWllz4zJcu4WHynuSFywtVnWzgfLXpz2aRwvBoLC/5Yb8qxW3VEb2jCa+l?=
 =?us-ascii?Q?o8UNwGLIzq79S3er98aMWCYa2eCYwu5sFV5EeacbHyyCRknPZFSW9lUpiqzm?=
 =?us-ascii?Q?xhWIvmEmK+qeppbzaJwFrgi1aNJ2Kq518Xm0/dw+gb31BRrykGxWtztz+UUG?=
 =?us-ascii?Q?vNDwgTmij34u2HLiqXdz4PbLXVblBBtx7lEcq3/cTF/v7rTJsRkzKuQQQX9v?=
 =?us-ascii?Q?DxBzbhd/KAt7viG9AKK0lxapexmA968v/baJmHwhVKtIgSq6AxcirbLtyqKd?=
 =?us-ascii?Q?GQKlZwtHZSQzXGW6jj1mTiql5ZGMitNXkZop5UD1MrDSov8eU4PNWVTxtxIX?=
 =?us-ascii?Q?GIngaZzNkabxJ8Qnppj/SvL+Wf01hGWEDMaG7EckW9T2cCdTR5AKkVI2qqTJ?=
 =?us-ascii?Q?pL28A5iV6vn52J38891Lwl6O8FRTj3EAYqoxhOdTKcZS80nA79KBg0O+HjI/?=
 =?us-ascii?Q?s37p3WL33jlObxKiNZDAggw7A7+AcDQk8Ae9s+NUoyGAfkaRjHQcZo0DpV0D?=
 =?us-ascii?Q?KWlfhEfNsQzc3pQ2z/cTbw9W/7gnRiWMcJKTOkoPrfuleKkeW6UTzRPT2h3Z?=
 =?us-ascii?Q?dmkIGx5GFkboG6BE5yPICrIKo3cxaBjHCfuVcoVDJXyQDZVGdY62Zf0v4mt6?=
 =?us-ascii?Q?RuxAN89BpfS4gdq7fb8+k5L7MQKfwW2jVvivw+jiGoK7seXiOdnw5RF6s2/N?=
 =?us-ascii?Q?mToVis5TS3LdQQ4OoeRgQT1k5rZxBPZDcKSr9SDEUtIchC6xa3ZDZK3RgfDm?=
 =?us-ascii?Q?0jm1rIClZ+GrjiX8yby14+pJ1ZAl7jCXcEur+tyktTqi9TdY7Xfxx5QVbz5l?=
 =?us-ascii?Q?R4qzAkhplA1kifPGeaLRKtIB1+CKbEiVhxXYX/VSA+cZhvhF3SmoRg5c3VK4?=
 =?us-ascii?Q?0tYa/eC+Wdkz56SOY6TvGCMJ/nZWjhWSDQINUZHNWt8cvVoIM73uubi0bLrs?=
 =?us-ascii?Q?f9yjsrFwm7XBJEgBADS3vgPnyAKIJOPmnNCB4A23ruZV6ZSv74JNjrHS97nx?=
 =?us-ascii?Q?aVmsKILfCdzia68k8bpL3lX2bZP3kisJq4CARIzYB/Mrw+YqKne0DoouxK8A?=
 =?us-ascii?Q?MhMe9L5HR6byQlr1Y4ruE2jJeiK6uQgvA3WaZSXIljtq2YkrrwG5gpioee8v?=
 =?us-ascii?Q?IFXtTFRdeTEfDHyMMTGdLJjGvEUm04/6FsGH1F33UIPYFH+6LYWGergHLR8J?=
 =?us-ascii?Q?roQ+3H1NwZeWD3KMozXac/ndBZGEbt8n/+4ktLrCoWwf8axMZ76pUv2OA3ja?=
 =?us-ascii?Q?k9o+iNbB6QoHezY2pWsfipZeAfptnFJUV8jiFV0Pg97jdwhMlvYDJYnXsnDM?=
 =?us-ascii?Q?hEJ/Uh2VPTtJ8emLo2pf7v4+gDamgLM391Ww6bGREN1i7E+fXLq60aEhIouW?=
 =?us-ascii?Q?Kab67ZyA1EgkZW430Bhytwnxmu3vb9LYswo8u5wv48DVrEEEwrFCMneL/zLQ?=
 =?us-ascii?Q?XIaC0gJ9U1T33Zuv9HK408afvV320KwG46y4oZw02uaTI/uPyxzrsJzErkuq?=
 =?us-ascii?Q?TNCqlYUuurQr9EW5b1g92U5niV6vKSCaJJCNjvF41ILjsyHBpBpmM8XezO9T?=
 =?us-ascii?Q?9u7IvQRxnx9zce4jSJ+qq72FpiUMhoFGwSGJnvyZ?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83dd35bd-4e72-4ba4-b63f-08db2b8f8321
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 11:12:38.6367
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bi5TF8WedQCpXL0tI+WJ3kVC9YPtjwrgiRxuBdKIebn1iYbPPndsy3nHuoqvNSV0kRV8YXSiSi2dXScHvtsf4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9505
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For serdev framework, tty->dev is a NULL pointer, lpuart_uport_is_active
calling device_may_wakeup() may cause kernel NULL pointer crash, so here
add the NULL pointer check before using it.

Fixes: 4f5cb8c5e915 ("tty: serial: fsl_lpuart: enable wakeup source for lpuart")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 3281e81e1723..8daac87d063c 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -3022,7 +3022,7 @@ static bool lpuart_uport_is_active(struct lpuart_port *sport)
 	tty = tty_port_tty_get(port);
 	if (tty) {
 		tty_dev = tty->dev;
-		may_wake = device_may_wakeup(tty_dev);
+		may_wake = tty_dev && device_may_wakeup(tty_dev);
 		tty_kref_put(tty);
 	}
 
-- 
2.17.1