Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 14:13:33 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Oliver Neukum <oneukum@suse.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        Mingxuan Xiang <mx_xiang@hust.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()
Message-ID: <201fba22-f537-4d1f-bfc4-e4dc931707bc@kili.mountain>
References: <20230323095311.1266655-1-mx_xiang@hust.edu.cn>
 <129aec21-4997-6b8d-5bd2-8e013f575208@gmail.com>
 <73fd29ce-3072-dfce-ebf0-3e197230fa94@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <73fd29ce-3072-dfce-ebf0-3e197230fa94@suse.com>
Precedence: bulk

On Thu, Mar 23, 2023 at 11:54:24AM +0100, 'Oliver Neukum' via HUST OS Kernel Contribution wrote:
> 
> 
> On 23.03.23 11:29, Sergei Shtylyov wrote:
> > On 3/23/23 12:53 PM, Mingxuan Xiang wrote:
> > 
> > > platform_get_irq() no longer returns 0, so there is no
> > > need to check whether the return value is 0.
> > > 
> > > Signed-off-by: Mingxuan Xiang <mx_xiang@hust.edu.cn>
> > > ---
> > > v1->v2: remove redundant goto
> > >   drivers/usb/dwc3/host.c | 4 ----
> > >   1 file changed, 4 deletions(-)
> > > 
> > > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> > > index f6f13e7f1ba1..ca1e8294e835 100644
> > > --- a/drivers/usb/dwc3/host.c
> > > +++ b/drivers/usb/dwc3/host.c
> > > @@ -54,12 +54,8 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
> > >   	irq = platform_get_irq(dwc3_pdev, 0);
> > >   	if (irq > 0) {
> > >   		dwc3_host_fill_xhci_irq_res(dwc, irq, NULL);
> > > -		goto out;
> > >   	}
> > 
> >     Now drop {} please. :-)
> 
> Well, no, please drop the whole patch.
> If platform_get_irq() returns -EPROBE_DEFER you now give that
> as a return value.
> 
> This tiny bit of optimization is not worth changing semantics.

The v2 patch doesn't change the semantics.  Mine did though...

regards,
dan carpenter