Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 14:12:49 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Mingxuan Xiang <mx_xiang@hust.edu.cn>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()
Message-ID: <42a2ef2e-b522-40c9-ada2-0e804f7df5d5@kili.mountain>
References: <20230323095311.1266655-1-mx_xiang@hust.edu.cn>
 <eedbfdca-0eb1-4b01-976b-4ddba516cfad@kili.mountain>
 <e2067012-af9a-4cc7-ba12-3c055d54d915@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e2067012-af9a-4cc7-ba12-3c055d54d915@kili.mountain>
Precedence: bulk

On Thu, Mar 23, 2023 at 02:00:35PM +0300, Dan Carpenter wrote:
>  	irq = platform_get_irq(dwc3_pdev, 0);
>  	if (irq > 0) {
>  		dwc3_host_fill_xhci_irq_res(dwc, irq, NULL);
> -		goto out;
> +		return irq;
>  	}
>  
> -	if (!irq)
> -		irq = -EINVAL;
> -
> -out:
> -	return irq;
> +	return -ENODEV;

Oh wait.  We actually need to propagate the error code here because of
-EPROBE_DEFER so my patch introduces a bug.

regards,
dan carpenter