Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 08:31:16 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nanyong Sun <sunnanyong@huawei.com>
Cc:     "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>, joro@8bytes.org,
        will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        wangrong68@huawei.com, Cindy Lu <lulu@redhat.com>
Subject: Re: [PATCH v2] vhost/vdpa: Add MSI translation tables to iommu for
 software-managed MSI
Message-ID: <ZBw4hGj8oGARaKhW@nvidia.com>
References: <20230207120843.1580403-1-sunnanyong@huawei.com>
 <Y+7G+tiBCjKYnxcZ@nvidia.com>
 <20230217051158-mutt-send-email-mst@kernel.org>
 <Y+92c9us3HVjO2Zq@nvidia.com>
 <CACGkMEsVBhxtpUFs7TrQzAecO8kK_NR+b1EvD2H7MjJ+2aEKJw@mail.gmail.com>
 <20230310034101-mutt-send-email-mst@kernel.org>
 <CACGkMEsr3xSa=1WtU35CepWSJ8CK9g4nGXgmHS_9D09LHi7H8g@mail.gmail.com>
 <20230310045100-mutt-send-email-mst@kernel.org>
 <ZAskNjP3d9ipki4k@nvidia.com>
 <c6e60ed9-6de2-2f4a-7bd1-52c53ed57a28@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c6e60ed9-6de2-2f4a-7bd1-52c53ed57a28@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0/Ete/LvgouHTQENTKhUE4z01IwTMicwsXVhLB4iLSKxDP6iekN92gicsmt/?=
 =?us-ascii?Q?FSK00hszWRZ1jXE4d3RqWQNftIN+FRM0DpKAL9qvgJHfGWFAn3RP6SG2FY4n?=
 =?us-ascii?Q?pqUiJHfDERXqMvd670+IJzGHj4oCUrm+uQQ/HvBHIXNDSZYLlKfW6nCFKLyq?=
 =?us-ascii?Q?pGRiNzA/WVfyXxRoEJk2x2weR+SUci7Ujn7Jfrw1hJlH9lVA/FArwGl4q1EA?=
 =?us-ascii?Q?s3R+YNLj0Tw8l4XLv+6yWPz92VhWznF+vgV7Iu5EZ3+MmFH81q0hfKo3bM5z?=
 =?us-ascii?Q?fepbxPL1nF22VbOSgwr84oe7qaUEbNJOO0ZOKjmcO2VQwo1zx++3ONo/gE6h?=
 =?us-ascii?Q?aSQO10OuAQx2H4FbmHfZKqJLslvrXOoHCF0DvtJ+C6OLQFdz702En1Oa6o7s?=
 =?us-ascii?Q?TpeHe0x59WHulYwKt2sEcwhkwBcK8sjNzaVt+JkP6B7MBx1GMvlIOYP8Yxo+?=
 =?us-ascii?Q?8htRr6OucW7JgdyG6Fmx1HAl4GVnzSrxNv1Isrz9toCkBbZwO+P+OVqQwvqB?=
 =?us-ascii?Q?H7lzrLJi2/TZ63Nm6XKTYSdqna1DrknQ0bgHg2tWkQ9xBftDU8xtvwPnzH8f?=
 =?us-ascii?Q?NqYqTKv/ib5symoTYMkIslOHS3dbWZGnIIDmA+fMlQz6PIsi67c5a7ii/bB7?=
 =?us-ascii?Q?8MVXkLJCE9PpKs3I+4weCXOitpH5bDd4odxjXEZk0tEJQkywo0W39QZfX/Q8?=
 =?us-ascii?Q?hoG2cytrW0wliMY7EYCHwKpEjBawC7eF2UJNyD4/atVmlqQbuRn19I+u4q9B?=
 =?us-ascii?Q?lzjwEKfthSGJ3Ipx2B4D+whpwVwLb3XC55xGWPiwqNryCUtt+gJIkzV73QfL?=
 =?us-ascii?Q?aRp9KTCrJAtFB1APuDPlckb6UknqNHcDJFhabo3+QcBDKK6QWBYy++ieM0/C?=
 =?us-ascii?Q?QnR0DpjUXmiAgVyfIsQxZYhaSOw0ln7gTW4QwT3+IJo3FMNU+OtSFw1Riarj?=
 =?us-ascii?Q?pOu9Fe2GU8Y8sFTI7/z8B4xczQO+CD7iZY+VXRGxoiR1HSOwGItiapWYXy08?=
 =?us-ascii?Q?t4glvmnBABGEYC/zm69Jb9z7oLpUQWazxtFhP/r/eD/igEnnDWr7Um3NbWlU?=
 =?us-ascii?Q?zPA3kJxQPpMJ0mYOo/0I9lRyOyZDVDzI242k4xmZ9PcWKFDP7pjPh9WAvYNY?=
 =?us-ascii?Q?u6I+dTrz9Knm84H8GqRYaJKttDnRq1ARX/HhXr10I6mvQ7Ne93lDXWhIjeJ9?=
 =?us-ascii?Q?rSGztysCUan1BxUyYjA4mlfpn6i2SU+Whlfy+XcYjwsTKy9mjr+Ddx2k4HHy?=
 =?us-ascii?Q?AP220ySSg1p9cNwfEl3LjQk5czdZbEGeo8Wgbec1R47EQ/5R3OEjTJdQXPqJ?=
 =?us-ascii?Q?SQ5T8V6bv3Wv76IRi0jvdIyIxgRVp9eYPwWJ0OCV529MrbcZCwaXtthpEilX?=
 =?us-ascii?Q?zDhSKzBpikikZqxP4ZMBiKd9jre+LcxfTOmGmPUDAidK5N37lg1IROY7SLL9?=
 =?us-ascii?Q?DePIfW/LDj9qItvRUKnJ6KyEVQHaVeclep+BFB8eyBj4PTpCgxw5oJlvZZqA?=
 =?us-ascii?Q?J0d7c3Rx2cy2hiOoMT/+iGRD1hbLG1IP39OUZkZ8JJA/+0nXMKI+aFgtbYff?=
 =?us-ascii?Q?Tg2xy5dhaa1I/bmNMzqvhQsOUJqqRoz58oehPNrN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c73ff28-ac10-4beb-2765-08db2b921e96
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 11:31:18.3152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kmturz/UnKjDR12kvvLJmogcA0DjRJxHmFARnm0aW8+PQVpQXNBcsb9WujrkpLWG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5245
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 05:22:36PM +0800, Nanyong Sun wrote:
> > A patch to export that function is alread posted:
> > 
> > https://lore.kernel.org/linux-iommu/BN9PR11MB52760E9705F2985EACCD5C4A8CBA9@BN9PR11MB5276.namprd11.prod.outlook.com/T/#u
> > 
> > But I do not want VDPA to mis-use it unless it also implements all the
> > ownership stuff properly.
> > 

> I want to confirm if we need to introduce iommu group logic to vdpa, as "all
> the ownership stuff" ?

You have to call iommu_device_claim_dma_owner()

But again, this is all pointless, iommufd takes are of all of this and
VDPA should switch to it instead of more hacking.

Jason