Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 12:33:39 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Joseph Strauss <jstrauss@mailbox.org>
Cc:     lee@kernel.org, jansimon.moeller@gmx.de, conor@kernel.org,
        christophe.jaillet@wanadoo.fr, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Add multicolor support to BlinkM LED driver
Message-ID: <ZBw5E4ecNvfgd0RB@duo.ucw.cz>
References: <20221228010958.9670-1-jstrauss@mailbox.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="bsx+dbfh8TSfU6VM"
Content-Disposition: inline
In-Reply-To: <20221228010958.9670-1-jstrauss@mailbox.org>
Precedence: bulk


--bsx+dbfh8TSfU6VM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> In the blinkm_probe function, the multicolor LED class is registered
> after the regular LED classes. The blinkm_set_mc_brightness() function
> had to be added to calculate the three color components and then set the
> fields of the blinkm_data structure accordingly.

It needs to be either single multicolor LED or three separate
LEDs. But not both at the same time.

> +++ b/Documentation/leds/leds-blinkm.rst
> @@ -13,9 +13,27 @@ The device accepts RGB and HSB color values through se=
parate commands.
>  Also you can store blinking sequences as "scripts" in
>  the controller and run them. Also fading is an option.
> =20
> -The interface this driver provides is 2-fold:
> +The interface this driver provides is 3-fold:
> =20
> -a) LED class interface for use with triggers
> +a) LED multicolor class interface for use with triggers
> +#######################################################
> +
> +The registration follows the scheme::
> +
> +  blinkm-<i2c-bus-nr>-<i2c-device-nr>-multi
> +
> +  $ ls -h /sys/class/leds/blinkm-1-9-multi
> +  brightness  device  max_brightness  multi_index  multi_intensity  powe=
r  subsystem  trigger  uevent
> +

Yeah, that does not really match the
naming. /sys/class/leds/blinkm-1-9:rgb:indicator ? See
Documentation/leds/well-known-leds.txt and possibly extend it so that
future general-purpose LEDs use similar naming.=20

> +b) LED class interface for use with triggers
>  ############################################
>

So the b) should be removed.

> =20
> -b) Sysfs group to control rgb, fade, hsb, scripts ...
> +c) Sysfs group to control rgb, fade, hsb, scripts ...
>  #####################################################
>

And c) should be deprecated and removed in future.

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--bsx+dbfh8TSfU6VM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZBw5EwAKCRAw5/Bqldv6
8uNUAKCrHOUyebPbRqUpmizwUYiOHnYruACgnShycXKCmr31mqT4M9r2pRsUDZk=
=iebB
-----END PGP SIGNATURE-----

--bsx+dbfh8TSfU6VM--