Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 12:46:51 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     Lee Jones <lee@kernel.org>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: max597x: Add support for max597x
Message-ID: <ZBw8K/YwrQZzt3BP@duo.ucw.cz>
References: <20230322124316.2147143-1-Naresh.Solanki@9elements.com>
 <20230322124316.2147143-2-Naresh.Solanki@9elements.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="WvSCQyaudfTEwz4M"
Content-Disposition: inline
In-Reply-To: <20230322124316.2147143-2-Naresh.Solanki@9elements.com>
Precedence: bulk


--WvSCQyaudfTEwz4M
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> max597x is hot swap controller with indication led support.
> This driver uses DT property to configure led during boot time &
> also provide the led control in sysfs.

Can you provide dts example showing how you'll use it?

> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>

> +static int max597x_setup_led(struct device *dev, struct regmap *regmap, =
struct device_node *nc,
> +			     u32 reg)
> +{
=2E..
> +	ret =3D led_classdev_register(dev, &led->led);
> +	return 0;
> +}
> +
> +static int max597x_led_probe(struct platform_device *pdev)
> +{
=2E..
> +	for_each_available_child_of_node(led_node, child) {
> +		u32 reg;
> +
> +		if (of_property_read_u32(child, "reg", &reg))
> +			continue;
> +
> +		if (reg >=3D MAX597X_NUM_LEDS) {
> +			dev_err(&i2c->dev, "invalid LED (%u >=3D %d)\n", reg,
> +				MAX597X_NUM_LEDS);
> +			continue;
> +		}
> +
> +		ret =3D max597x_setup_led(&i2c->dev, regmap, child, reg);
> +		if (ret < 0) {
> +			of_node_put(child);
> +			return ret;
> +		}

This will cause crashes. After you successfully registered one LED,
you can't just bail out.

BR,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--WvSCQyaudfTEwz4M
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZBw8KwAKCRAw5/Bqldv6
8r+4AJ9ueTFs2ZtMyw+f+QrsDX6XsZKc2ACcDQ/MIxL3p+o+WwJ0oFt/r3gvAAw=
=4Jjm
-----END PGP SIGNATURE-----

--WvSCQyaudfTEwz4M--