Received: by 2002:ac8:156:0:b0:3e0:cd10:60c8 with SMTP id f22csp2503392qtg; Thu, 23 Mar 2023 05:03:44 -0700 (PDT) X-Google-Smtp-Source: AK7set8NxofYFAhfd53hRLB6busG8YCQHSzuaqA2YwgaeV5o+XHv3v/r3r2/ZNVMbSi6APptaYYT X-Received: by 2002:aa7:dacb:0:b0:501:fd71:7e20 with SMTP id x11-20020aa7dacb000000b00501fd717e20mr4635996eds.3.1679573024318; Thu, 23 Mar 2023 05:03:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679573024; cv=none; d=google.com; s=arc-20160816; b=epmy5jpfMSFVewQwkF1+gEcsrLxQT8HKoBf6q1EhFYOlQfGGWoaofj617+5ZvN3LEz KPv+x6GXkAZrLVXqmpA0I84TNC1EkGCggiTlxNhcJdsarduuzKzNTsIJIdkQQ+981lZn YWvwsnpN+G8VE1gakNqIbf5CJSP5i3UTGJOWIp9u5tEDeuIZ3hZBdQ6kGWJ3l1rAQjcC c86QXa8nlY5DmD3PbZInM6EM9U/kHMFmmt+bv1KpS8J2aTzmdHXb2PcAVxq+8E2lzsuQ HyBAH4xFAtXvDujDCnI41vVLEhSjN+POvP63OOgXNRO8Unz2VK9aFBS/HWznpMN+RK2/ dazg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=4AlM28FcXBWaslhaj+kycn6ly2oM2J2ZyGc1DlXRG+8=; b=x/HBiRVm2LN/IBGgn7KPYsvDq+BUnIO0pXg61l1ocTkH7mW/vVvcEn0bsU88S41zYi ktuyQTdu3wCwD7RTNoHzAiTpwvnPmKo05JHJYtZK/Wmc/vEplxVxlRgPCJbZ3enkOaDb RQCBedqmzeTP7NCxdNKYESM2M0Y3CMpy1ifDIBXpOi2k1S0iOfdjtmpR9cGUa4kjsNYQ QxPr13ZuJ9sTCgwV/GtCSuoy7+KqnvRaiCwPOqZBgp37wL8+VvcqYmdoAOoP+y75yWYc EE7apuLziWLVIOsFbndkd9n23hoimnIp9gM37xDydIVCjtpkw0U7uGpfyyp4mL5uZGFs V/Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m21-20020a056402051500b004c698b50189si18978652edv.341.2023.03.23.05.03.16; Thu, 23 Mar 2023 05:03:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbjCWMCn (ORCPT + 99 others); Thu, 23 Mar 2023 08:02:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231625AbjCWMCP (ORCPT ); Thu, 23 Mar 2023 08:02:15 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9413940C6; Thu, 23 Mar 2023 05:00:34 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 691974B3; Thu, 23 Mar 2023 05:01:18 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CCA713F766; Thu, 23 Mar 2023 05:00:32 -0700 (PDT) Date: Thu, 23 Mar 2023 12:00:30 +0000 From: Sudeep Holla To: Rob Herring Cc: Cristian Marussi , Sudeep Holla , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] firmware: Use of_property_present() for testing DT property presence Message-ID: <20230323120030.7mk62xk7tco32zw2@bogus> References: <20230310144704.1542045-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310144704.1542045-1-robh@kernel.org> X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of this, convert of_get_property/of_find_property calls to the > recently added of_property_present() helper when we just want to test > for presence of a property and nothing more. > > Signed-off-by: Rob Herring > --- > drivers/firmware/arm_scmi/optee.c | 2 +- Acked-by: Sudeep Holla (for the SCMI part) I am assuming you will route this as it has other changes as well in the patch. -- Regards, Sudeep