Date: Wed, 19 Sep 2007 17:06:04 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>
Cc: Chuck Ebbert <cebbert@redhat.com>, tilman@imap.cc,
       linux-kernel@vger.kernel.org, gregkh@suse.de, a.zummo@towertech.it
Subject: Re: 2.6.23-rc6-mm1
Message-Id: <20070919170604.f7e82f19.akpm@linux-foundation.org>
In-Reply-To: <20070919234448.8E87D2319AA@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
References: <20070918011841.2381bd93.akpm@linux-foundation.org>
	<46F1AA6E.1030708@imap.cc>
	<20070919162438.7264f06c.akpm@linux-foundation.org>
	<20070919234448.8E87D2319AA@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1758
Lines: 42

On Wed, 19 Sep 2007 16:44:48 -0700
David Brownell <david-b@pacbell.net> wrote:

> > > <4>[   21.211942] Duplicate file names "rtc" detected
> >
> > Nah, that's an rtc-specific problem.
> 
> RTC-related ... but it's a procfs bug, since it's procfs which doesn't
> even bother to check for duplicate names before it registers files.

So you keep on claiming, but I don't think I've yet seen a description of
the *reason* why two copies of this file are being created, and a
description of why that is an OK thing for the kernel to be doing.

> > From: Chuck Ebbert <cebbert@redhat.com>
> >
> > AFAICT the rtc problem is caused by misconfiguration: both the new
> > and old rtc driver have been built and they are both trying to load.
> 
> That _shouldn't_ be a problem at all; only one of them should be
> able to bind to that hardware.
> 
> The only problem I see in these messages is that procfs bug.
> 

It's not obvious that this is only a procfs bug.  If some part of the
kernel tries to add a procfs file which is already there, that's often a
bug in the caller.

Yes, procfs should have been checking for this.  But it is too late now for
us to just fail out of the procfs registration code.  Because this can
cause previously buggy-but-works-ok code to now fail completely.

So I think the best we can do now is to retain the runtime warning and to
continue to "succeed" and to identify all the problematic codesites and to
either fix them or to convince ourselves that they really are working as
intended. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/