Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7495122rwl; Thu, 23 Mar 2023 05:16:39 -0700 (PDT) X-Google-Smtp-Source: AK7set8OyYHKkvk5rIwW2DK8EgcovVPDQYObccUBYPcM92Z51GjFB+ssoOtytDjqe2BL4itWV3D4 X-Received: by 2002:aa7:d04a:0:b0:4ad:5950:3f53 with SMTP id n10-20020aa7d04a000000b004ad59503f53mr8743025edo.7.1679573798815; Thu, 23 Mar 2023 05:16:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679573798; cv=none; d=google.com; s=arc-20160816; b=mQwjBH6Hib8iFNhsy6U7p+5LjEdE2d4gHowaU7nkSsC27M2e3kk4lTnX16eopiLRCF D1AjrT14VyqzpyBZ+P5wDXUOX1X8GyNOMNbwM9MnEiJ6YkA2fUkoSMnl4Vy1y6PebAeZ 7Ahya7PmJlHgyksUi54OzXg2G25SKMoxa7X2vpEviHRZ5sxSEk622CV2WaQ73XLndtCr VUCZs37ClpdHfXnffDo4VeaOQwgedSbYQfGDsj/Rmc9In39ShvlsWEOlhqAyZMPr+pGV WUs75xBhJHgfsMvkdR5TtejmbTpcapIVvIA9rtceIDYD+TMAZuHnh9+ImR37LtgnInkC BJ4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ALFwvw50Oz+gjNGnlwxKeh+PF+7RPaNRR5vajpRayGA=; b=gszMTn28tl3QULjymVTT38sSnyEYkVs5Yej6MasnI35w6Uf372AF0y+JlzpMT39Rya JjcNpoxB8c9faTrieVCs1oXxoMcZQqlqjUew1KnfulIpY81bHSnIJasnp/LHS/Nim6AT U6L+AB7UM8Q+VU+32RqpYQ8uEB7vSEfbpbclGNR3Wvv37dHmiF3f6hfkKhQRe215cjn1 49c0jbnGKj3Y7IPSiP6ezlyXOJbNU7YBCY2fUI00eFF3GZvgwc2/4avRzCnUlcrMhlMP /ySkmrYMuxRO/TFeTS9YRShrp9XGicTx06hABdA/GRgpYnqyb4VrOgutd3YY8IBB05tm pHLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lQ/Luegj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hs6-20020a1709073e8600b009351565d36bsi13683356ejc.274.2023.03.23.05.16.14; Thu, 23 Mar 2023 05:16:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="lQ/Luegj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbjCWMOQ (ORCPT + 99 others); Thu, 23 Mar 2023 08:14:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231273AbjCWMN4 (ORCPT ); Thu, 23 Mar 2023 08:13:56 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED81F265A4 for ; Thu, 23 Mar 2023 05:13:43 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id p203so24447026ybb.13 for ; Thu, 23 Mar 2023 05:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679573622; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ALFwvw50Oz+gjNGnlwxKeh+PF+7RPaNRR5vajpRayGA=; b=lQ/Luegj+SIyFETuhC0mhnn/jgRkpkvEHiFYjAEuHWuSSJvn2FRgMIudLEGhPQ+g/s qCKvIlkMea84aQzG0fNMn8cOfnzszxdcUzewbspuhaz6mEjeeqOY3FR+56+A9gnYRUc8 XjTh07K5Mrn8OoUOHcCvzjCC1dzHqxECkNZgUDCDqhh15BkUpyWE6z0YOYxzKa3/DogH VOW6iLubS/7upy1Oik8vyhWoBsKwstOofF8l5P4Vl6lVuS6JHWTQOhv06QSgOyVoRNH1 pKJCUItaEvXrsdV0G3mZJ6IAojR3EcC/oznO/s8MXymCml5E4k60REnqcaVX0t7jx7fa t6RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679573622; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ALFwvw50Oz+gjNGnlwxKeh+PF+7RPaNRR5vajpRayGA=; b=Fr5eK3ytr+QZiaqNM8/3sPTTyAfUeQpnGFvBSpnA8Nt3bJB6GB0CYfMQ9NWB4vkiif nM7LU6141oG9DggV1WgzzBPs0sH9Htg/0jvkEHcYiWaNcZRb0G+mUcnSBKcfT0RpY5og Tt8PSun30WfntVfwu2XgpC3xGTV1IapTg7cJCYKczwqBqaPy3Y4GodWTkDcvn2HKRBsz aNY44gRTnJc+QsqZL9n9z0EjWttmUUvq+dbc/4eXJOwBSMjP2Lu+QtiNrKn5TE7BVPFq IoPJCYXPlhn2C+bcs+rAcEoaGW4bZhqn/ntDMLI42hDGzbnHAK7ksG+RXv3pUv2ziaD0 wfbw== X-Gm-Message-State: AAQBX9cfGbpEqf48sYsobUn9+O1b7DS1CSVFuJFl7etK9uPYhdbAfInK TqpyemYDEKFFsN71/D/vWsCXwfoc8qayR3zuSPtYkQ== X-Received: by 2002:a05:6902:1203:b0:b71:f49f:8d22 with SMTP id s3-20020a056902120300b00b71f49f8d22mr1977317ybu.3.1679573622701; Thu, 23 Mar 2023 05:13:42 -0700 (PDT) MIME-Version: 1.0 References: <20230315053434.38316-1-yang.lee@linux.alibaba.com> In-Reply-To: <20230315053434.38316-1-yang.lee@linux.alibaba.com> From: Ulf Hansson Date: Thu, 23 Mar 2023 13:13:07 +0100 Message-ID: Subject: Re: [PATCH -next] mmc: omap: Use devm_platform_get_and_ioremap_resource() To: Yang Li Cc: linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Mar 2023 at 06:34, Yang Li wrote: > > According to commit 890cc39a8799 ("drivers: provide > devm_platform_get_and_ioremap_resource()"), convert > platform_get_resource(), devm_ioremap_resource() to a single > call to devm_platform_get_and_ioremap_resource(), as this is exactly > what this function does. > > Signed-off-by: Yang Li Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/omap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c > index 57d39283924d..ce78edfb402b 100644 > --- a/drivers/mmc/host/omap.c > +++ b/drivers/mmc/host/omap.c > @@ -1345,8 +1345,7 @@ static int mmc_omap_probe(struct platform_device *pdev) > if (irq < 0) > return -ENXIO; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - host->virt_base = devm_ioremap_resource(&pdev->dev, res); > + host->virt_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > if (IS_ERR(host->virt_base)) > return PTR_ERR(host->virt_base); > > -- > 2.20.1.7.g153144c >