Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230319164744.1707169-1-trix@redhat.com>
In-Reply-To: <20230319164744.1707169-1-trix@redhat.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Thu, 23 Mar 2023 13:13:25 +0100
Message-ID: <CAPDyKFqfdYKXwaCbT6_hBsX1ZxeVtNivZBQmh3gA8554F944hA@mail.gmail.com>
Subject: Re: [PATCH] mmc: sdricoh_cs: remove unused sdricoh_readw function
To:     Tom Rix <trix@redhat.com>
Cc:     saschasommer@freenet.de, nathan@kernel.org,
        ndesaulniers@google.com, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 19 Mar 2023 at 17:47, Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/mmc/host/sdricoh_cs.c:104:28: error: unused function
>   'sdricoh_readw' [-Werror,-Wunused-function]
> static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
>                            ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdricoh_cs.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdricoh_cs.c
> index 76a8cd3a186f..57b8c1a96756 100644
> --- a/drivers/mmc/host/sdricoh_cs.c
> +++ b/drivers/mmc/host/sdricoh_cs.c
> @@ -101,14 +101,6 @@ static inline void sdricoh_writel(struct sdricoh_host *host, unsigned int reg,
>
>  }
>
> -static inline unsigned int sdricoh_readw(struct sdricoh_host *host,
> -                                        unsigned int reg)
> -{
> -       unsigned int value = readw(host->iobase + reg);
> -       dev_vdbg(host->dev, "rb %x 0x%x\n", reg, value);
> -       return value;
> -}
> -
>  static inline void sdricoh_writew(struct sdricoh_host *host, unsigned int reg,
>                                          unsigned short value)
>  {
> --
> 2.27.0
>