Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b5f8240e-f46a-b83b-ed16-66c2d8c5571f@oracle.com>
Date:   Thu, 23 Mar 2023 12:40:28 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 0/5]scsi:scsi_debug: Add error injection for single device
Content-Language: en-US
To:     Wenchao Hao <haowenchao2@huawei.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Douglas Gilbert <dgilbert@interlog.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     linfeilong@huawei.com, louhongxiang@huawei.com
References: <20230323115601.178494-1-haowenchao2@huawei.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230323115601.178494-1-haowenchao2@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUJvTWpyTFZIT0pKT3RiNE85M2tZSjRCWEdlTlFabC8yQ0NudmtRUmRJU2F6?=
 =?utf-8?B?OStLRi8yS0V4YytIZDJpdUZwT2grRGNHOGhuL3pucDRxeDd4aDQ4RWFEU2pY?=
 =?utf-8?B?amgrQnhnWDRNOFhIdnU0bTFCVDhzK1hXVFhrcXhhMWtHTGZSNEFEMGlsWjFn?=
 =?utf-8?B?eU56Yk1ZZ0syMUJpT1g3Q3g3cjZ1am9TMFpUSmwyOWd1MkFJcXprRFhuaC9p?=
 =?utf-8?B?Rlpmd2ZtblQ4S2ZaRndxUUJXYUplZC9Oc2tQMHoybnl5Q0RtdHVkUTdjZlNL?=
 =?utf-8?B?MWluQlBCRVlydXR6bjhLQm8rWndQdk9UQzc1SnNFWEdEd3J3SnUycVczTys5?=
 =?utf-8?B?djhHc2xFb2lBSTVabHlNOWc1NXJsbHNFdzljam5YUDVaQVBRdFliYnQxYnF5?=
 =?utf-8?B?NEhLQ3JlN2RzNk9rZm5aWDZRMUJhQ0JNNFZ6YzYrV0p4OExXa3dyUWtxRWZt?=
 =?utf-8?B?L25oaGNlYzZOdEFtcWNUM2R6TytIdm50aWFSckdFWnVwcGIzR200eWttUjZK?=
 =?utf-8?B?b2E1YlpzKzB0K3FGeEw5Z0xTdHFHSWhZM0JnUy9iMDdLSEh6SXZOaEJpWUQ3?=
 =?utf-8?B?SGdxZE0xNXhRdmc2ZmUxV2h5VWRrbklJVXdKMjJBblpHRTMrSWJibzA0cGVu?=
 =?utf-8?B?b0dQLzhmaDRCV2ZsanVwblBVeTN1andBYlNjWmFISVZSN2doY2dCLzNUZnF4?=
 =?utf-8?B?cC9EdUtna3BZTnQvb1BtZ3JvbmN3QUFwRUpwTUVBeGloeDEyTnpOWWduNWZ6?=
 =?utf-8?B?Q1hydmI1aHdDSS9nRW5Id0tSVkNZOHNCdDZ6cDhVZFJSWnVBdGt2OTlLbTda?=
 =?utf-8?B?YzlNSzRpQnhrU3BpSmR2YXlSTTFwdzk4VXgxNnNUYzJvNkpEMjN4VzBFN3FW?=
 =?utf-8?B?WE04aVdubWFqMWdUWGlHTi9xR2RPZHFPVFRwQUtoNnlaRnVoUmQyVzd3M2po?=
 =?utf-8?B?cHp3N1NsVFhHL1RYS2d2SERROTRGT1lrN2lNOStaNGpaSmVoUnZRL1F0L29n?=
 =?utf-8?B?NSsyYllHK3J3YUsvUHd1WlV6aXE1RDhOVmphSjFtWnhVT1QrR2VST1VoK3k3?=
 =?utf-8?B?dCtvbEpOS0RualBWVWhtSUI2RU10YWJKTGRGYU1YN1lRSG5lbEVPZlNrT25H?=
 =?utf-8?B?dmhFaUwwOGhRS2VQMWs4SE4ybHNwbHYyU3FrQ3g4RnQ5ekJpZnJLbjQrTFJG?=
 =?utf-8?B?QWhvRldaa0wvZXFYZ0t1Zi9vMEpwcWFYUThJNmN6OHFJSENIUTRtc0Y4a0Zx?=
 =?utf-8?B?MGU4S09KQmZBV1NnTGJPSWVaNGZUQkgyWk9PWmhrKzlXZGtYdUdkY3hOWDdF?=
 =?utf-8?B?WFMzaHB1RjZnbEgrMVZGRmFQaXRKQm9xRkFFeFNhNUxZZnJYaTlQYmJiaml5?=
 =?utf-8?B?TEMxMkJLVy9wMnlsTnA5WjljM1dSOHpQaUEzdy9lVGduYzl2QU0zWDA1NVFY?=
 =?utf-8?B?WW8vVjBmQ0xMZHRoUzFSdGJjamxCMDBXbnN6N01MdmxjUW9ZTFYwMmFyaENn?=
 =?utf-8?B?NStzSzkwK0gvbFE0UERmQUNWSFRUR2s2WUh2U2VvbTFPdnduZ01PMW5iQkdv?=
 =?utf-8?B?SkpMYzdlU2ZaY2pKWGRvdVZmNVp3TDBHTFpHWHZaRUZvQjg3RDdQRU1QWW1U?=
 =?utf-8?B?ZDM2d0RNMjBKR1hiOEpaQU13V3c1UDF1aUJHYTdkUUt2eFVUZHh1cHROV3U4?=
 =?utf-8?B?STh3Wjg3Y1l1ckJSNk9SSXN2NTlRVDJFeHB4U05qdG9ieXF1akVkREtDVVd4?=
 =?utf-8?B?NFcyOThRR05HUjJSRWh4VFdQdkljOThzWE1aeFdBdkg1YjNsTWY1YmFoYVhK?=
 =?utf-8?B?N3RUL0pFWXZMSTFUQU5IZ1dwY0wvVGNoQitSSzRCTno5WTQ5SDlmTWx5STBL?=
 =?utf-8?B?UjVHZ092T1kzMHVaNE1ieUQ0R3pIeUVzLy9ycjl2Yjh2a0xKaThGdStMYmFF?=
 =?utf-8?B?K2xmS1QrNFFaWlFNbDZ4ZlQ1MHppdWV4SDRFSmxnL293ZCttY1h3VnRtRkxz?=
 =?utf-8?B?UDZTcVFKaDY2eEtrYWJud3dEWWhpaTV0WWdsYjN6NVRqNmhvWmNzR0dCUStE?=
 =?utf-8?B?ZGsraU02QU43ZVlqZHQ4cDJURjFqVjZRUnVKMzVIaVE1dnhmZ0dKZlFsWGFE?=
 =?utf-8?B?OGlZeVNJUHY4Y0R5YThRMjNOZDlrOHg3Z1dQeDdBcnFTdll0cjVWaGFpcm8r?=
 =?utf-8?B?Zmc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6bSo7e0NGh90EZMffF5M9+05NfM8aictKbG6eOXRmhi05rKZLkaV7eo8/nsT4aNwYDbQ/tlhGdT9z6ws5Cmkcnr68AXoURMinGjqgGLULRUTd+pJUI1Nu4v6S1R9CCuJXbomzqvHbgG2mDMQWCgS1+U5EsAirLOu//1fOvSD6cAH+iCtSedoK1RP20Pu2FsKfoadRtK1PeJaeYHFK8TP/wiN/e70Bps7ty13cSutVFYi/h+U+RkR2XVKKB3A5tQbJh/kCt7ef/5DYluJNp5dykfZ9NPOZyXZAMGpBnsbQrk3n4gjj/m+hYUNI68ajDkNQKLocAH7/XASSLNTBWmMT39tJjx0krdoAhEQRSvoEjjPPCDrOOAB5bkxDfPX2a2dPzczUtGqP3kX8T8F8R9H5/vmRZQA9lM3CpZ/7nzlfh7NnSuFsVkOFwpzD2sWF9+sufJKRWB/dVz9jGwyrFmilAx+PZ5/YFOcp/N9vhrhUmaySkZqkcmh5tV+qYT7E1AVr3rxL3Y+z1fvcys7wpS/WZlL3PwJOUOXE6Htq2zvjrdJX7NmrtZG5/fPpM2zJF2Wm4VTmA7X3CUPoP5ssXMe2osiBexB3kj4OLkayFrpr1xACT/AP3LE6lTeWHIBFBTM3QQKGZO+cJbbUljpSKZEWvvHBOL9AfI9lB3yo02Ca8dfy7N+ad/Z0Wrvxf6byXu/5y4lC97N0Yw8mvqTVfkA74p52cCsLUyNg5aQN6QNlWZmGN/LARqCHGCOqLl4UCqnakrzOvbXP9qsED/dWsXlMux936kfwkhVAXA9C7CgpFlUuNF0WquPNpDK9Occ7AjeJp0b6qcqwSCTs+apAO+gJu5YRHAuoBJCZDBhiBLQ1rs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9b9b9cb-95a9-4801-b469-08db2b9bcb31
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 12:40:33.4200
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iLdxyp20Qmy+sasTdrTghkOy0JyXWYSu9SKaVSu2MnpBK5xLtFZ322oBZWKaa3u2l1C5RY6gGI/yf+LEPqZuWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6315
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-22_21,2023-03-22_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 adultscore=0
 malwarescore=0 phishscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002
 definitions=main-2303230095
X-Proofpoint-GUID: zocY_xPhVrLgz84z9dOma6JNJb3oHguu
X-Proofpoint-ORIG-GUID: zocY_xPhVrLgz84z9dOma6JNJb3oHguu
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 23/03/2023 11:55, Wenchao Hao wrote:
> The original error injection mechanism was based on scsi_host which
> could not inject fault for a single SCSI device.
> 
> This patchset provides the ability to inject errors for a single
> SCSI device. Now we supports inject timeout errors, queuecommand
> errors, and hostbyte, driverbyte, statusbyte, and sense data for
> specific SCSI Command.

There is already a basic mechanism to generate errors - like timeouts - 
on "nth" command. Can you say why you want this new interface? What 
special scenarios are you trying to test/validate (which could not be 
achieved based on the current mechanism)?

With this series we would have 2x methods to inject errors, which is 
less than ideal, and they seem to possibly conflict as well, e.g. I set 
timeout for nth command via current interface and then use the new 
interface to set timeout for some other cadence. What behavior to expect 
...?

I'm not saying that I am a huge fan of the current inject mechanism, but 
at the very least you need to provide more justification for this series.

> 
> The first patch add an sysfs interface to add and inquiry single
> device's error injection info; the second patch defined how to remove
> an injection which has been added. The following 3 patches use the
> injection info and generate the related error type.
> 
> Wenchao Hao (5):
>    scsi:scsi_debug: Add sysfs interface to manage scsi devices' error
>      injection
>    scsi:scsi_debug: Define grammar to remove added error injection
>    scsi:scsi_debug: timeout command if the error is injected
>    scsi:scsi_debug: Return failed value if the error is injected
>    scsi:scsi_debug: set command's result and sense data if the error is
>      injected
> 
>   drivers/scsi/scsi_debug.c | 296 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 296 insertions(+)
>