Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230224-rust-ioctl-v3-1-3c5f7a6954b5@asahilina.net>
In-Reply-To: <20230224-rust-ioctl-v3-1-3c5f7a6954b5@asahilina.net>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Thu, 23 Mar 2023 14:05:24 +0100
Message-ID: <CANiq72nk+KSz6X0Lxg4kc_Bui=17XhboJ6q6j8gRg7Nsshziug@mail.gmail.com>
Subject: Re: [PATCH v3] rust: ioctl: Add ioctl number manipulation functions
To:     Asahi Lina <lina@asahilina.net>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        rust-for-linux@vger.kernel.org, asahi@lists.linux.dev,
        linux-arch@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 23, 2023 at 1:34=E2=80=AFPM Asahi Lina <lina@asahilina.net> wro=
te:
>
> Changes in v3:
> - Actually made the change intended in v2.
> - Link to v2: https://lore.kernel.org/r/20230224-rust-ioctl-v2-1-5325e76a=
92df@asahilina.net
>
> Changes in v2:
> - Changed from assert!() to build_assert!() (static_assert!() can't work
>   here)
> - Link to v1: https://lore.kernel.org/r/20230224-rust-ioctl-v1-1-5142d365=
a934@asahilina.net

It seems `#[inline(always)]` got added to a few of those, right? (The
addition looks fine to me, but just to understand if is it an omission
in the changelog, or an unintended change, or intended for another
reason).

Thanks!

Cheers,
Miguel