Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 06:53:23 -0700
From:   Bjorn Andersson <quic_bjorande@quicinc.com>
To:     Bhavya Kapoor <b-kapoor@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <dmitry.baryshkov@linaro.org>, <arnd@arndb.de>,
        <krzysztof.kozlowski@linaro.org>, <geert+renesas@glider.be>,
        <nfraprado@collabora.com>, <broonie@kernel.org>, <rafal@milecki.pl>
Subject: Re: [PATCH v2] arm64: defconfig: Enable CAN PHY transceiver driver
Message-ID: <20230323135323.GA309305@hu-bjorande-lv.qualcomm.com>
References: <20230323113324.361991-1-b-kapoor@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230323113324.361991-1-b-kapoor@ti.com>
Precedence: bulk

On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
> Enable CAN PHY transceiver driver to be built as a module.

Please use the commit message to describe why the driver should be
enabled. The patch and the subject already states clearly that the
driver is being enabled.

Regards,
Bjorn

> 
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> changelog v1->v2:
>  - changed position of config in the file
> 
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 7790ee42c68a..6e123de3a9cf 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
>  CONFIG_RESET_RZG2L_USBPHY_CTRL=y
>  CONFIG_RESET_TI_SCI=y
>  CONFIG_PHY_XGENE=y
> +CONFIG_PHY_CAN_TRANSCEIVER=m
>  CONFIG_PHY_SUN4I_USB=y
>  CONFIG_PHY_CADENCE_TORRENT=m
>  CONFIG_PHY_CADENCE_SIERRA=m
> -- 
> 2.34.1
>