Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chester Lin <clin@suse.com>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Chester Lin <clin@suse.com>, NXP S32 Linux Team <s32@nxp.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Radu Pirea <radu-nicolae.pirea@nxp.com>,
        =?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>,
        Matthias Brugger <mbrugger@suse.com>
Subject: [PATCH v3 1/6] pinctrl: s32g2: use of_device_get_match_data() to get device data
Date:   Thu, 23 Mar 2023 22:48:28 +0800
Message-Id: <20230323144833.28562-2-clin@suse.com>
In-Reply-To: <20230323144833.28562-1-clin@suse.com>
References: <20230323144833.28562-1-clin@suse.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4RjQ7KDid2LWk5YhdKCgFAaQ2+cGDHE8Kr/BvqV4FTg7GiCIB+mrKix/svDT?=
 =?us-ascii?Q?J942iB91JL9S9f+5cuxemFNFkDjad1Nnm9rbIWYGMOs8YHNuzRmW8PdwJK5D?=
 =?us-ascii?Q?ayjQr0prNHmO4SULBL6hQ0LWPtqBNBl22f7ID795FLGdJEJR8zNDfqQxumAX?=
 =?us-ascii?Q?31Exu1vdd3tGjI5E4UtgR/rS93CqPivjwOQv8xpW+s/YXNjT/eQPtNipeGXJ?=
 =?us-ascii?Q?772C8kbTEhN3kwX3A8wLysaUkJ5xk+fi4m8Z4WdGDYN+EfEns24e59zWqQ9Y?=
 =?us-ascii?Q?q5joAa8ZZ625+R+GV3fR//Wdco+jT2H5pm7BN8REruxjYb4aYGnhciT1JsnT?=
 =?us-ascii?Q?8qHAJQ8VJyQokM6cfpHIMLeAG936O2AKQ7G3krRE0LO0JGFGmpcwMA0cAEBi?=
 =?us-ascii?Q?lPNA9eo7ZofirDdrEEyIy+l7Iv/ynjZhXlCBuztoxPp740KC+ZkGWtrhVlfO?=
 =?us-ascii?Q?8/Nc8Ivw1TgkhJhB4+lSLTdk+DIXayb/9Ja5QD7K6Rx1BYaEXFftbb6B4qqd?=
 =?us-ascii?Q?l9hYhQhv9YVf5YVLCpLu7AwLfvjfVnZFuB+QIhdQN0muPnZf0up26J61LDeH?=
 =?us-ascii?Q?ICtDJeIscNkKvWrsa0JUFtTgr/NaXyitOZz1vkjIqRVuhxZEF/kLcnA71oyf?=
 =?us-ascii?Q?fEQX5oBCd9nCJaqdaZWmE5G+KF3K5YqqTM6aDnsuLo0JOL0fxs9BJxqAzZnY?=
 =?us-ascii?Q?0IPPRx/lM06y6INLXtsfIKrrL3FKMba1SUV1o8RGpUrzGtoujmDHqMOxvADo?=
 =?us-ascii?Q?wk8Am/GVl5EBQxPB49nsp9WssbjmCXD6Ej1Ye9x3OlhvNsgwUOVrMa7JxnGf?=
 =?us-ascii?Q?tRpyIy1sPtPhdOjkbyzEi8XBHNg5K4BN7H288pJ7LMWYpJ6N9Ex3+tvJXFwT?=
 =?us-ascii?Q?SRHlOn9RG6khK2jAsZ709iFQ4HE4osMNYN/isbmrLHGeUWZrDok58ttA56Za?=
 =?us-ascii?Q?vIpMPC8dkr2UeAgU1vTMFpv0ss3zxdxCcKpSyxj0LHF9714T/zEzy4SE6u5a?=
 =?us-ascii?Q?4MgshfWP5jibn7bOoNAqfOC4dbWE7OXecMHXjoQUtRmEtbuJ1xYnKIqCJ9zo?=
 =?us-ascii?Q?IAcBaj7Q5U5eEfXUHlvk6llWAnNv7fAxSh8O/hhSdP0uq96U/42FIVs2RZ09?=
 =?us-ascii?Q?Pg9eJTHUmfztz5ZXDflVrKwrC9mRJzRN+fKew0Yrz2iHv8xrxj4XliJGvSlj?=
 =?us-ascii?Q?nfY26GwyD8ammQx37BR2I044tR9me4SeDMWjR9bhV21P3SH4NvgFuOtbxozA?=
 =?us-ascii?Q?EmDqI/0WAhgGrkEYv4ik0xIHi/KFUicnnExdaA5k3UO34y/Mo8Q57yVhZd28?=
 =?us-ascii?Q?3XCOtCA1koqYcwCxb9Z0K1nr9VNVVjiAb469mCIl59W/mPcPaSWSheSuKjVH?=
 =?us-ascii?Q?JwnbjaZ6+YH8wCUaezHq8+6GwZAUpix5xgVI+v/IIeIH+cc/DhVo5Yl78vhh?=
 =?us-ascii?Q?DwI9+ZDwAG+l/V+QgMqP2GwEtimj12URQMMHoLMCcbxVL//cnXpa7LOJmSRr?=
 =?us-ascii?Q?AaYHEUDdhWuDMEyfXIl7bUuwNZ2z1nKN2bR2y7KGG/gTWiIwU9lwSxdR6Mdm?=
 =?us-ascii?Q?kU4x7lC0W7G8bT+SOlg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b46f1637-a2d0-4c7b-e7f1-08db2badbec5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 14:49:03.4597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NxeRMOcuXpz0qOKp467D9f/dJOf36to2VRqP8luVHyRJyh94qS2jOxeeIYm2mE0E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9625
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Choose of_device_get_match_data() instead of indirect reference via
of_match_device() so that the implementation can be more concise.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Chester Lin <clin@suse.com>
---
Changes in v3:
- Declare the struct var 'info' as const and remove unnecessary type casting.

 drivers/pinctrl/nxp/pinctrl-s32g2.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/nxp/pinctrl-s32g2.c b/drivers/pinctrl/nxp/pinctrl-s32g2.c
index 5028f4adc389..0e2d93681769 100644
--- a/drivers/pinctrl/nxp/pinctrl-s32g2.c
+++ b/drivers/pinctrl/nxp/pinctrl-s32g2.c
@@ -740,14 +740,11 @@ MODULE_DEVICE_TABLE(of, s32_pinctrl_of_match);
 
 static int s32g_pinctrl_probe(struct platform_device *pdev)
 {
-	const struct of_device_id *of_id =
-		of_match_device(s32_pinctrl_of_match, &pdev->dev);
+	const struct s32_pinctrl_soc_info *info;
 
-	if (!of_id)
-		return -ENODEV;
+	info = of_device_get_match_data(&pdev->dev);
 
-	return s32_pinctrl_probe
-			(pdev, (struct s32_pinctrl_soc_info *) of_id->data);
+	return s32_pinctrl_probe(pdev, info);
 }
 
 static const struct dev_pm_ops s32g_pinctrl_pm_ops = {
-- 
2.37.3