Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a2e0f7a-771f-5590-fc54-b9dbf059a925@linaro.org>
Date:   Thu, 23 Mar 2023 16:15:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] ASoC: dt-bindings: alc5632: Convert to dtschema
To:     Saalim Quadri <danascape@gmail.com>, lgirdwood@gmail.com,
        broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, daniel.baluta@nxp.com
Cc:     alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230323130511.16367-1-danascape@gmail.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230323130511.16367-1-danascape@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23/03/2023 14:05, Saalim Quadri wrote:
> Convert the ALC5632 audio codec bindings to DT schema.
> 
> Signed-off-by: Saalim Quadri <danascape@gmail.com>


Thank you for your patch. There is something to discuss/improve.


> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/realtek,alc5632.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ALC5632 audio CODEC
> +
> +description: |
> +  Pins on the device (for linking into audio routes):
> +      * SPK_OUTP
> +      * SPK_OUTN
> +      * HP_OUT_L
> +      * HP_OUT_R
> +      * AUX_OUT_P
> +      * AUX_OUT_N
> +      * LINE_IN_L
> +      * LINE_IN_R
> +      * PHONE_P
> +      * PHONE_N
> +      * MIC1_P
> +      * MIC1_N
> +      * MIC2_P
> +      * MIC2_N
> +      * MICBIAS1
> +      * DMICDAT
> +
> +maintainers:
> +  - Liam Girdwood <lgirdwood@gmail.com>

This should not be subsystem maintainer but someone related to the
device. It's maintainer or interested contributor. Unless that's the
case here?

> +
> +properties:
> +  compatible:
> +    const: realtek,alc5632
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  gpio-controller: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#gpio-cells'
> +  - gpio-controller
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        alc5632: alc5632@1a {

Node name: codec
and drop alc5632 label

> +            compatible = "realtek,alc5632";
> +            reg = <0x1a>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +        };
> +    };

Best regards,
Krzysztof