Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 11:27:06 -0400
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Tony Luck <tony.luck@intel.com>
Cc:     Borislav Petkov <bp@alien8.de>,
        Smita.KoralahalliChannabasappa@amd.com,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        x86@kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH v3 4/5] x86/mce: Move storm handling to core.
Message-ID: <ZBxvyqb5Mnt13341@yaz-khff.amd.com>
References: <ZBR+GMH0olGoDMGs@yaz-fattaah>
 <20230317172042.117201-1-tony.luck@intel.com>
 <20230317172042.117201-5-tony.luck@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230317172042.117201-5-tony.luck@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PqA7GAeOjKOzqmZ8co4CXN4gs8kUwvEP/h5BQVeufoNyRDqj/VoJemtGQA+/?=
 =?us-ascii?Q?vbhAHjpbCA0EnOJYhm5ZYJUR5uuwQCBu42f6qBoHyfTxyH74la2nR3KzNVx+?=
 =?us-ascii?Q?1llMY/iIQn1kQeXQUtTayPeGaSFeu1zJw3wCbtxeTlJYtTdI9fNVdE5juQYB?=
 =?us-ascii?Q?CSCUG54qahzFlOcaisRB7cMtzNULiWt/45yJv3/nv36ttlyOPITNotccghlI?=
 =?us-ascii?Q?ifNI8WctILlg2JJ0/rTzJ6qelOsdk+ClimGv7HpVAFuEWAzYcqBxuCflOM9O?=
 =?us-ascii?Q?RsfhHLnSSaxTjs/SzY1EHorhli3bM36zdvRb1oGU5c5FN57ytqqjZA/llB87?=
 =?us-ascii?Q?iT565JqEEE7GpeTr3aGb8gQbHzqGL8wV25VO8DGgq/0uRpKE2yYeLuNo2E97?=
 =?us-ascii?Q?oYSVyxVOYrcW+7RK8Da+Pbaa48XD+zti8v+Ylexk5IRigatrv1PfnoZ/0krX?=
 =?us-ascii?Q?DjqZWEtlWhZ3/bfPltWo4f6ZCoP6qUNiOGmU8DD62XqNGYG/RrMrQliLUc+/?=
 =?us-ascii?Q?70Ydz6Bhzwo4sDtmZvJtaGZrIMSBBkxdyYoJKi7zKY7CqyUz4hQCav8nVI6A?=
 =?us-ascii?Q?jR84fTWayx28rdkpYupxw5k86WduWbwmPwjuaNSIuEyBOji8ybtL6FzrY180?=
 =?us-ascii?Q?TxR1jHfBC6Ui7dsUq5chpQKKYg0Zy5Ya37KVUTMnCYfkXASerB7JPY+3tgRW?=
 =?us-ascii?Q?vEm/se6dTT/AcOqD0h+KlY1A2td1D0wMPUofq8hqsYKKSNnfwrX9LlAz1pHv?=
 =?us-ascii?Q?JXa+xVof1XfP/RWO2z4roRwPADcohArEVVibifh9JMeJ4t0FWY3pbgitAe9z?=
 =?us-ascii?Q?z7iMdatNH57Ey5wJ4qF3euEuBhBTQa7Fgu/u6U5XgXjk0K/9dsgJUCBk5lhr?=
 =?us-ascii?Q?93cz+Q55UnlgBkbVq/c3NN+v8/G7g0mTqmZOqr5AAy0ijRy6tlxqopkU43pY?=
 =?us-ascii?Q?G9QpeQrDKKOyTGiJs6NGbM9llFD7P6Anhs0qFAELDZN1SYpfUeCDYWBS2NIv?=
 =?us-ascii?Q?uBnnbwdKVYbi6VOIKki11dohjnMpqA1bDRn2zGwW579DR/CGVJNADOEFWfUR?=
 =?us-ascii?Q?XCGAx+xLRE7FCcqLXa6rc8iNdDaG0mJm3A1rGco5N8iMdeZZ43uvzaUcUycT?=
 =?us-ascii?Q?vbt/iOTET2CsZxSKuk/YiwKFaSN4HwmgR2GZO5FLLdkD8LBjYclKy2uNb4jy?=
 =?us-ascii?Q?s5jqhgDEWRxVHfwyXQLi015dc9aC1+PAsH0R+zkWrrVrPLtDQ6JgIpUINHGn?=
 =?us-ascii?Q?yX4SYMUTqiVMYMl52MJA2YQSArtzWNcGtMOb1Ak8jBk/46FRUK1CQZmlA/Vx?=
 =?us-ascii?Q?XxEehiT6rerEP0s8w+d4IKIspV80YeVfwxmWDSbaNXlo7VJBAtsI848/tc4N?=
 =?us-ascii?Q?UEB/L744CbzM2HeS1MXm3BI7HjRsNi13ax1pwhtfIiji8zX2mHCflsWzJa0m?=
 =?us-ascii?Q?uCGmLj35uqQfveaLVJCk+nUCoGVTaIfP0rVEqJlpeP2EoawSLNys/15q8TJb?=
 =?us-ascii?Q?NGN8y9EE5NtCSRI6wFOppLwGQ1GoG6fArCaL52J/yEPed+Op5Kt+PMks9Z4T?=
 =?us-ascii?Q?PZMqqigrRYJJe3qAS/7xCmgC6pNW+2HOTGiZaBcl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54ac2e2d-1079-47c2-6d8e-08db2bb31202
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 15:27:10.5283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ENzP9MWasziyYojsZly9KrC+yNnfpO37XqKESqeGDSVcG03hWxI016pTQ0tUucrMAs7JQ1UsCm+X34Mj0aFn+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8647
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 17, 2023 at 10:20:41AM -0700, Tony Luck wrote:
> From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> 
> AMD's storm handling for threshold interrupts is similar to Intel's CMCI
> storm handling. Hence, make the storm handling code common by moving to
> core and removing the vendor exclusivity.
> 
> On the contrary, setting different thresholds to reduce rate of interrupts
> in IA32_MCi_CTL2 register is kept Intel intact as the storm handling for
> AMD slightly differs where in it handles the storms by turning off the
> interrupts.
> 
> No functional changes.
> 
> [Tony: Same as Smita's original, plus changes rolled in from prior patches]
> 
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

Can this patch and the previous two be squashed together?

Like so?
 Patch 1: Remove old code.
 Patch 2: Add new common and Intel-specific code.
 Patch 3: Add AMD-specific code.

Thanks,
Yazen