Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3b3f6024-1ce2-9d8f-f5bf-e30993256fab@suse.com>
Date:   Thu, 23 Mar 2023 16:38:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()
Content-Language: en-US
To:     Dan Carpenter <error27@gmail.com>, Oliver Neukum <oneukum@suse.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        Mingxuan Xiang <mx_xiang@hust.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230323095311.1266655-1-mx_xiang@hust.edu.cn>
 <129aec21-4997-6b8d-5bd2-8e013f575208@gmail.com>
 <73fd29ce-3072-dfce-ebf0-3e197230fa94@suse.com>
 <201fba22-f537-4d1f-bfc4-e4dc931707bc@kili.mountain>
 <181feb34-c46d-cadb-ad20-46074a53b4c9@suse.com>
 <6677e2c6-b621-4c7e-9dd6-631a02ce5996@kili.mountain>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <6677e2c6-b621-4c7e-9dd6-631a02ce5996@kili.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVNnQ0Fub08rQktIQ0tOaGNMR0g4d0pEb2hQbWNxRmJuaUM3b2x5MC9qaU1T?=
 =?utf-8?B?dWFuN3QvMm5vWU04UFRITzBrZjhTdjA5WTJYRHowT1NhRjlZcjVWNnBaVVVs?=
 =?utf-8?B?LzlwTGVwY3IyZ1hmMnFLSDZHZjkvQ0c5ZWVrRHBiUU43bmxmZnZ3VHRCNERz?=
 =?utf-8?B?bUVRa2dSdDFEdTB6OXVZWEk4VlNVem1yWWRrdVlTeHlXWFRLTXRXVkFFSXR1?=
 =?utf-8?B?MXhYU1dUbWZiUEVBTXJvTGdtMm1HcjJDZkpwMU9XakJpWVVKTElZMkkyMldv?=
 =?utf-8?B?RHJGclhsSVJCWDNRVGhEZURyQnRsVmNzbVdhRitHNDJNZ1pPSFhMRXlxRE1l?=
 =?utf-8?B?U0FQZXhwbHlsWmFxY29nWitaR1c0dXVSejhqdGRtR09hSEp2aGdYQkZIUXZr?=
 =?utf-8?B?c2ttbHBPdmdUcGJFd242ajlHWGxCZy8zWTkvTDhxNHlFMkJvSWQ5eDBEa3lv?=
 =?utf-8?B?Rkx5ZDVZVTZtVy9lajZqd1VXVEhSUTI3RFBQYzlibC9zNEs3TDJFQkhXYmtw?=
 =?utf-8?B?Qm5mVXI1ZlF3bCtHUVFiazJ4eXVZOW13bTZodWRmRFMzQW52cnJGTHJOTjRu?=
 =?utf-8?B?dDNWME8zQnZ3MURiUnhXTUo1WlN3SGcwam45Uzg1VTlRL1lGUnRCcWJoV2hQ?=
 =?utf-8?B?TXFLclVMWVlOdTJSMXVZYUthRGY4NGthdlZHQUEzQkg2OVBoMUw1VTFIQ3VX?=
 =?utf-8?B?c0M2b2xSY3BXc3ZScmZnZ0tobkdRNnRkTUZGc3BVNnlYdGhpNURYeCs3Y2NM?=
 =?utf-8?B?R2ExWkh6WlpwUmJLN21NZ1BDaFBBcE9uQ0VKYVF5QW9wemorMG5yRjc0dVN6?=
 =?utf-8?B?WVZGOVQzNEc0b0VrdTBoeEo0KzVmTlpxa3pIS1N4WGRTU252aTd5ME04MEdo?=
 =?utf-8?B?VEkzZnJOTGg1aitnSVRKalZ5VHF2dzg1UkpTcDNJTHZoSGc3R0FmZGRZUVdt?=
 =?utf-8?B?WHIxMFhPR1dyR0xlbnlVTS9icWUxWnQ1V3FHZUtnRFdMUDNSY2NrZTZNQ1Zs?=
 =?utf-8?B?VjZBU3R4aUhxRlRDa0hMN2NmMS9vNzFIekFKbkdlbThKQnRJNUVGR0ZnTEJC?=
 =?utf-8?B?NEdQL3VDNUdreU11VVY2Tm55bTVHbGNEYitlMGtURENpTmN2akx3V3NkVjY4?=
 =?utf-8?B?d0NBMkI1UzJWUGJrN21mcWowZzlqT0hwRFZVNG92cHlIUDNnK3lITnJSMDdY?=
 =?utf-8?B?Qzc2SlgwNnFYTmtWUTBINGw2RjZxazlrdTA4ZkdyMHZBN3JmZ2N5RUdha1M1?=
 =?utf-8?B?NWhQbThOQmJpUUFleHZaTmpHMU1TYitCNEE1b2dGaWc5bGpSRlFBK2FtQTZR?=
 =?utf-8?B?aUMvRUN1ems1dmxIbFowVkR6cThqZU4waGw5RUVMbGw1bFEzcnFiOVJSWlBY?=
 =?utf-8?B?eUJrYzJ3dFF6VHZPaGIzdEJZRDBqNTdCZjBkTHBjRVlTemIvem54WWkrZ1dB?=
 =?utf-8?B?dEpGMTlBM0Y0ekdtVTJXckxmRk1tZVNvYVYvS01OSFR1UW92RGdTaENXZVlv?=
 =?utf-8?B?NWhwNXVqQjFleFV3ZjJkYUYvNldiVXl3QU9PdWltbzhHSnpheHJzZy8xOFlk?=
 =?utf-8?B?My9PMDBVMU9Nbzk1K1dGVlZva0JBcDhsTytya0ZEQ2l2TjA1NkFsK0lESWtx?=
 =?utf-8?B?VDhNRC9SKzY4U3BjVkZYSHNtZUJrYWVBVGszd0JuSzNjbUNsSkV2K3E2QnlE?=
 =?utf-8?B?NXBhMVhyR1ZDc3d6dDFLcmRUNm9Va21XcTRCZlhham9JUEhRTnE2a2xtUC9j?=
 =?utf-8?B?N1FTMGRpZzR2dm8vY2NrOVJwSGh0TU1XSjV0VGZIT2twVUR0Y3ZlbXVJaDVE?=
 =?utf-8?B?OHVLNXU1T240TkQ1cW9mcmF5aUZwa2VCeUlFa0Y1ODY1SEJ6SlFWWWZWcEg2?=
 =?utf-8?B?TlFlamhNb0kzSkJFcU5rVHR2TzhkcjNLOEFBUjgrMm5ZZ1E5K2JqUHI3WFB2?=
 =?utf-8?B?c0dpeVVCSi9pbUJVZG0yTmpTeVJja05iMUtDd0xKQlBuSmpZVkR6Ym9wdXNl?=
 =?utf-8?B?OFA4K0k0Wk5Senk0S3Q1YmdaenNmRmpkWncySkcxNFVFdEp5LzNlME5hcjMz?=
 =?utf-8?B?ajU1VE1WTlFZU1k2MENPRHVINHVab0t6VDNNcG1WM0ZQRzVNZHpoOHQxSjNa?=
 =?utf-8?B?WDV0ZUk3cVp1b0h6dlBPaUpuY0JqK3lKVEtJSFZPVTBCeW5tT3puSk9LeEtO?=
 =?utf-8?Q?c+PnfZZVaJISyRtMoEroyiRL/CX5q6DEDsWiXOUfDi9e?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f67ec1f7-1dc4-4108-229b-08db2bb4a609
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 15:38:28.4031
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cAODvQ8Csbo0bXELF6ZqbzEJMHoPVMvYHHaQ12Zn0OgZo4AFRwaYmCKnsbWhl1nrwvNkj2W4smW6E4CkEU06qQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9636
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 23.03.23 15:06, Dan Carpenter wrote:

>> irq != 0
> 
> You've reversed this if statement in your head.  It says that if
> platform_get_irq() returns zero, then return -EINVAL.
> 

Argh. You are right.

	Sorry
		Oliver