Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <73f7918d-9893-7895-3cee-fef0202d5ea6@oracle.com>
Date:   Thu, 23 Mar 2023 10:40:05 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 1/1] vhost_task: Fix vhost_task_create return value
Content-Language: en-US
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        Christian Brauner <brauner@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, sgarzare@redhat.com,
        jasowang@redhat.com, stefanha@redhat.com,
        syzbot+6b27b2d2aba1c80cc13b@syzkaller.appspotmail.com
References: <20230322185605.1307-1-michael.christie@oracle.com>
 <20230323033557-mutt-send-email-mst@kernel.org>
 <20230323104445.qidusxeruimeawy6@wittgenstein>
 <20230323073918-mutt-send-email-mst@kernel.org>
 <20230323115049.vsrnufcaqstpxik3@wittgenstein>
 <20230323084648-mutt-send-email-mst@kernel.org>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20230323084648-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkRKK2xBdWlRVzFwL2hWY2t0UW9oaFc1Z0R2QTRUcjlGSWFmazN1N0l1WVB2?=
 =?utf-8?B?YnAxLyt6ay96MTlmNnFpZy9IZGFmeEphRjdyb2o4OU4rRDlXT3haZWRxY29h?=
 =?utf-8?B?dkg1T1NhUzNjWTRNc1RiejVDK1VrM0lXK0ZOQWFobmFua1BpUnZCdEhZa05y?=
 =?utf-8?B?aTlLZG9qd084SWdDVHJyM2ROdEROY2NlNllRdC9BY3pyVGtnYkVhWnJKVnZs?=
 =?utf-8?B?QUlJTHBhVVp4RXhRQk1kVUhSMUxhWXRFZzduMWh4dkRyQ1o1NUdhZjl4MGlE?=
 =?utf-8?B?SngyQVhCR0NNUndMSWV4d242RWsySUtQQWhrNDFkR0p4N3d5dWlTYW5ONk1o?=
 =?utf-8?B?elU5bUJ6RXZZTXNCanYrTHZmeHpvWncrT0swdEZwdWFBci9DYTlsampQazEr?=
 =?utf-8?B?aFJ1WGVzL0IraitpRlJxcFhXUkwydGdGc2tjVkFteWNXRUIvRnBTNE9wQWsw?=
 =?utf-8?B?b2dHclREV2ZaUFZLVzZiVG1VcVFFZXl4RnVycGlQNVBvZFhUQlgwMHZWWXlw?=
 =?utf-8?B?cWMyRWxUTzFXTjhpMThPcFJSZC80YnZtK0R5TUFONDRPTFRqN1B5YlYwckRG?=
 =?utf-8?B?NC9Ea1lxOWF0blZXeVRuMHJXM21XWkxwSmkyQ3F4MEJFRDhBbVR3THQ0MHFR?=
 =?utf-8?B?bGZCS3laRmRmS1lqbkVJY0lTQURGdjRoMCtLS0RIMDZYaTJETjU5R2V1Smgr?=
 =?utf-8?B?UFREWTBRNlFaMkh3Y05FdlhocDVzNVJScTNuVmxneUs0QXQ2WHFFc1pDQzBu?=
 =?utf-8?B?c0lYenJYSmdVdEl4aExGV0xHOE9VK3A2R1FJa3l2MDV4YjYySGU0MVRJaFR5?=
 =?utf-8?B?SVM2SVVIMDlZZzBOVGVoN09xL0dUVy9zQWNPekp1YW1iT1gyZFJjT3lSckc4?=
 =?utf-8?B?TUgrWkxsUi9sVG9CaStkZnJhb3JyeVhFaW5aYjZtNEZoWVdrWmZpM1o2V2lN?=
 =?utf-8?B?cG9wcFdUazBNWlNGemlHQll3MlQvV3VveGYyOGxRM1lub1JNckVQZnl4RFZS?=
 =?utf-8?B?VmxKa3hkYkVXYzdEQzBuWkFNcGNPMkZUY3VsRDlrR3BNeE12ZXBiUmNQaHJl?=
 =?utf-8?B?ZnMwcFR1SUhNeDljT3lXRWpqSHpqZTZmNHB6REI3QThZWWJlVERkd3gwa1hq?=
 =?utf-8?B?MkN0MEF3aGQ4bzhGcDh0OE1SSmswa1JjVmxuSjVFL3RTR3NnK3c1K1gzWjhl?=
 =?utf-8?B?eG5aa1VyTnd1Z0JpS1JjbENKeVdCRFdjakYyaE5laFYxdFlOankvdGVaWkRC?=
 =?utf-8?B?RERyQXNpd0ZsZy9QMzBHd21pVlVuOTFadGZIanhSZjlvODZrTHVxNElYUTNp?=
 =?utf-8?B?TVc2OEU4TzcrV1JIOUtna092SHlZUlZVT1UvYmhDQXlldkFYN3U3dmRzYWx2?=
 =?utf-8?B?bWx5VjhjcTFGMEVyUkdpOWRhQ0gyYlBsNTRaU0pKTmZkR3VidmF4Wnl5Tk1J?=
 =?utf-8?B?MzArVmt1VTRabVlzZ3Y5Z0l5dDRGUnM1ZWZVMndCQzJUSmJ1NjQ1OVNNTXo3?=
 =?utf-8?B?MmVSMVJMQ01hK1lyZXZtYXpsMmZLYlEvMUhXYUgyMEpjYUQ2aEdaNWxvTzc3?=
 =?utf-8?B?ejUyTktONjkzczFtYmZHNkFKZGZLNWdVdDEyNGhHZEZJQUFvRmhOMjkxc2xr?=
 =?utf-8?B?UlFmbTVSZDgvTlNaT2RJVW95YmNVT1Yvdyt1Zk51dFpBTk5ROXc5bUZtUUti?=
 =?utf-8?B?Y082SE1sRUhIOFpOZHlIZGZ3bmxGZ01qUFNDWXV5WnpjRmNTK0F6TVhQQXJN?=
 =?utf-8?B?YnYrRWYxWlZ1Rkp4LzBhOFkvSGVFeWh4bHJ0eUNvd3RDejI4aDZRaVBKVDNZ?=
 =?utf-8?B?S2Vnc1lBc3EyUitORFJkVDRaNUR2R25FZ1VDL0oyTytnMEpGbXdqcE1TMnFt?=
 =?utf-8?B?TndBam12RE9MSERWQlhXVlZwS2xMSENxL1VBU01LamJkbndRczYxL3lQMGtk?=
 =?utf-8?B?d29BUS9VNkU3QnJiNUwvY0NFVlpMNGlCZDlrOWxCYUhHeVZrbGVzZ08wMkFC?=
 =?utf-8?B?UG4yU1ArbEZKYTE4WGhHVnl3TmRjWXNnTHlEZlpHVmxLODdsY05BR0gzelhu?=
 =?utf-8?B?SFBMSEhFVTYwalZKdktkOXNIL3ltb3JVZTZtVklFbUtTWHE0cFlZd1BOWW1F?=
 =?utf-8?B?RG1FNGV0ZUt6V0VCMW91dUVoOU1xclRDT2EzNHp2S2ttdUxteSt1NnA0ZktG?=
 =?utf-8?B?M0E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ejhmdlJsWGxHVFFkZms1NG1XYVA5OUpGT3dLd1FYYUp0RnJBUUZTNmRHTDQz?=
 =?utf-8?B?UXZ3RGhZSUlyWStSVzhmTk54ZFpVWGxyMWJqdnFRcTVFbHczTHpubGNxdHVH?=
 =?utf-8?B?SFBzcEUzMjBkODEyOGo3b0ZoYlpUS0c5QUE5bEFBUFh5MEk0Y3prTlIzNzVN?=
 =?utf-8?B?a0FyV1JnQVZtZnhicmg1SVQxSGRhMlkxL2ZoblVjWVNkUTJOZm1iSTdUS1BT?=
 =?utf-8?B?R3phMEpNQmRMQTAxMzhMZVFsUURMcXkraVZmTWEyZVFDN1NEdy9TRHJuSHlU?=
 =?utf-8?B?K1Y0eXp1TDBBWFFScFpzeDgrcUFHZkgvMTFkbm84RjBlNEZKMitLMUN4RGNH?=
 =?utf-8?B?S3JxODNOMEJpb05aSjNZb0tMaHlNKzYxMjlBTGhGejRhTWcyQUgrbjdEeXJt?=
 =?utf-8?B?elVNNjAzNGdkbWxQZUg5YWhzc21lT1JZb2dsRlpsM2QzQlRnWUxHcnhLcjNX?=
 =?utf-8?B?SG84S1c5L2N4a0hVTWIxSmpNZU5ObXUyV0FCTG83QzFGUXZPZjA3RzhxdXhE?=
 =?utf-8?B?OGRmR2ZkRW5NaDg4M2o0VkxGeGhZa0w5dytxVFlvQnhGeW5YZC9yK1hkb2tr?=
 =?utf-8?B?ek85cDdTYnlXL3BVOHpxZGlES1NEZ3hCTXZCRnYrYjB0R0xsRDE5YzlwVS83?=
 =?utf-8?B?SHdPK211SjB5U0hLVmRKdVpaVlFFMjZabVJOQnpFVXNwQURUbC9VTzlmQ3My?=
 =?utf-8?B?N0Ixang2MWhPRWVCZzBPTzl2dVVWeEpPQXhxVFN2NnZTclE1NFhackdVajZq?=
 =?utf-8?B?S3J6SnI0RzZ6Yk5oQjNTdWFUVk42cWR4dEhCazdPY09VSWhPd2UwM3ZwRGdy?=
 =?utf-8?B?VVJwZE9LL2FuTFg3Z0t4a2tQWGx6U3dwakhYeGM5bTV3RGFlWHVyL3FxZk9h?=
 =?utf-8?B?ZWhHc0FSZGYzVVFPaTkwU0ZIc0RtOUVyandzYnZTQ05nK2xqZkkwVzlrVm1z?=
 =?utf-8?B?Y1BBcUVhZEJkTEdBdXJXNE9VbTB5VXR0QjFvUUU5K1d5VEZHNWhwdkZuVXd4?=
 =?utf-8?B?K0I1WGRtZWJNQmFsN2pkVlBEbzBnOWF1a3JUOHp3bk8rRmZvMENhSHphSmhO?=
 =?utf-8?B?SkMxQXIzYW90eUVPRVpwM2c1WmNlMGlRZUQweU5yVENkcUprcXR2M2c2cUxn?=
 =?utf-8?B?UktOU3A3RVNIUTNLWENSSDVMTUtScUkzaG4xczFlY29ydjR1ZWY3VjhkcmVV?=
 =?utf-8?B?dnFqaEdoRDRwSldVd0hGNjVMSlB5UEpHdW5nSEwrcTNXWlFBekJoR0RuOXJB?=
 =?utf-8?B?NGVQbGxNS3ZtT2JqSmpWSHlid2RBMWhjQ0hORWdTbGFQWUNsZz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b577ea87-67b7-41e9-5eb8-08db2bb4e083
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 15:40:06.5276
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KDZAIH4rtZr5Bf3uE4h4GI+ucdVV8gU5ioLFMNQBw731Yn8NX8tr2G7t9b9qUyTO3pllf0lm2LYpAX0HICOk0uvqSAPVXcF6ROM5JijBD+A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6715
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-22_21,2023-03-23_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303150002 definitions=main-2303230114
X-Proofpoint-ORIG-GUID: 7vw9-NTiZ6Hg87D7n_fBUCk0hMJok1Xd
X-Proofpoint-GUID: 7vw9-NTiZ6Hg87D7n_fBUCk0hMJok1Xd
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/23/23 7:47 AM, Michael S. Tsirkin wrote:
> On Thu, Mar 23, 2023 at 12:50:49PM +0100, Christian Brauner wrote:
>> On Thu, Mar 23, 2023 at 07:43:04AM -0400, Michael S. Tsirkin wrote:
>>> On Thu, Mar 23, 2023 at 11:44:45AM +0100, Christian Brauner wrote:
>>>> On Thu, Mar 23, 2023 at 03:37:19AM -0400, Michael S. Tsirkin wrote:
>>>>> On Wed, Mar 22, 2023 at 01:56:05PM -0500, Mike Christie wrote:
>>>>>> vhost_task_create is supposed to return the vhost_task or NULL on
>>>>>> failure. This fixes it to return the correct value when the allocation
>>>>>> of the struct fails.
>>>>>>
>>>>>> Fixes: 77feab3c4156 ("vhost_task: Allow vhost layer to use copy_process") # mainline only
>>>>>> Reported-by: syzbot+6b27b2d2aba1c80cc13b@syzkaller.appspotmail.com
>>>>>> Signed-off-by: Mike Christie <michael.christie@oracle.com>
>>>>>
>>>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>>>>
>>>>> The affected patch is not upstream yet, right?
>>>>> I don't know if the tree in question allows rebases - linux-next
>>>>> does. So ideally it would be squashed to avoid issues during bisect.
>>>>> Still it's error path so I guess not a tragedy even without squashing.
>>>>
>>>> I tend to not rebase once stuff has been in linux-next but I make
>>>> exceptions as long as it's before -rc4. For now I've put the patch on
>>>> top (see the other mail I sent) but if it's really important I can
>>>> squash it after the weekend (I'll be mostly afk until then.).
>>>
>>> Hard to say how important, but I'd prefer that, yes.
>>
>> Ok, fold the fixup into
>>
>> e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process
>>
>> the series is now at:
>>
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git
>> branch: kernel.user_worker
>>
>> 1a5f8090c6de vhost: move worker thread fields to new struct
>> e297cd54b3f8 vhost_task: Allow vhost layer to use copy_process
>> 89c8e98d8cfb fork: allow kernel code to call copy_process
>> 094717586bf7 fork: Add kernel_clone_args flag to ignore signals
>> 11f3f500ec8a fork: add kernel_clone_args flag to not dup/clone files
>> 54e6842d0775 fork/vm: Move common PF_IO_WORKER behavior to new flag
>> c81cc5819faf kernel: Make io_thread and kthread bit fields
>> 73e0c116594d kthread: Pass in the thread's name during creation
>> cf587db2ee02 kernel: Allow a kernel thread's name to be set in copy_process
>> e0a98139c162 csky: Remove kernel_thread declaration
> 
> Thanks a lot! Mike could you give it a spin to make sure all is well?

Yeah, I'll review and retest over the weekend. If I hit any issues
I'll let you guys know by monday.