Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 1/1] mcb: Remove requesting memory region to avoid memory
 overlapping
To:     =?UTF-8?Q?Rodr=c3=adguez_Barbarin=2c_Jos=c3=a9_Javier?= 
        <JoseJavier.Rodriguez@duagon.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     =?UTF-8?B?U2FuanXDoW4gR2FyY8OtYSwgSm9yZ2U=?= 
        <Jorge.SanjuanGarcia@duagon.com>, "mmoese@suse.de" <mmoese@suse.de>
References: <20230323124900.898035-1-josejavier.rodriguez@duagon.com>
 <20230323124900.898035-2-josejavier.rodriguez@duagon.com>
 <c08407ec-8553-87ca-85d5-1988b8f9172b@kernel.org>
 <121decd1d4f8c4aa469636756557fce02b245ddc.camel@duagon.com>
From:   Johannes Thumshirn <jth@kernel.org>
Message-ID: <9851e06c-8430-0303-f5c2-ebcb5e38996b@kernel.org>
Date:   Thu, 23 Mar 2023 16:53:12 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <121decd1d4f8c4aa469636756557fce02b245ddc.camel@duagon.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 23.03.23 16:11, Rodríguez Barbarin, José Javier wrote:
> One thing we can do is modify the chameleon_parse_cells prototype to
> return the actual "chameleon table" size instead of the number of cells
> which can have an undetermined size. At the moment, the return value is
> only used for error checking but the number of cells is never used.
>
> After that, we can check the actual "chameleon table" size and
> drop/reallocate if needed.
Hi Javier,

Yeah that sounds reasonable. mcb_bus_add_devices() calls device_attach()
for the respective IP cores, so they individual driver's ->probe() function
shouldn't be called before mcb_bus_add_devices(). So you could shrink
the resource between chameleon_parse_cells() and mcb_add_devices().

Btw, mcb-lpc.c needs the same fix as well.

Byte,
    Johannes