Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 17:08:09 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/9] net: vlan: don't adjust MAC header in
 __vlan_insert_inner_tag() unless set
Message-ID: <ZBx5ac4cfv/tmJ2C@corigine.com>
References: <20230322233823.1806736-1-vladimir.oltean@nxp.com>
 <20230322233823.1806736-2-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322233823.1806736-2-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KYPfURrQeLNzY10bqz1bcKmDRqdyCXBC/psrQQGhIF0xYyyzw6dk/6xXY1KP?=
 =?us-ascii?Q?Ha2cTdqobKLsqDmOujSPXzoRX1yGeCN7qylTND4pg3oRCFPdJ3xaUuo6r9x8?=
 =?us-ascii?Q?GRwqtvhapZqnOZjKqpbfoT1f16+76xnJphoXfPAf5SIy49AYWco+zpJmK8XK?=
 =?us-ascii?Q?0fuE7GI4h9SKz669E6h8+XSUln7Hsk9mAyj+W4xNygFUrYPul8G4th/UA6xi?=
 =?us-ascii?Q?bl1LRtojP5INh28ut+vYjRTc4Tz6KcX64OMPcsE3Vh2tMCerY7ZrevFAoF/4?=
 =?us-ascii?Q?wrA8dwcW9vKIfmsz1ClGO2xSHv6kJNlHGHkQYFDiK+qi1taQBIpiWXj8xxf+?=
 =?us-ascii?Q?f3I56FevTPW491RVRAVGDqUjCZI2wRHE1aMLcOQsUER98tGESIO4dD/Cu0gN?=
 =?us-ascii?Q?d+y1DBYuE9vZ3DTxF9PzQHd4weUxSGyDlkjm70AH8aTaKw0Yr9CPTOUgLsPk?=
 =?us-ascii?Q?50U3XztLhfqhAnAFYFgcmkPhZ+/SCRYkvPsAdpHsqUFqrwFDZEDNAWJnwgF8?=
 =?us-ascii?Q?PmZX/HKWEB+kC6+o/COa8GMgJfcdUrMqK9lkZcckAI0fJoWqsEc/z+lip+g1?=
 =?us-ascii?Q?TanLLv6ej7pqOkmXQi6aw8M8g9Va/fvsbTkHfTXyBTt9b10gD/zQtoojzFUO?=
 =?us-ascii?Q?OrmGpTotbKigMSJQ+Y8LTqn/AUluNIHR4O6cY2OyLfV6lCcSrY3xmVaUN81t?=
 =?us-ascii?Q?Zh8rTykYnpBAVdhTYCsVQxJCNBpynil3iiRuIpSgC/9iLqs9RfidIM1FetZC?=
 =?us-ascii?Q?Hs/7m7J23waznw4T0dFQrUENTIEPEfuXzZOi6hCBy8/pJd/UwoI8sw2nKQwO?=
 =?us-ascii?Q?6NYWsRwqto8pyhFe6TOy1SPcjYgfjKij58CRLXj7KqLl3/XbRrSAWBDzALpW?=
 =?us-ascii?Q?hWv4aO4FX8CeOI8urGc9b+noMFeuAUf+YowRL+MBPC3I8lKPhPiygRii1W9v?=
 =?us-ascii?Q?m5cU2YeVuPa9CIpa5ETkUmZbin4ovDE5viixsygZh3894tCCOTNLs08LUmb0?=
 =?us-ascii?Q?ExJSyornkFn3WIGgwizU5n9nMUByURfrQPKIbvxdK9pzqKgIi4khzbmmKHeV?=
 =?us-ascii?Q?eVecWhknMeqxQOZByBiF7ev1xWUVt8vt6kILevm3o/mtoq+lbehuvXJD9EPw?=
 =?us-ascii?Q?r+Vg1oMpptV1oXA5u2yNRf0IrA8Sph6OTAVQPp9VgwfbNEUGxyL/+ZUp9A+l?=
 =?us-ascii?Q?TFumcnla8F99hMq1JSqOIooFpA6+zjrUt06WB2N2I1kJ+nHLGBLyexGbnadC?=
 =?us-ascii?Q?lddt/lNkt/MfBJrbDSxYU7fn+JYhJ3+6ogC2ApF++wSI5bzkIY68+uyl4HvO?=
 =?us-ascii?Q?/ltL47+2VUOFe/WziTfptP+Xm29Z3ZPfpW1Czb5PBtyEHUtZhBEYs34j272T?=
 =?us-ascii?Q?RNNcys7R7A7qHhVpLEavfYWYd9tCuvUkgRd4xztc+BITeeVx4R1pqzDIuugg?=
 =?us-ascii?Q?cKDPIHRVrLV0jDNgwYDT2tRV5AGxVf/taNVah/GZ4y32WuapQ++DTAcH7VTQ?=
 =?us-ascii?Q?CT+u0E+AxAAsj83CWatnZpB9ZU8vJlrlaFVG6fq6hIwuT8Lor8Kqvt7B6e0n?=
 =?us-ascii?Q?TaLQU1YnKE4azx4b+RQtTaXPef41aEm0VqrKMWdEtJgWXE7HBDZrr6nqvOLZ?=
 =?us-ascii?Q?jz+6wZyWd7IDGmO5eEBT/gOcpVGdqP5WUWX7CV5eOsg+WMT+/cwUih+DYZRx?=
 =?us-ascii?Q?jnZq+Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccbc005c-7eb7-4be9-b5c9-08db2bb8cfd9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 16:08:16.6528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: erQuoGw4TC5Wmu3Go2h+mW6Y8SPlyXGxKQwt8OdiwCTFYPLxluP9HapGZC7AHcxYeMK1JcZesjInC/wJSSBT0xPlrv26PZv+zFg/rNDP0LY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4795
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 01:38:15AM +0200, Vladimir Oltean wrote:
> This is a preparatory change for the deletion of skb_reset_mac_header(skb)
> from __dev_queue_xmit(). After that deletion, skb_mac_header(skb) will
> no longer be set in TX paths, from which __vlan_insert_inner_tag() can
> still be called (perhaps indirectly).
> 
> If we don't make this change, then an unset MAC header (equal to ~0U)
> will become set after the adjustment with VLAN_HLEN.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>