Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 17:08:52 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/9] net: vlan: introduce skb_vlan_eth_hdr()
Message-ID: <ZBx5lP9C+JHO/N05@corigine.com>
References: <20230322233823.1806736-1-vladimir.oltean@nxp.com>
 <20230322233823.1806736-3-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322233823.1806736-3-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WWS0XIAT0FscC4jj5qoyd+4CvFtS5r7PLzctd9Z3n0fvZht9w5y0pMAq+Hqg?=
 =?us-ascii?Q?fxMgYwFY5TSh5zg+MyfSoWQKPgGJqOnYAWHLRsgDkA0rkxnaRlL3j9GIZRL/?=
 =?us-ascii?Q?lCHJBrdilqUHLFHllOJkThuMaf7pWoaDvvojWRGrcidQ/VzZTgWNw2QoW9Hm?=
 =?us-ascii?Q?W8eEAPeWUZWIiGCfFfnQvVKeAZoZoBC3yn9Sd5TxJAl0kpSL/6izX+NAizXT?=
 =?us-ascii?Q?RV2jm5520Ox8/w/giNYyUZIrpThHxhjsuEDNZGC9KG/wdDcKJiiIoekx7h0Y?=
 =?us-ascii?Q?PMPFIH1WGNqqXe5izv0sIcgSAHidJp7blsoLYUMv4oMW2G6E+UHUQzTJ5R/H?=
 =?us-ascii?Q?yujTGGAIBniudX9xkxs1PoNRkiExWPX7IUD+7ywqA/42E4vI6EhPDJNFhwyk?=
 =?us-ascii?Q?dDmLtIqkUVTtcG+b7UcWqmnJoAqx0u1uT6ZItNNGBdM+b+PADYrY02kEbzZq?=
 =?us-ascii?Q?qM7JzKYYFzzjHlLyuL/kkedJX6IevX5cdpm8ca5lRH8ZWARJfwgaeirR5PWS?=
 =?us-ascii?Q?cqspJ1A6t6pF/Opm+KFPk6yUbYA8CMRWgam4tWxkOI6DKaUzQ04wN9UF82Bf?=
 =?us-ascii?Q?Z9etPrzlCO32dN+UXiG5wMiRXhvr4dSqEfTZsFPmJPrzVvpgNovRPEC34hM8?=
 =?us-ascii?Q?8THA5sokAANxGZsIuuDo6ol17bVBw173p0iCkspJ8fwV8KG8cISrGufiETpj?=
 =?us-ascii?Q?OJJce1qTxNGGd8vMUrX1xQqjPje6XakcNaqc371c90ucCL6CAasspdYM5Oge?=
 =?us-ascii?Q?ndNNRxqisxvI9LBlMxxsK8tem1Q2BHTucVciZbkQRtVyOKmd2+f3RtrGrh+u?=
 =?us-ascii?Q?iPqSnDs2bB6EluiDQM2p7zwTluwvnL5BmHL8U0w0bAZ78/cFpj0I5pxrNsiR?=
 =?us-ascii?Q?Y16E+LHcOMNEvA0ybvWS9n7EpCxyCVnClRfcaHFh/LYoMuNDUVwTJaPafPtw?=
 =?us-ascii?Q?JZvFGeiT7Qen/YWNf1y4CF/RKq+tKAkYva+KfbGB6gLN+IV8gSZkGuXVx/kc?=
 =?us-ascii?Q?3vGX/NrfY5EM4k5+U2hR+rSxj04Vn48byDIE0j7sNiz9vxzy8mj3VsfcHUzt?=
 =?us-ascii?Q?9/aPJUZVZS4SWYyqBsRgCwONukf6KAG1BG71mnYAJ8PNBF9cCHYdI5L6cTIo?=
 =?us-ascii?Q?FsyUB7JBGaPqxETfK+mC16k5KgZxxwTfH4zzgPjuN6jFkXpjXIPkq4H9wiy3?=
 =?us-ascii?Q?DBRuAZRT5OH44wtm73m4YG5yw9GIxCfqHJjMzDSQsxaUnHzjsWOz/8zJ/1dz?=
 =?us-ascii?Q?SV3Ra+y1PYl4OJ2xvSo7toNzJEvUhMDrVg4LCWHzRBja6EdxIKrwgPX5K7ft?=
 =?us-ascii?Q?wBbwqzOvxVREBjVnhjzK0SVJBLG1Q49+t8emCl5owXtC0k9iTnPAEbCtOhty?=
 =?us-ascii?Q?kIK+jViagEAEkti0YUbzFuwKclJwwvW4FRY1wpOjZEl1FdNNDJfQY3VMUzkm?=
 =?us-ascii?Q?LL5q1VnY7LahG0PmtUHmtEss1ZRuxhnmFquOOcV7h4OaMUNwC1o3UkV7/r1H?=
 =?us-ascii?Q?Or2zLIXUMNZMkLtjbzBtNnHtFxQBcjgu1cAwVc+wFnjuBXlN+LHjm2UuPni1?=
 =?us-ascii?Q?5morG9wTH6fybK+JUQ4naW+tQ8UNAymDg7FR4Q5rB16c7g5/q4NRHecJcrJ+?=
 =?us-ascii?Q?UF4Nk2G2PcAGqabD9gwMtNpktH/YJpEFKkbVEG0KVPwoyKC9TGFNk7ks0OXA?=
 =?us-ascii?Q?Cp/Naw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e4da351-8c77-4e6a-9179-08db2bb8e8e1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 16:08:58.6630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: edtIRioT1YNjTacyYCFKySStBnuOo2B5vS1qn2l7FB8nkBPFzKPlhmL12FwJRloDIavHp8vp0evrFhv/ZFZ+1tmph32Rl59M6bMNRgC+3Qs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4654
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 01:38:16AM +0200, Vladimir Oltean wrote:
> Similar to skb_eth_hdr() introduced in commit 96cc4b69581d ("macvlan: do
> not assume mac_header is set in macvlan_broadcast()"), let's introduce a
> skb_vlan_eth_hdr() helper which can be used in TX-only code paths to get
> to the VLAN header based on skb->data rather than based on the
> skb_mac_header(skb).
> 
> We also consolidate the drivers that dereference skb->data to go through
> this helper.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>