Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 17:09:12 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/9] net: dpaa: avoid one skb_reset_mac_header()
 in dpaa_enable_tx_csum()
Message-ID: <ZBx5qH2wb82EcO1W@corigine.com>
References: <20230322233823.1806736-1-vladimir.oltean@nxp.com>
 <20230322233823.1806736-4-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322233823.1806736-4-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vFfiVoJFSbk8eB2agFv6XE7qk1Ob4veJNIRhg2mEfUGr2euyckn1ZxRTTSWT?=
 =?us-ascii?Q?F2fdzZARo6VzGZ4fUxF5Kmkzwmi4aDbXLYXQ0DWXe9vaeo/oCXQM4fFF6lPl?=
 =?us-ascii?Q?WfL46RTX+3dTihWXpWGtvSDoxUoRsJwjozoj7yQaQ+hlpfYOjTC8VuzyI6zB?=
 =?us-ascii?Q?ZQQVie7M/jW886daP1+6GSPwAp1jaZcHwGdV9+Wi0i1GtksoteM4fVr/gMmS?=
 =?us-ascii?Q?iSr1JHIJzrIeBm2iUcTGazdRriOo1ii1gNIgEegEbINBm8Z1AvnHnQ3IN7/d?=
 =?us-ascii?Q?YXHN2rWNQYL6aNTQi/xaIP0075AySMutpSfI+dmzyvVumlTqOdBej3q4i4Ym?=
 =?us-ascii?Q?+OmunkutXJD1419J1GRKTpAPLJYIkBndB54eYBimJKrokeC777R++3nmBTvJ?=
 =?us-ascii?Q?g4PfPnNzccrlatXhK7RdN/6CazGM9/V4eGpYAqCkhuTiVdmtXOFXTlH+37uS?=
 =?us-ascii?Q?WqhJutF3VU059MHDzMgqhl6Kfm6+gsiswFJYN25cbYPl6xiQZUgaGMDTdZOD?=
 =?us-ascii?Q?vnDei2EVBluQ6Yt3oyzHbzCqEawH8j4oPVUuk+uH9K/WqOOgT6C7VMYPQ3YZ?=
 =?us-ascii?Q?j7FOvpFs2lub1fiLw1j51mv1YBxkitnEFnyrekDGjxBqvkh8vn/7tt7U8smo?=
 =?us-ascii?Q?SIRCZXpieLlOBY+6a9sbNuXvK9tVjfCzihwEMhz7L/QtYU3a63B2yOh9ngXN?=
 =?us-ascii?Q?4L9DQlP/xikUa7If2ku2ZJA/Uf9TZzJq4qA3/O93VYNxAbYmCc/A8/DFX5ZY?=
 =?us-ascii?Q?dQ5nU7G5OixVxW0LRXNkh4EXSGWJ0wrwVqy7IpclUdfAm7RIGthM3TS5MoKj?=
 =?us-ascii?Q?61WYvj/EOVDb6eaLhjJXTR+Vl3bgdD9JEleBx+DBJr7BWTVeEdgum/sS3QMy?=
 =?us-ascii?Q?I8Rt/sytwH88hUehAVLJ341qlDNfc/LaYyCI3gsHm7yRL9/js/oxIA9/W4wy?=
 =?us-ascii?Q?xz4KS0BfhJH4K7ELR5VCJdCyW8WAXpevTR3VheOsNH1lvkU0EtUAVQ6YNWew?=
 =?us-ascii?Q?3XR/ItL+UXk3rBoFr9NuSIRR/m/+4rZbSC2hRBk4MFnhzEdr2Ftt+DNUGgXn?=
 =?us-ascii?Q?u9M5JkoLDngbQZUK0CM2RhQgSyYs379u2t6r1qYau47xxi3OrYji1KRdKsgm?=
 =?us-ascii?Q?p/cwAFANXUa/wBWZfaMnei9ALTYvnQ7BsuYl5xeXdEfAIICuCgai0tfiM8c1?=
 =?us-ascii?Q?9i/91bvu5Z5ETFe1WoGqYaXaSDVJtCF0TcBvdpGSdNIqgQVz+5Z7N3PIjaGH?=
 =?us-ascii?Q?OWitUGVN0zWfZ7yZIcIJOPBAnN8V6iwDQ56HsS+FKsB2PySc5zyl8SDasZ+C?=
 =?us-ascii?Q?71Bx+QNIogu7B5Q7fGoM952evWlPHF5zSBS0L8PSmlEITIwXcjcNRxCE9pf8?=
 =?us-ascii?Q?LJVujdiNGdLwZBzJ+lcmD5WwkRF4ffwIL1tP+IBwmOuW8kxkWKX/ZUp4RKvQ?=
 =?us-ascii?Q?rM82DpHcqG+y93VsWvyAWGeUhV5a//LNEHrUbYPCwcFg2vb0dZf1j9C68X8q?=
 =?us-ascii?Q?MzIY8eHaO4NHcrwkmfaDey2qAhjfeJauDiK6Xf64RTRYsGo2gE2IRCv6t80b?=
 =?us-ascii?Q?evt/gZC6HR/WfrsfuY1666K+9FdLVum9ZvsD0U8L4rOdON31aMNyGNalH9P/?=
 =?us-ascii?Q?sAM/HHg0pSllfJC5nr0KYmaoeCXvREjVWAfbWFotmNSRmuksCzMbTrPIzBuh?=
 =?us-ascii?Q?sjnxqA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 677e3986-4d80-4723-4cfc-08db2bb8f550
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 16:09:19.4120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uDlxKJKuQ9qvoQNdOWLKFG7LFtoWhNC0X3nBpK7QpiVUMfsL/prlMPspjSNc0/F0fJWYd2ImTfj86IKp4xoexlQ67KD/GL1CbG6QI9T6uv4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR13MB4435
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 01:38:17AM +0200, Vladimir Oltean wrote:
> It appears that dpaa_enable_tx_csum() only calls skb_reset_mac_header()
> to get to the VLAN header using skb_mac_header().
> 
> We can use skb_vlan_eth_hdr() to get to the VLAN header based on
> skb->data directly. This avoids spending a few cycles to set
> skb->mac_header.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>