Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230323113324.361991-1-b-kapoor@ti.com> <20230323135323.GA309305@hu-bjorande-lv.qualcomm.com>
In-Reply-To: <20230323135323.GA309305@hu-bjorande-lv.qualcomm.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 23 Mar 2023 17:09:06 +0100
Message-ID: <CAMuHMdUF5x=nVMKFFffbbe6S2nGWzq2UZWX36JgyXBGLBVL1rw@mail.gmail.com>
Subject: Re: [PATCH v2] arm64: defconfig: Enable CAN PHY transceiver driver
To:     Bjorn Andersson <quic_bjorande@quicinc.com>
Cc:     Bhavya Kapoor <b-kapoor@ti.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        catalin.marinas@arm.com, will@kernel.org,
        dmitry.baryshkov@linaro.org, arnd@arndb.de,
        krzysztof.kozlowski@linaro.org, geert+renesas@glider.be,
        nfraprado@collabora.com, broonie@kernel.org, rafal@milecki.pl
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Mar 23, 2023 at 2:53 PM Bjorn Andersson
<quic_bjorande@quicinc.com> wrote:
> On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
> > Enable CAN PHY transceiver driver to be built as a module.
>
> Please use the commit message to describe why the driver should be
> enabled. The patch and the subject already states clearly that the
> driver is being enabled.

And if no one has inspiration: I wouldn't mind "because it is needed
for CAN-FD on the Renesas White-Hawk development board" ;-)

> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
> >  CONFIG_RESET_RZG2L_USBPHY_CTRL=y
> >  CONFIG_RESET_TI_SCI=y
> >  CONFIG_PHY_XGENE=y
> > +CONFIG_PHY_CAN_TRANSCEIVER=m
> >  CONFIG_PHY_SUN4I_USB=y
> >  CONFIG_PHY_CADENCE_TORRENT=m
> >  CONFIG_PHY_CADENCE_SIERRA=m

For the actual change:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds