Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 17:09:54 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/9] net: dsa: tag_ocelot: do not rely on
 skb_mac_header() for VLAN xmit
Message-ID: <ZBx50lRkpmZudYI3@corigine.com>
References: <20230322233823.1806736-1-vladimir.oltean@nxp.com>
 <20230322233823.1806736-5-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322233823.1806736-5-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7bBAm1Sed7zsG0fxkFIrfqhyHNFXGA57PKl+xwY0drFRNiEane7dhem7d3oR?=
 =?us-ascii?Q?JBgEAN/L+1ga6l4/r0iEeaJcq8512Kmt2/AqGZwGVwc657/KHF2smv073G3B?=
 =?us-ascii?Q?m9epr1GXc64R+9eid+1KxWPZfsjhQwG0m6qbG1kSipXpiHDN8OtVHkE76QpI?=
 =?us-ascii?Q?cBpCIj0nbeQVXYb4z6tfq6s323QW52kpCa7vMLt1Xk57jvptcPWXK7kEewO7?=
 =?us-ascii?Q?7m4r7KzLdXRKSthtfEqokg7LuGUwjkhtvocHR8jLU5LLSzFImzr+RJtEajm+?=
 =?us-ascii?Q?n0s/UDhkZ0gR4yOYRhqTmb2kIPRLqJf+evMzBvI8bNNlaO+k46lcYsw0vAr3?=
 =?us-ascii?Q?UFpxCa95BtFuQK48rVAt7EbxGbyUwuDulYS5MhtBzeiHms5uXE6Ovg6O/tB/?=
 =?us-ascii?Q?2Sf1LAIs0lZIOH90Jpzm7WGmlZYp6+z8/SJNPA0HmrSBEfl7FCWuHUUcS0d7?=
 =?us-ascii?Q?YauI3pCkQDG9NXQs3KVudCL4qrgrvxIYYlwShGvZV24Qa4dNpPISocdjVPW+?=
 =?us-ascii?Q?mkh41k+S972sPRVTnt2rO9yM9pKd0rHFOj0AwB7ucrZX5OQeMiP9d6BFBuSk?=
 =?us-ascii?Q?wJkNAUWP8c5V8PJPzE27z2bde1fYDoVmnfJyaioy4qSsUoJyDfx+qXkyUmF3?=
 =?us-ascii?Q?DrcQaKOTGbEXwTvlu57ZEjX8dwcdEhSnt5sh99HaJAngAR7ErbGwoWRH0roX?=
 =?us-ascii?Q?ZTAnbwFMzH7vy8hg5P0ECbfrcbhcPn7SAn+KvwHhji17QXIsqGT/LKN8I+HQ?=
 =?us-ascii?Q?xJ+WTLYPzwL4gU5H51zrS1utD8lRB4P1tkoEgAZNsl+nb2ZUaw3NX22T3snx?=
 =?us-ascii?Q?J65oS34mEXz9JB7G0AaWOCy411QNT0ZRV3kmrQHn9JASmJjN88e1tHGw1MCE?=
 =?us-ascii?Q?jw2yCdJHSqrUYmEsG43XgCJPmvwRkRyHt642KU6VvangNTfgjJnsrZCVajfV?=
 =?us-ascii?Q?5cNCLs203wiQcSWRE3uv3TrPSXUSUvcj6t3vJ+vkXXQ6m5/H9HyeGJuBZhfz?=
 =?us-ascii?Q?BKqoMIOKkHkFcQQ9fjhEDZ3hevXwCKtxLDKe1MxxJYMx+jv3ZTGQl78LQfkg?=
 =?us-ascii?Q?slY6idcWyJVKfy5K44gOxovpSPNGH/4vIV97wJx339o1xJTp4+u0N/G+LE4N?=
 =?us-ascii?Q?n7UJgizRKRVHhcOisLbDNhGwgIus3P1SDRIKFZlKOdNfaxaPKXNOZfmZT3ew?=
 =?us-ascii?Q?vRMuvPE7XWAtY/f9+LWoJ8tbuxuGgPjADlsOXyF/r6sWzlKnMyLUMFWI/Ai+?=
 =?us-ascii?Q?yCg5qYTnCBRyWjufz9S/0m0CqVVTI6h2U+O/4OhKmZO3JX8qYRE9+NiTlPJO?=
 =?us-ascii?Q?MRe9CqpteRSbVBruHqU+LJaU6LWmhanQLwLqDHNGarYoRQG0fTTGVjfUfkv8?=
 =?us-ascii?Q?w+pb0CdL9EVfKCuBJCruDie8rQvlFonVOcEZtXiFhcor2zB6SOrP5HSfczPw?=
 =?us-ascii?Q?/k9zdLdnJOSnC6ExA1SuAEBHTUKuhTiANA0I0KeCslExx6t0yYTk1b0GJott?=
 =?us-ascii?Q?eFrZsMlJIgPNMuYlm47YPetxIQKGVtBZVqe7VPa3/Cavpn0cn7lFQLUQv11P?=
 =?us-ascii?Q?+2h1uvjUcNCttWRebDUjD+J4I83R7hzC9lewUvVT1L0TSsyNKQgL2+iIcRlz?=
 =?us-ascii?Q?EbU5hYY2K3AYVxicox1BHi+GHUbzYP8FM17TP5jPnr/PLHz/MrfxEbR37FxH?=
 =?us-ascii?Q?3TH6xQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e531540-ea72-49d0-d085-08db2bb90e54
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 16:10:01.4159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2v9GUSI0IcbEYdTox2GxN6ha18IM2GpaRONz5sj4gTFwRUE1R361OL8R43xOng8DbIoU26SR0xMPmRwf9maDzSkTfiMQo0bZruRDhBH2k9E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR13MB4435
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 01:38:18AM +0200, Vladimir Oltean wrote:
> skb_mac_header() will no longer be available in the TX path when
> reverting commit 6d1ccff62780 ("net: reset mac header in
> dev_start_xmit()"). As preparation for that, let's use
> skb_vlan_eth_hdr() to get to the VLAN header instead, which assumes it's
> located at skb->data (assumption which holds true here).
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>