Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 17:11:21 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 5/9] net: dsa: tag_ksz: do not rely on
 skb_mac_header() in TX paths
Message-ID: <ZBx6KXoosEVuZZhD@corigine.com>
References: <20230322233823.1806736-1-vladimir.oltean@nxp.com>
 <20230322233823.1806736-6-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322233823.1806736-6-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0zXEsL55YWu07BWTg6ypyaUm9yGMJxco3/Bo9g537S0RJmvkSowl2m2vKMzp?=
 =?us-ascii?Q?GNa3zR/PS1r510VKkGMRwp505pm5Ioo+DNamaRIOuCuLiCAuQe5KcWEAXGtd?=
 =?us-ascii?Q?2lH6xELxVpcU+SuzvV2zVy0mh5aSwCV+YrQc3lCeuJXacOAFnk9NWbgn0LaP?=
 =?us-ascii?Q?T4mwi3RBvO+/o+j7hH8j/Vuw5R3vxW8ncFauuGapO1QHOoRPrwi2mx79FDFI?=
 =?us-ascii?Q?qZsCSEOKH+POa7qJFJs0OZmvbIf6x16R9bM4zxHpNggICGBeBuN3jZ8Il5UU?=
 =?us-ascii?Q?Z1nUjPqvgl0Eoqr3uKmfSCEi9IAzwglYGQ+F+GNzAWtI0+2IYpy9Tj1VIwVp?=
 =?us-ascii?Q?qXsoXPQj/SqGOc8T4c8evKzoGB8Y1I2z2aVhFMjOuZIRL1MHCws0CXJVCAlY?=
 =?us-ascii?Q?z29kSz1m3JfJnDisypaVywb8ZkFoCGjvo+zyOq8gQ+/HoBFamOiBKDkf+ceH?=
 =?us-ascii?Q?6/+pL2TC4FRleeNPK0cnrpkWW9qCChmcObzyUYZ5kdqyuWlcD5J4vdcvmrUK?=
 =?us-ascii?Q?lm7ATTt5/GFUKbZkUKhimGm+BoPYPXlMrzJGrUpfqAc85Q/gpRQng7PBgA9F?=
 =?us-ascii?Q?Q7nG+EsnHR32OhEkg0lWvAJgPQ7aSLhsR80JXVjGVJiWpHIeE2ee4JIiPVmk?=
 =?us-ascii?Q?u+Zvg5EdZIm949eFqgcn5sYwsAmSh8vZ/tX2HUT7L1zyfKJUN0D3XE0V522a?=
 =?us-ascii?Q?rFUomTfkfn7PiSazPYva2UvL2IgRhKA2mio7s0MIlwRsj6q7eK55Z09NqIf3?=
 =?us-ascii?Q?fAbH7gWe9JgpyxEz9lrbWDzbRBdVbIoZHC41uqpZ8sYRndQJZ2g+ooa1HJpo?=
 =?us-ascii?Q?bQmxr1DhlHHvIzVdEPWpBs15eMxxsjTiA4+Kgt2M3UMKaOyV4f8kppr39NCF?=
 =?us-ascii?Q?uZmvTsvCwifWxxUWpfKCOu7PGec+V6hbg3EuK3tSnyl4GSrCSoIz+N/tg9nZ?=
 =?us-ascii?Q?5xQ8b8dmyKTo2G2WjsXv6zvjyM3jce4Zr1ehwbfIsdaS9HVFaazBudW1p8Cb?=
 =?us-ascii?Q?eMVUc/QAMznxui9qpo9/XHlf2sjM6yKLAaSowSmhyx8E2JisgeFLcUIXJAVu?=
 =?us-ascii?Q?JTsl6cxeEPeKxGf9hfjpPZ4hiptoXEC9xhB2jWO5M3N7bBNiwSItosFMUq6b?=
 =?us-ascii?Q?MJDhKVZafaJwR2BHrK07a+f9298X57DeBflNSOJM+//QgOXnIaLSEgmx2f5u?=
 =?us-ascii?Q?F7Als2WAz0gY9gQ1Dw0bvPCM1Q8QSUbThbv0CKZOBPmWNeTSwGKyeBaDXWIi?=
 =?us-ascii?Q?HwI6IbXU2SSB/LCsF7E9tjhb7hWcmxfLH/CtrPCb76HYzImSTuLLJcfMD4Y8?=
 =?us-ascii?Q?ShwSAtOwBh5UcNOCuuSqrGzP5yVIeiDYNbxeW0f4Z/syF9ez/VQx3YwQlM7F?=
 =?us-ascii?Q?cIhEbAgyP9N3YUuqI0kbBZ0BSweFjUofQApmXZVWAGIQqul1gRw91W6NLqGt?=
 =?us-ascii?Q?XBjhImBLKUmgOuZZe+2jvHJbcCwK1mYFTbvIZR+2v6xUO0S9OCJQqzmi1IJg?=
 =?us-ascii?Q?VtFT3taRFqUhD2Y0t4FX2iK8n2vQyNCam7mWpW11oDZqVez4X5Ri/GDXu2yL?=
 =?us-ascii?Q?VFsbp0a5tZraersjK/E/mGQZ/1EWZTtFEF5dgQ/aoOm/xwnag88tMmnYn/54?=
 =?us-ascii?Q?WtH9eimJceMpEd+gjav5eaNG/fjzSrX4EAtLm5QZReyaFtJw/cBLtcSXMPbV?=
 =?us-ascii?Q?43wTgA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25ab5a86-f87d-4ea4-369f-08db2bb941de
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 16:11:27.8658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4+2zKmFLH7f+aeztEkAB+gd3DRi9sqqDctbFDtFNRpX4cGRGOExV5NFl1J2x56g8T3J0Wi68ekbIGB9xPLfyz8ANyh2Fzl5F++XdRKImXIM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4654
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 01:38:19AM +0200, Vladimir Oltean wrote:
> skb_mac_header() will no longer be available in the TX path when
> reverting commit 6d1ccff62780 ("net: reset mac header in
> dev_start_xmit()"). As preparation for that, let's use skb_eth_hdr() to
> get to the Ethernet header's MAC DA instead, helper which assumes this
> header is located at skb->data (assumption which holds true here).
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>