Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 17:11:58 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 6/9] net: dsa: tag_sja1105: don't rely on
 skb_mac_header() in TX paths
Message-ID: <ZBx6TkdSJmXmwcqw@corigine.com>
References: <20230322233823.1806736-1-vladimir.oltean@nxp.com>
 <20230322233823.1806736-7-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322233823.1806736-7-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aRYuBuj4uISLJhRnGWeEixHLGA/fn8uZZPAXAcxMVkbUPymFP6MTwNbXSZWc?=
 =?us-ascii?Q?uEm60CryGZ3UcFvXcHqmgIE40/2O694vm0vXLxAcQ/iDCeW1+4Ubnvcw63n3?=
 =?us-ascii?Q?jbCePt7+z7sXP3lSc5rzx5WmP6u5L3GEXKNTC5g6gzRAExVtbmdoym7vCu7t?=
 =?us-ascii?Q?oBlvivOuwFfuZP/vk3mN15XqVpX8R+LlvzRp0GX4oyi4ggc6ywTpKumZVQKR?=
 =?us-ascii?Q?LJWDu+zb/13PISMiqU+YHU+/ax0HWrU7ruKjeSxhNt8DRurDiRtmrnpS3dfx?=
 =?us-ascii?Q?09aPUVV9jegXWNUtuM9fdQ04gpV3L8cH7kAwHVjK1ckuk0qMeMOMnKs1e6+g?=
 =?us-ascii?Q?xjSdkh18MFGDYJYae0SWYgV7xU6rM7av5YoI4UWwnFYUWjG/4TL4yU3AxPFU?=
 =?us-ascii?Q?vUSg5lNlcZYwKUxG4cosCqgRlNI/GTNg2izp7rWWIX26R98g/JAwEbxWnZdl?=
 =?us-ascii?Q?aqY0ioj/h5XOXukEFfCFDh/xsy14oBC1tZl9KH87BtRu9krgEfCkZfX+UemP?=
 =?us-ascii?Q?ao21q9q342L2wg/JjBq03N3ysqfVIp+cOnjxf5c4qcd2foHaMl7MmMZ8cuky?=
 =?us-ascii?Q?4nd11M3pcA3Bc0UH/XmnGvpnvZ1c1GejUw0V+fX+d7ou5ivE67t23EBb3bQD?=
 =?us-ascii?Q?L5VEsY5zzjWS/8hABSfCZiRWgNhU2FW5/TeNzQ40UWa/SASHkoGNkJ9VYBi/?=
 =?us-ascii?Q?+4nn5SWLWENr6lVaC4oREXJAbI5m8DBvTKBQWgIe0SZTcgSAWAHi8+zL+FhS?=
 =?us-ascii?Q?cbwHIugegohlSqxWFwpXcCXRjfCtTiCmTQL0n7A1FTR6tHd/7IOxKOEORt40?=
 =?us-ascii?Q?J+hOjAO+I6arWolvvfXCPJnVkATNjM5mS6xgDHAnYj+APtkRpjA6PuYSmqId?=
 =?us-ascii?Q?uqzJhs6nBhcAFeFfutvUUOC17T90gx8S+0NmZczDNcZ+Bp2J7h30kHZFm0kh?=
 =?us-ascii?Q?O6giKqJjB8esnfG4q9l8vwSH/PGMEN1pygMcNr/Kn5+0HgJlwFN2E4MCGvQI?=
 =?us-ascii?Q?iIh8pKdLDWwE4lL9lGQHJR2U9Nt0zOUQUsh8aCaoQLa1RDMW9t6jo1OrHkVN?=
 =?us-ascii?Q?Fb+eIfc4ucwGT1I5560j+poOcHDi6FeesY94ps5bVqXpFdGUKtAPWXk/4sAh?=
 =?us-ascii?Q?DryzGT8sWTTgLtoivP1FE2ljURav9A6Uq0W+1ykHR86b4iYAcfDTwsjCA+iC?=
 =?us-ascii?Q?2oKnWbSIfTuanC0ZFRuAeYETJUgxerS/XZc9PXosDJAHeXuzvDaTmX4DyaqZ?=
 =?us-ascii?Q?kfuhcov55NL1iXJQvtrk8U4AVLmUTwH3sQra1x4ZtK2LooZwfS1dheLPsJ9d?=
 =?us-ascii?Q?DoVbBlclgv1wdT5Yk8g+ilEBVB+Dusz2lakeIlHF3cgcTRQIPYyXrMOOyCZI?=
 =?us-ascii?Q?mL8Mq6+TB7med+xDPDApcXuPFPIV/GJFURPGmtZ7v1dUMi2b5n2X4MWxKh0M?=
 =?us-ascii?Q?S5RmMRsbEQPodsTRbWYbqY87WUvByVguOIsnD6vdBm+96wl7APwguaQ/krSM?=
 =?us-ascii?Q?KZx4kuZTwpcIx67zjEv+nHEqfbBdmpeAN4KGTOTpfoDD18WgbHg0Fs7nBGtD?=
 =?us-ascii?Q?0FS7IHDVw0s3JIA4GjACRmrWZCTWKNSkILK8OGoLbliGGwwat2e1cVNfz1LU?=
 =?us-ascii?Q?rkAjdqOrP9XADyDNi2tsX91tPaS9nxgt/PSNCb49/la+CAaqvswNhaBwJnjz?=
 =?us-ascii?Q?9ZlxDA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ab8baff-2e56-412c-f532-08db2bb957f7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 16:12:05.0837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SZfgHxQ01rrrypRX9+EWhYD8vIKz3p9ujPOrHASfPu68xqRFtWi4pXU9nGS7RFYpTfzsGqoeG9fWxGvkAHFOW/y/jBGmstkrDEG701NQ8uE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4654
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 01:38:20AM +0200, Vladimir Oltean wrote:
> skb_mac_header() will no longer be available in the TX path when
> reverting commit 6d1ccff62780 ("net: reset mac header in
> dev_start_xmit()"). As preparation for that, let's use
> skb_vlan_eth_hdr() to get to the VLAN header instead, which assumes it's
> located at skb->data (assumption which holds true here).
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>